diff mbox series

arm64: defconfig: Enable HSR by default

Message ID 20230612094340.13865-1-r-gunasekaran@ti.com
State New
Headers
Series arm64: defconfig: Enable HSR by default |

Commit Message

Ravi Gunasekaran June 12, 2023, 9:43 a.m. UTC 
  Enable HSR feature in kernel build.

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Ravi Gunasekaran June 12, 2023, 9:49 a.m. UTC | #1 
On 6/12/23 3:14 PM, Krzysztof Kozlowski wrote:
> On 12/06/2023 11:43, Ravi Gunasekaran wrote:
>> Enable HSR feature in kernel build.
> 
> Why? Commit msg should answer to this question.

I apologize for incomplete description. I will send out a v2.

HSR protocol is implemented by the network stack at /net/hsr/*
In order to create HSR interface, HSR module needs to be loaded.


> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski June 12, 2023, 9:51 a.m. UTC | #2 
On 12/06/2023 11:49, Ravi Gunasekaran wrote:
> 
> 
> On 6/12/23 3:14 PM, Krzysztof Kozlowski wrote:
>> On 12/06/2023 11:43, Ravi Gunasekaran wrote:
>>> Enable HSR feature in kernel build.
>>
>> Why? Commit msg should answer to this question.
> 
> I apologize for incomplete description. I will send out a v2.
> 
> HSR protocol is implemented by the network stack at /net/hsr/*
> In order to create HSR interface, HSR module needs to be loaded.

You described what HSR is, but I want to know why do we need it in our
development arm64 kernel. You might want to enable anything and explain
what is this "anything" but this does not solve any of the concerns.

Best regards,
Krzysztof
Ravi Gunasekaran June 12, 2023, 11:55 a.m. UTC | #3 
On 6/12/23 3:21 PM, Krzysztof Kozlowski wrote:
> On 12/06/2023 11:49, Ravi Gunasekaran wrote:
>>
>>
>> On 6/12/23 3:14 PM, Krzysztof Kozlowski wrote:
>>> On 12/06/2023 11:43, Ravi Gunasekaran wrote:
>>>> Enable HSR feature in kernel build.
>>>
>>> Why? Commit msg should answer to this question.
>>
>> I apologize for incomplete description. I will send out a v2.
>>
>> HSR protocol is implemented by the network stack at /net/hsr/*
>> In order to create HSR interface, HSR module needs to be loaded.
> 
> You described what HSR is, but I want to know why do we need it in our
> development arm64 kernel. You might want to enable anything and explain
> what is this "anything" but this does not solve any of the concerns.
> 

TI SoCs such as AM64x, AM65x support multiple ethernet ports which can be
used to setup HSR (a redundancy protocol) node in the network. So enabling
the HSR driver to be built as module. The HSR node can be created using a
pair of ethernet ports in the system.

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 8d850be05835..c980268eaea4 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -138,6 +138,7 @@  CONFIG_IP_PNP_BOOTP=y
 CONFIG_IPV6=m
 CONFIG_NETFILTER=y
 CONFIG_BRIDGE_NETFILTER=m
+CONFIG_HSR=m
 CONFIG_NF_CONNTRACK=m
 CONFIG_NF_CONNTRACK_EVENTS=y
 CONFIG_NETFILTER_XT_MARK=m