Message ID | 20230522193219.1477158-1-tharvey@gateworks.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1694920vqo; Mon, 22 May 2023 13:17:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4o8/retsjWxKIWncbrf+VAAsFqoN+6fOFBnjHnTFmj3+tRMIMEyLVtPn9WxFqsTj/lV0gT X-Received: by 2002:aa7:888f:0:b0:64d:b0d8:a396 with SMTP id z15-20020aa7888f000000b0064db0d8a396mr4548973pfe.7.1684786637121; Mon, 22 May 2023 13:17:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786637; cv=none; d=google.com; s=arc-20160816; b=CMiNsvZ7E0/FE+zv45LeMIEqaThQE1fdlK7ePZ9Qmv8yd7ko/+DCdv7mTw06u4zhIu N2FXuHtJCPQph+ju6ajDF3eG4cM7uOFKTg8Fh4TNwJTQIbuU9D3XQIluDgB54ygcwOtB zCt/c03uwv1LIpqpaq0XXJw6ck5g20dgt5j5pcIS8moWgVV5xzXe03o7Fj8ZHHiVQhEU JYInrThnyCWhyJNwE5JQvJaT1x3FVqwudiURQG2jVaDvIHb020CusFPqUkJELb1xIKqS zrhDdNoq8QVXmV1Pd60rktwMDFkZiZtvuZkJzQirGiwEkK1m7eAeW/Pd9GWKqlsXzK/9 Tb1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lDGDBqkDPztHsFOCUsNpPws6BDiqRiNKc7Xbfd5npss=; b=b0ErY83cFpO+Mwl3rD/GTydR0nsPI18xTKzqMx84wQbKHXHv6w83Hdfsts7Im10V9k g5FVXwwACLXE3f5o5p2dsydoSYVEY3svezcaRI6kK/KjhvtiMpv5iQW4HIpYMc5HzjOw xhAVv4/asPblU2Vlyi1VbyrVDBR0X4t/nT9l1e7hARcljXErMVjg4nJhU69OKmAlmndw QaAKi9FdO16kwqMLOWhgthx5eHqHyKdAuvJ1kiGeNE26g/kF0W18o7O1QHEGZwxtWr1W 5obvc+oU80kH1o7yL9VA5cDzghQcbQ9kPzRRbbAZjnTV1YauCGuhqpVGgcJ/b1reQ/2f UpmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020aa79630000000b0064d675fc97csi2745024pfg.27.2023.05.22.13.17.02; Mon, 22 May 2023 13:17:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234829AbjEVTd3 (ORCPT <rfc822;wlfightup@gmail.com> + 99 others); Mon, 22 May 2023 15:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234799AbjEVTdV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 22 May 2023 15:33:21 -0400 Received: from finn.localdomain (finn.gateworks.com [108.161.129.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3299719B; Mon, 22 May 2023 12:32:43 -0700 (PDT) Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139] helo=tharvey.pdc.gateworks.com) by finn.localdomain with esmtp (Exim 4.93) (envelope-from <tharvey@gateworks.com>) id 1q1BGX-005dnF-D7; Mon, 22 May 2023 19:32:21 +0000 From: Tim Harvey <tharvey@gateworks.com> To: linux-arm-kernel@lists.infradead.org Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>, Tim Harvey <tharvey@gateworks.com>, Conor Dooley <conor.dooley@microchip.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH v2 1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes Date: Mon, 22 May 2023 12:32:16 -0700 Message-Id: <20230522193219.1477158-1-tharvey@gateworks.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626832892059114?= X-GMAIL-MSGID: =?utf-8?q?1766626832892059114?= |
Series |
[v2,1/4] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes
|
|
Commit Message
Tim Harvey
May 22, 2023, 7:32 p.m. UTC
Remove the unnecessary #address-cells and #size-cells nodes from the fan-controller. These are not needed as the fan controller does not have any children. Signed-off-by: Tim Harvey <tharvey@gateworks.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- v2: - udpated commit log to explain why the nodes are unnessesary - added Krzysztof's rb tag - added Connor's ab tag --- .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- 1 file changed, 10 deletions(-)
Comments
On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > Remove the unnecessary #address-cells and #size-cells nodes from > the fan-controller. These are not needed as the fan controller does not > have any children. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v2: > - udpated commit log to explain why the nodes are unnessesary > - added Krzysztof's rb tag > - added Connor's ab tag > --- > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > 1 file changed, 10 deletions(-) This is not going to get applied if you don't send it to Lee. > > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > index acb9c54942d9..dc379f3ebf24 100644 > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > @@ -122,12 +122,6 @@ patternProperties: > compatible: > const: gw,gsc-fan > > - "#address-cells": > - const: 1 > - > - "#size-cells": > - const: 0 > - > reg: > description: The fan controller base address > maxItems: 1 > @@ -135,8 +129,6 @@ patternProperties: > required: > - compatible > - reg > - - "#address-cells" > - - "#size-cells" > > required: > - compatible > @@ -194,8 +186,6 @@ examples: > }; > > fan-controller@2c { > - #address-cells = <1>; > - #size-cells = <0>; > compatible = "gw,gsc-fan"; > reg = <0x2c>; > }; > -- > 2.25.1 >
On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > > Remove the unnecessary #address-cells and #size-cells nodes from > > the fan-controller. These are not needed as the fan controller does not > > have any children. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > v2: > > - udpated commit log to explain why the nodes are unnessesary > > - added Krzysztof's rb tag > > - added Connor's ab tag > > --- > > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > > 1 file changed, 10 deletions(-) > > This is not going to get applied if you don't send it to Lee. Lee, Sorry, I missed adding you to this thread. Can you pick it up or do you need me to re-send to the list and you? Best Regards, Tim > > > > > diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > index acb9c54942d9..dc379f3ebf24 100644 > > --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml > > @@ -122,12 +122,6 @@ patternProperties: > > compatible: > > const: gw,gsc-fan > > > > - "#address-cells": > > - const: 1 > > - > > - "#size-cells": > > - const: 0 > > - > > reg: > > description: The fan controller base address > > maxItems: 1 > > @@ -135,8 +129,6 @@ patternProperties: > > required: > > - compatible > > - reg > > - - "#address-cells" > > - - "#size-cells" > > > > required: > > - compatible > > @@ -194,8 +186,6 @@ examples: > > }; > > > > fan-controller@2c { > > - #address-cells = <1>; > > - #size-cells = <0>; > > compatible = "gw,gsc-fan"; > > reg = <0x2c>; > > }; > > -- > > 2.25.1 > >
On Fri, 09 Jun 2023, Tim Harvey wrote: > On Fri, Jun 9, 2023 at 9:00 AM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, May 22, 2023 at 12:32:16PM -0700, Tim Harvey wrote: > > > Remove the unnecessary #address-cells and #size-cells nodes from > > > the fan-controller. These are not needed as the fan controller does not > > > have any children. > > > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > v2: > > > - udpated commit log to explain why the nodes are unnessesary > > > - added Krzysztof's rb tag > > > - added Connor's ab tag > > > --- > > > .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ---------- > > > 1 file changed, 10 deletions(-) > > > > This is not going to get applied if you don't send it to Lee. > > Lee, > > Sorry, I missed adding you to this thread. Can you pick it up or do > you need me to re-send to the list and you? I need you to resend it please.
diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml index acb9c54942d9..dc379f3ebf24 100644 --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml @@ -122,12 +122,6 @@ patternProperties: compatible: const: gw,gsc-fan - "#address-cells": - const: 1 - - "#size-cells": - const: 0 - reg: description: The fan controller base address maxItems: 1 @@ -135,8 +129,6 @@ patternProperties: required: - compatible - reg - - "#address-cells" - - "#size-cells" required: - compatible @@ -194,8 +186,6 @@ examples: }; fan-controller@2c { - #address-cells = <1>; - #size-cells = <0>; compatible = "gw,gsc-fan"; reg = <0x2c>; };