[v2,1/2] pinctrl: cherryview: simplify exit path of set_mux hook
Commit Message
Simplify exit path of ->set_mux() hook and save a few bytes.
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34 (-34)
Function old new delta
chv_pinmux_set_mux 640 606 -34
Total: Before=19233, After=19199, chg -0.18%
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Comments
On Fri, Jun 09, 2023 at 02:03:55PM +0530, Raag Jadav wrote:
> Simplify exit path of ->set_mux() hook and save a few bytes.
>
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34 (-34)
> Function old new delta
> chv_pinmux_set_mux 640 606 -34
> Total: Before=19233, After=19199, chg -0.18%
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/pinctrl/intel/pinctrl-cherryview.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Ditto here regarding simplifying.
@@ -716,7 +716,7 @@ static int chv_pinmux_set_mux(struct pinctrl_dev *pctldev,
struct device *dev = pctrl->dev;
const struct intel_pingroup *grp;
unsigned long flags;
- int i;
+ int i, ret = 0;
grp = &pctrl->soc->groups[group];
@@ -725,9 +725,9 @@ static int chv_pinmux_set_mux(struct pinctrl_dev *pctldev,
/* Check first that the pad is not locked */
for (i = 0; i < grp->grp.npins; i++) {
if (chv_pad_locked(pctrl, grp->grp.pins[i])) {
- raw_spin_unlock_irqrestore(&chv_lock, flags);
dev_warn(dev, "unable to set mode for locked pin %u\n", grp->grp.pins[i]);
- return -EBUSY;
+ ret = -EBUSY;
+ goto out_unlock;
}
}
@@ -765,9 +765,10 @@ static int chv_pinmux_set_mux(struct pinctrl_dev *pctldev,
invert_oe ? "" : "not ");
}
+out_unlock:
raw_spin_unlock_irqrestore(&chv_lock, flags);
- return 0;
+ return ret;
}
static void chv_gpio_clear_triggering(struct intel_pinctrl *pctrl,