Message ID | 20230608012443.839372-1-suhui@nfschina.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp603412vqr; Wed, 7 Jun 2023 18:44:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6iOogjRiX8ZYYrQJlX12e55Fj2HE7xt6nGeCAkgI1B3MSRvy2aihJS/ZnPN5M28nSd+nNB X-Received: by 2002:a17:90a:31a:b0:255:63e0:1248 with SMTP id 26-20020a17090a031a00b0025563e01248mr4532307pje.0.1686188656232; Wed, 07 Jun 2023 18:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686188656; cv=none; d=google.com; s=arc-20160816; b=08Lqc5+zvmGXvsXUtJHWJHDhQXyo9/13dsAftF6xJORPMpvq0dKR7pZGGbxk0bOIZo 2/hyBS/qik1q+onNCCFJpRdqe7scDqx35ihKSaCyAC0hcjf9nps9VIUerU48Lm6beAvw WzX4L9vpK6qua7ntBMZ1d7qJ+xGw6jGl7J07aJnuEpYWX1/krw/V0Tx92yfo3UD0a6g2 aENe+/Bwek/UEKka18j5kqSgN8nACuQMLSfPuOE5ixLvy/1QwE2qpmmDkGRwNlPI2q8U m/533LG5bsW9AKrQ+lf1GtDTUcK20QF6nPhXMc8T8A3VOjSGp99F12mhe6Za01V9r0Ge qt4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iQ0xaUMRVLmt+k0883G9ZFLf4MaOz3YRJNr0IXjER1k=; b=sg72khUFvkj5CEDmS1YlZ0PXKfnp+F4fhzV4PQsdab5fqORQtlgc3tP1PTe2jL5jj8 t5uHZXbCFi2qfkTGhvVGJ1OUSkzVtPyVdcv9MHhR8IoZXDXQyycnlyAv5qE7DUcBR0xt KNDYbidnjPs9x+XvqRrs82hMuUi9Ct4Z0sEF7EmfbjqDL2XVuU6EWouQ4lyF74xwTdZU zmM9NvrF1S2xtMFNTwABjI+GciVVAIe5TCxUUBb5imr7IqE0XNx/JQS1BC1TRbnS8sOO YzYDIfFcA2lt4vIAqxuVDFwFfs8+pCuow4cNMTRuPi3IVzqNZp6HNfAeN6yZjmJwbFVl UbNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l192-20020a6391c9000000b005307169868bsi162300pge.488.2023.06.07.18.44.04; Wed, 07 Jun 2023 18:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232805AbjFHBZw (ORCPT <rfc822;literming00@gmail.com> + 99 others); Wed, 7 Jun 2023 21:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231476AbjFHBZv (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Jun 2023 21:25:51 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 7E8862103 for <linux-kernel@vger.kernel.org>; Wed, 7 Jun 2023 18:25:50 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id BB7171801125A4; Thu, 8 Jun 2023 09:24:44 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui <suhui@nfschina.com> To: Douglas Anderson <dianders@chromium.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: andersson@kernel.org, u.kleine-koenig@pengutronix.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Su Hui <suhui@nfschina.com> Subject: [PATCH v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow Date: Thu, 8 Jun 2023 09:24:43 +0800 Message-Id: <20230608012443.839372-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768006399725126304?= X-GMAIL-MSGID: =?utf-8?q?1768096956486605524?= |
Series |
[v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow
|
|
Commit Message
Su Hui
June 8, 2023, 1:24 a.m. UTC
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5.
Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
Hi, On Wed, Jun 7, 2023 at 6:25 PM Su Hui <suhui@nfschina.com> wrote: > > Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. > > Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 7a748785c545..4676cf2900df 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -298,6 +298,10 @@ static void ti_sn_bridge_set_refclk_freq(struct ti_sn65dsi86 *pdata) > if (refclk_lut[i] == refclk_rate) > break; > > + /* avoid buffer overflow and "1" is the default rate in the datasheet. */ > + if (i >= refclk_lut_size) > + i = 1; > + Looks great now, thanks! Reviewed-by: Douglas Anderson <dianders@chromium.org> Unless someone beats me to it or objects, I'll plan to commit this to drm-misc-fixes early next week. -Doug
Hi, On Thu, Jun 8, 2023 at 8:15 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Jun 7, 2023 at 6:25 PM Su Hui <suhui@nfschina.com> wrote: > > > > Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. > > > > Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") > > Signed-off-by: Su Hui <suhui@nfschina.com> > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > index 7a748785c545..4676cf2900df 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > @@ -298,6 +298,10 @@ static void ti_sn_bridge_set_refclk_freq(struct ti_sn65dsi86 *pdata) > > if (refclk_lut[i] == refclk_rate) > > break; > > > > + /* avoid buffer overflow and "1" is the default rate in the datasheet. */ > > + if (i >= refclk_lut_size) > > + i = 1; > > + > > Looks great now, thanks! > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > Unless someone beats me to it or objects, I'll plan to commit this to > drm-misc-fixes early next week. Pushed to drm-misc-fixes: 95011f267c44 drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 7a748785c545..4676cf2900df 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -298,6 +298,10 @@ static void ti_sn_bridge_set_refclk_freq(struct ti_sn65dsi86 *pdata) if (refclk_lut[i] == refclk_rate) break; + /* avoid buffer overflow and "1" is the default rate in the datasheet. */ + if (i >= refclk_lut_size) + i = 1; + regmap_update_bits(pdata->regmap, SN_DPPLL_SRC_REG, REFCLK_FREQ_MASK, REFCLK_FREQ(i));