diff mbox series

[v1,3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

Message ID 20230607115508.2964574-3-l.goehrs@pengutronix.de
State New
Headers
Series [v1,1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible |

Commit Message

Leonard Göhrs June 7, 2023, 11:55 a.m. UTC 
  This patch allows giving each of the controller's pins a meaningful
name.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
---
 Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andy Shevchenko June 7, 2023, 4:36 p.m. UTC | #1 
Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti:
> This patch allows giving each of the controller's pins a meaningful
> name.

Isn't it gpio.txt already mentiones this?
Perhaps you need to convert that to YAML and use it here?
Krzysztof Kozlowski June 8, 2023, 1:24 p.m. UTC | #2 
On 07/06/2023 18:36, andy.shevchenko@gmail.com wrote:
> Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti:
>> This patch allows giving each of the controller's pins a meaningful
>> name.
> 
> Isn't it gpio.txt already mentiones this?

TXT does not matter for DT schema. It's is already covered by dtschemas.

> Perhaps you need to convert that to YAML and use it here?

How would it solve anything? We still want constraints, right?

Best regards,
Krzysztof
Krzysztof Kozlowski June 8, 2023, 1:24 p.m. UTC | #3 
On 07/06/2023 13:55, Leonard Göhrs wrote:
> This patch allows giving each of the controller's pins a meaningful
> name.
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Bartosz Golaszewski June 13, 2023, 2:54 p.m. UTC | #4 
On Wed, Jun 7, 2023 at 1:57 PM Leonard Göhrs <l.goehrs@pengutronix.de> wrote:
>
> This patch allows giving each of the controller's pins a meaningful
> name.
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> index 5b0134304e51c..452f8972a9659 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> @@ -24,6 +24,10 @@ properties:
>    '#gpio-cells':
>      const: 2
>
> +  gpio-line-names:
> +    minItems: 4
> +    maxItems: 8
> +
>  required:
>    - compatible
>    - reg
> --
> 2.39.2
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
index 5b0134304e51c..452f8972a9659 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
@@ -24,6 +24,10 @@  properties:
   '#gpio-cells':
     const: 2
 
+  gpio-line-names:
+    minItems: 4
+    maxItems: 8
+
 required:
   - compatible
   - reg