| Message ID | 20230607072253.440613-1-suijingfeng@loongson.cn |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp73594vqr;
Wed, 7 Jun 2023 00:32:51 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7Rxn7Dh1Wh/rd+GSKO/rAkZhgpl+G2DprFRgYvr3EwE6uESNSCvsYNabE6hjmYGbwvlqxo
X-Received: by 2002:a05:6a21:3983:b0:101:1951:d491 with SMTP id
ad3-20020a056a21398300b001011951d491mr1367880pzc.6.1686123170749;
Wed, 07 Jun 2023 00:32:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686123170; cv=none;
d=google.com; s=arc-20160816;
b=YweF38JWr59PjUljU/2Pw0aK7BnObdrjEevQmpLagu5LZeHzkRE/abOhwh/T8LTFbN
MEoOXmZtvs8KD5b13qM5bhgy04g7PGjyozFRZioFlNx3SQXhNteGqBRqQqK9dDCnzgtI
7Vq3cMaFlETr7Nqm4DfsVK+uc64E4x3I5cd5llhLHjImbNkMjBp4rHAgge2z5ro4yKBS
GrbYCimhFgdRY2JpCwVH8Ds9mICMNuGJol5/cTk5vvTn+157MU/7k0WG8nmCfQjB2wAX
+ZwjJYfTaLZQ0NhcWpJiKiiVYSn4Id0oW0PkZUCTODC7hWkvZx58aULuLh88/WtFoTah
AP5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=vtD1akXaV5ibKeVNQGDkErlAZDfEdJn/RY0Gm9Og4oA=;
b=VnFIhtPeQPdiz5IZX+EpmDU6Ld+yi1f+bcZ+2qXf32YQKIag1rsAzbx8o6kqWtkUzC
vD7EgukbOBRgzp3mHkgbRzI+v4SWPnbkRn9+e5rAmilfaQ8MsooHm0O/Yf5hmoB34j8X
TV2co464bPYicr5JVToPQ07xVGx42Ta08TLP9zLXdmjQ5Li/VtUFT6TydGkuM4vK8uqP
g2TsNcOgXRo+pCpV8iU5B8R/DRkeJqFYAFzCPaOdjhdcKzU7KLczPKEBmh6cmUsW9OVR
m+Mul8T7FWzOLiTLJ81TKwQNZ6btXY6l5QTle8StCQtQvS+RV2bw0YIGl3QR9qq7LmQt
NrdQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
q9-20020a17090311c900b001a2a4eb10d6si746865plh.58.2023.06.07.00.32.37;
Wed, 07 Jun 2023 00:32:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S239195AbjFGHYE (ORCPT <rfc822;literming00@gmail.com>
+ 99 others); Wed, 7 Jun 2023 03:24:04 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53374 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S239082AbjFGHXi (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 7 Jun 2023 03:23:38 -0400
Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A93C2121;
Wed, 7 Jun 2023 00:22:57 -0700 (PDT)
Received: from loongson.cn (unknown [10.20.42.43])
by gateway (Coremail) with SMTP id _____8AxHutOMIBkWQ4AAA--.205S3;
Wed, 07 Jun 2023 15:22:54 +0800 (CST)
Received: from openarena.loongson.cn (unknown [10.20.42.43])
by localhost.localdomain (Coremail) with SMTP id
AQAAf8DxbMpNMIBkPQEEAA--.6109S2;
Wed, 07 Jun 2023 15:22:53 +0800 (CST)
From: Sui Jingfeng <suijingfeng@loongson.cn>
To: Paul Cercueil <paul@crapouillou.net>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Date: Wed, 7 Jun 2023 15:22:53 +0800
Message-Id: <20230607072253.440613-1-suijingfeng@loongson.cn>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: AQAAf8DxbMpNMIBkPQEEAA--.6109S2
X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/
X-Coremail-Antispam: 1Uk129KBj93XoW7XrWxWw1fuFyfWr4fCryDJwc_yoW8Jr4rpF
sxt34kuFWxZFWvk3y7AFyxWa45Z3W5XFWSkF93twn09r98AFW0yrZxAFW3XFyDAwnrX3y2
qas3KFW7tFyUZFcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa
sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU
0xBIdaVrnRJUUUkSb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2
IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v
e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI
0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK
xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx
1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv
67AKxVWxJVW8Jr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28Icx
kI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2Iq
xVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42
IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY
6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Cr0_Gr1UMIIF0xvEx4A2js
IEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjxUFwZ2UUUUU
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768028289700006174?=
X-GMAIL-MSGID: =?utf-8?q?1768028289700006174?=
|
| Series |
drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
|
|
Commit Message
Sui Jingfeng
June 7, 2023, 7:22 a.m. UTC
Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig
make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
SYNC include/config/auto.conf.cmd
Checking missing-syscalls for N32
CALL scripts/checksyscalls.sh
Checking missing-syscalls for O32
CALL scripts/checksyscalls.sh
CALL scripts/checksyscalls.sh
MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Sui, Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit : > Otherwise its failed to pass basic compile test on platform without > REGMAP_MMIO selected by defconfig > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > SYNC include/config/auto.conf.cmd > Checking missing-syscalls for N32 > CALL scripts/checksyscalls.sh > Checking missing-syscalls for O32 > CALL scripts/checksyscalls.sh > CALL scripts/checksyscalls.sh > MODPOST Module.symvers > ERROR: modpost: "__devm_regmap_init_mmio_clk" > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > make: *** [Makefile:1978: modpost] Error 2 > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/ingenic/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/ingenic/Kconfig > b/drivers/gpu/drm/ingenic/Kconfig > index a53f475d33df..7457c0b65034 100644 > --- a/drivers/gpu/drm/ingenic/Kconfig > +++ b/drivers/gpu/drm/ingenic/Kconfig > @@ -5,6 +5,8 @@ config DRM_INGENIC > depends on CMA > depends on OF > depends on COMMON_CLK > + select REGMAP > + select REGMAP_MMIO nit: order alphabetically (move them after the DRM_* ones). Cheers, -Paul > select DRM_BRIDGE > select DRM_PANEL_BRIDGE > select DRM_KMS_HELPER
Ok, thanks On 2023/6/7 17:46, Paul Cercueil wrote: > Hi Sui, > > Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit : >> Otherwise its failed to pass basic compile test on platform without >> REGMAP_MMIO selected by defconfig >> >> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- >> >> SYNC include/config/auto.conf.cmd >> Checking missing-syscalls for N32 >> CALL scripts/checksyscalls.sh >> Checking missing-syscalls for O32 >> CALL scripts/checksyscalls.sh >> CALL scripts/checksyscalls.sh >> MODPOST Module.symvers >> ERROR: modpost: "__devm_regmap_init_mmio_clk" >> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 >> make: *** [Makefile:1978: modpost] Error 2 >> >> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >> --- >> drivers/gpu/drm/ingenic/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/ingenic/Kconfig >> b/drivers/gpu/drm/ingenic/Kconfig >> index a53f475d33df..7457c0b65034 100644 >> --- a/drivers/gpu/drm/ingenic/Kconfig >> +++ b/drivers/gpu/drm/ingenic/Kconfig >> @@ -5,6 +5,8 @@ config DRM_INGENIC >> depends on CMA >> depends on OF >> depends on COMMON_CLK >> + select REGMAP >> + select REGMAP_MMIO > nit: order alphabetically (move them after the DRM_* ones). > > Cheers, > -Paul > >> select DRM_BRIDGE >> select DRM_PANEL_BRIDGE >> select DRM_KMS_HELPER
Hi, On 2023/6/7 17:46, Paul Cercueil wrote: > Hi Sui, > > Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit : >> Otherwise its failed to pass basic compile test on platform without >> REGMAP_MMIO selected by defconfig >> >> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- >> >> SYNC include/config/auto.conf.cmd >> Checking missing-syscalls for N32 >> CALL scripts/checksyscalls.sh >> Checking missing-syscalls for O32 >> CALL scripts/checksyscalls.sh >> CALL scripts/checksyscalls.sh >> MODPOST Module.symvers >> ERROR: modpost: "__devm_regmap_init_mmio_clk" >> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 >> make: *** [Makefile:1978: modpost] Error 2 >> >> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >> --- >> drivers/gpu/drm/ingenic/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/ingenic/Kconfig >> b/drivers/gpu/drm/ingenic/Kconfig >> index a53f475d33df..7457c0b65034 100644 >> --- a/drivers/gpu/drm/ingenic/Kconfig >> +++ b/drivers/gpu/drm/ingenic/Kconfig >> @@ -5,6 +5,8 @@ config DRM_INGENIC >> depends on CMA >> depends on OF >> depends on COMMON_CLK >> + select REGMAP >> + select REGMAP_MMIO > nit: order alphabetically (move them after the DRM_* ones). Fixed, I already send a updated version[1]. [1] https://lore.kernel.org/dri-devel/20230607110650.569522-1-suijingfeng@loongson.cn/ > Cheers, > -Paul > >> select DRM_BRIDGE >> select DRM_PANEL_BRIDGE >> select DRM_KMS_HELPER
diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig index a53f475d33df..7457c0b65034 100644 --- a/drivers/gpu/drm/ingenic/Kconfig +++ b/drivers/gpu/drm/ingenic/Kconfig @@ -5,6 +5,8 @@ config DRM_INGENIC depends on CMA depends on OF depends on COMMON_CLK + select REGMAP + select REGMAP_MMIO select DRM_BRIDGE select DRM_PANEL_BRIDGE select DRM_KMS_HELPER