| Message ID | 20230529062511.52016-6-anshuman.khandual@arm.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1313462vqr;
Sun, 28 May 2023 23:33:13 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7RNeH71Wxpl6mbrZx9X8L7zkGPQQmkmaEXFm8a2XmWgmRTlarxmu7lzz5gQEf2UDBIuGnO
X-Received: by 2002:a17:90a:aa0b:b0:24b:a5b6:e866 with SMTP id
k11-20020a17090aaa0b00b0024ba5b6e866mr8995999pjq.24.1685341993517;
Sun, 28 May 2023 23:33:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685341993; cv=none;
d=google.com; s=arc-20160816;
b=eCJLir/k4cWkIOwlPuuc8Nz6ZZiWorus2FjjMqvOmVQYBZrt0apOmAZYofOi57QhLy
aYInDUyojfXStu64UE9zu8etSZnQ0kDRQYfRNvu2cBpX6YZ3Cnh4dfgtxwYdUYDbYYSO
zSr6pUsmLBfRT8gkh7hQgb/Pzp9DduTxJ76yJUK9XVhgJ8nGFF9GYG07hzgRTtpRIz2O
pOthpAFEuY5KuWaIZYXl2FMhlNiZOvW7lsiLOC0C+3QeC3JCfGCSIfBjFbGJUsvwO5yF
P6v5ppIXq4ZBtI4joj1vTRBLAIyU0SCWxOO0jq9ALiXW5SY6E5pEPJfrd7c57DVTv775
n9Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=SS8eFXdUUvA8OCPxf5Syhx2f4mz+ypgKZ9P0aUNsBxE=;
b=PPGdtCEsxte4+miHiKbCLQKzKgK5qUWGk53USkPp51QbT10JYX4RNcH30mLw1LfOlB
RLRqXRha6T0SFHmyVdHDGikbdcJBPcNEV9j4jfuYJ5C4xVI/j8eS9FKwsxKou0xhIq+L
DrFHR4JXsZeHy13LgaO8iwHPcIVzpsOM1xUyJlsoFY3ZqJ/0MMCaaKehDOJ+YzYhlTqT
0Ip11gP/JqInj8pSFYSQ1e7/FWzqavafBXMOu3ZYKEi7oxwag1xdj3pT8YFk/bRt+QLp
U2PORmQ23dK/l5VT7tUwojAcyNNGXByu0yF6FzFuz2u6U/9k03bQBt9p+Wk5gZ+5JgyC
OeMw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
bt1-20020a17090af00100b00250d10c6fe7si435545pjb.67.2023.05.28.23.32.58;
Sun, 28 May 2023 23:33:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231741AbjE2G2Y (ORCPT <rfc822;callmefire3@gmail.com>
+ 99 others); Mon, 29 May 2023 02:28:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54838 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231723AbjE2G15 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 29 May 2023 02:27:57 -0400
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0918F138;
Sun, 28 May 2023 23:27:26 -0700 (PDT)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 290EA153B;
Sun, 28 May 2023 23:26:46 -0700 (PDT)
Received: from a077893.blr.arm.com (a077893.blr.arm.com [10.162.40.17])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id
F1D9A3F6C4;
Sun, 28 May 2023 23:25:54 -0700 (PDT)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com
Cc: scclevenger@os.amperecomputing.com,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linaro.org>, devicetree@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V5 5/6] coresight: platform: acpi: Ignore the absence of graph
Date: Mon, 29 May 2023 11:55:10 +0530
Message-Id: <20230529062511.52016-6-anshuman.khandual@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230529062511.52016-1-anshuman.khandual@arm.com>
References: <20230529062511.52016-1-anshuman.khandual@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1767209166299770341?=
X-GMAIL-MSGID: =?utf-8?q?1767209166299770341?=
|
| Series |
coresight: etm4x: Migrate ACPI AMBA devices to platform driver
|
|
Commit Message
Anshuman Khandual
May 29, 2023, 6:25 a.m. UTC
From: Suzuki K Poulose <suzuki.poulose@arm.com> Some components may not have graph connections for describing the trace path. e.g., ETE, where it could directly use the per CPU TRBE. Ignore the absence of graph connections Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- drivers/hwtracing/coresight/coresight-platform.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Comments
HI Ansuman, On Mon, 29 May 2023 at 07:26, Anshuman Khandual <anshuman.khandual@arm.com> wrote: > > From: Suzuki K Poulose <suzuki.poulose@arm.com> > > Some components may not have graph connections for describing > the trace path. e.g., ETE, where it could directly use the per > CPU TRBE. Ignore the absence of graph connections > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > drivers/hwtracing/coresight/coresight-platform.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 475899714104..c4b4fbde8550 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev, > > pdata->nr_inport = pdata->nr_outport = 0; > graph = acpi_get_coresight_graph(adev); > + /* > + * There are no graph connections, which is fine for some components. > + * e.g., ETE > + */ > if (!graph) > - return -ENOENT; > + return 0; > Should we not determine if it is valid for a particular component not to have a graph connection? Prior to this patch an incorrectly configured ETMv4 - which must have a graph would return an error, after this it will fail silently Mike > nlinks = graph->package.elements[2].integer.value; > if (!nlinks) > -- > 2.25.1 >
On 07/06/2023 09:58, Mike Leach wrote: > HI Ansuman, > > On Mon, 29 May 2023 at 07:26, Anshuman Khandual > <anshuman.khandual@arm.com> wrote: >> >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> >> Some components may not have graph connections for describing >> the trace path. e.g., ETE, where it could directly use the per >> CPU TRBE. Ignore the absence of graph connections >> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> drivers/hwtracing/coresight/coresight-platform.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 475899714104..c4b4fbde8550 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev, >> >> pdata->nr_inport = pdata->nr_outport = 0; >> graph = acpi_get_coresight_graph(adev); >> + /* >> + * There are no graph connections, which is fine for some components. >> + * e.g., ETE >> + */ >> if (!graph) >> - return -ENOENT; >> + return 0; >> > > Should we not determine if it is valid for a particular component not > to have a graph connection? > Prior to this patch an incorrectly configured ETMv4 - which must have > a graph would return an error, after this it will fail silently I think it doesn't call for a failure. The ETM could still be probed but is not usable. We provide enough information via the sysfs, i.e., connection links, which should be sufficient for the user to detect this case. Also, this change is inline with what we do for ETMv4 with DT. Suzuki
diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c index 475899714104..c4b4fbde8550 100644 --- a/drivers/hwtracing/coresight/coresight-platform.c +++ b/drivers/hwtracing/coresight/coresight-platform.c @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev, pdata->nr_inport = pdata->nr_outport = 0; graph = acpi_get_coresight_graph(adev); + /* + * There are no graph connections, which is fine for some components. + * e.g., ETE + */ if (!graph) - return -ENOENT; + return 0; nlinks = graph->package.elements[2].integer.value; if (!nlinks)