Message ID | 20230604132858.6650-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2165556vqr; Sun, 4 Jun 2023 07:24:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xAlxO2Hm98u+2Ph91u9VqFQXUAaFXnQi70+Ku3+1MZS4ZRtgSlvVKYEgrhCzJZQJLSRtL X-Received: by 2002:a17:903:41c3:b0:1b1:76c2:296a with SMTP id u3-20020a17090341c300b001b176c2296amr2621316ple.60.1685888660732; Sun, 04 Jun 2023 07:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685888660; cv=none; d=google.com; s=arc-20160816; b=GPF7vayqoALD471Nah4fiwmis5ym0I5BmcMNJW8wkJhObGKKuYARHCUiF1ZC6Z2vNA jReseGj3orPskHF+vGi99iM7mKtl6x/iUo+RnTQc4aZU+HoHNw4uAYdpMVlgqIKt80jf yDSpcxS+2pMUXYKktrjg+4KNavkCt9tKM2qB+hSWnPpIC7x7Jsjzd/ad0A6mp4LAXCMg de9i3ywNNu26TPMtpor+o17SzJWtZ1jtTS+0meFuUMIKDPLQVjvO9TICG9kor9bSp4mR jLsCW7nX59tEg9p91HEyPmjdOHp/T39qP5xxDQRkRwnKjPdEb6258X4X0WnCrGqHInS+ CGWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1sE8g+lsaTSdQ6cXHpwZUpPbsNP9fA7F5PcYJUz9dXY=; b=XBQrFcOHy2dd9Ew/1lJoD2jZKsks7SIcdzYSce4h9lPwsOWCCu8NG/JU/Zx1e/VYw3 Smpf95rkL9Yk63xCwADmQ18F6ZUzJjMzZtB1vdqV7ThFr2Fqa5eZHBHSsoueIVuBVs6f aFuDtJty7ENkD1RRqE31UTDHhebQpbk7CB15YsZtEOAQ5PZMomyeBrfnAUZK5bmDc9DP Pst1NtjBmogvc5ZLtkK9M3WwMbTLbW3/hdTDpWaR8Ad2lv5cwxRoP8v5QStquhVTelPq yWJLCDjhbmAQmqHYjqjo7YVHlXCGNoxXQinsWs795PmZR4B2/h27Y4f+9BoMTuuWpYUn v8xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PRh0S6AE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020a170902ceca00b001afcd047456si4114956plg.636.2023.06.04.07.24.06; Sun, 04 Jun 2023 07:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PRh0S6AE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbjFDN26 (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Sun, 4 Jun 2023 09:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjFDN24 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 4 Jun 2023 09:28:56 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E197DCD; Sun, 4 Jun 2023 06:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685885335; x=1717421335; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Zovk716GPnoB1qLDIB+AYUE5g3/yq4Mdf6F3N/4N33c=; b=PRh0S6AE/E6ABuRnAQIUs8+bi2k6CYSkI9mqeLYYZt37/J5ctQiE91Z1 Q1udrAM7jhuBerQbY3KjKTWFED8NUJm2Is9OUIqHqikSKMTfNqCssd2Bd hj82X8rjoZ3oshdeAadqQ2+AHBfM3FrbIT4vHyqDsRKBRGIOG48ef/FTN juTfP3jqJ9dv7SGb/oWhPvNh52Q6luqE2zvV0XmmOWzeP8tkNpKrjiHTA xPiXWuqq/rdM2nVzTWmw7wcPKvWp2PBHmQ56wWnaoU5iQAFJtmD0d4W9U cav4htd73xo4+MTkHOf5elGbJM4vJvek7AGWmKadq+5WOkhV+vU0cj4t1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="356197738" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="356197738" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2023 06:28:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="955038532" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="955038532" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 04 Jun 2023 06:28:53 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2DE33204; Sun, 4 Jun 2023 16:28:59 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Subject: [PATCH net-next v1 1/1] mac_pton: Clean up the header inclusions Date: Sun, 4 Jun 2023 16:28:58 +0300 Message-Id: <20230604132858.6650-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767782388209841624?= X-GMAIL-MSGID: =?utf-8?q?1767782388209841624?= |
Series |
[net-next,v1,1/1] mac_pton: Clean up the header inclusions
|
|
Commit Message
Andy Shevchenko
June 4, 2023, 1:28 p.m. UTC
Since hex_to_bin() is provided by hex.h there is no need to require
kernel.h. Replace the latter by the former and add missing export.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/net_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote: > Since hex_to_bin() is provided by hex.h there is no need to require > kernel.h. Replace the latter by the former and add missing export.h. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Hi Andy, is there a tool that you used to verify this change?
On Tue, 2023-06-06 at 10:42 +0200, Simon Horman wrote: > On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote: > > Since hex_to_bin() is provided by hex.h there is no need to require > > kernel.h. Replace the latter by the former and add missing export.h. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Hi Andy, > > is there a tool that you used to verify this change? I guess build testing it should suffice ;) /P
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Sun, 4 Jun 2023 16:28:58 +0300 you wrote: > Since hex_to_bin() is provided by hex.h there is no need to require > kernel.h. Replace the latter by the former and add missing export.h. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > lib/net_utils.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next,v1,1/1] mac_pton: Clean up the header inclusions https://git.kernel.org/netdev/net-next/c/8d2b2281aea9 You are awesome, thank you!
On Tue, Jun 06, 2023 at 01:20:57PM +0200, Paolo Abeni wrote: > On Tue, 2023-06-06 at 10:42 +0200, Simon Horman wrote: > > On Sun, Jun 04, 2023 at 04:28:58PM +0300, Andy Shevchenko wrote: > > > Since hex_to_bin() is provided by hex.h there is no need to require > > > kernel.h. Replace the latter by the former and add missing export.h. ... > > is there a tool that you used to verify this change? > > I guess build testing it should suffice ;) Yes, it was my brain work with reading the code + compile test on x86.
diff --git a/lib/net_utils.c b/lib/net_utils.c index c17201df3d08..42bb0473fb22 100644 --- a/lib/net_utils.c +++ b/lib/net_utils.c @@ -2,7 +2,8 @@ #include <linux/string.h> #include <linux/if_ether.h> #include <linux/ctype.h> -#include <linux/kernel.h> +#include <linux/export.h> +#include <linux/hex.h> bool mac_pton(const char *s, u8 *mac) {