Message ID | 20230526044519.13441-1-rdunlap@infradead.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp237706vqr; Thu, 25 May 2023 22:16:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Av/ZOPivZNrzLElzirhw8X48qzKmRcAG7p+ApE/8dGRCIF82WMI5tGoCHG3aYO29u8Lns X-Received: by 2002:a05:6a20:441e:b0:10f:32ec:aa20 with SMTP id ce30-20020a056a20441e00b0010f32ecaa20mr855607pzb.32.1685078214498; Thu, 25 May 2023 22:16:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685078214; cv=none; d=google.com; s=arc-20160816; b=n3kfpuhWfJMNIYAuP/VaxQKNM2Yp3ncJ+0o+fV7WQYwBAL2Ze5jDcTGqQk4/WfB61I CVS2AVzgW/tT3T5ItLooPseDt7Bsut+lObZPgy7ILDhvhLf1hosF5OHmlleoW7wS6zQF R4x6xU0PnaqHawNcXAOdXxCqDGmqY2KpGMoGsuiou1jNxvyMEHnx8Xn3ZWB/KBDnKZhk m8vClEXmeAkn8knaTEDUPVf2GJWzjsX9USI6seEviosWUF7vTcNPCW4brgeyWSBQJ8C7 lgejH0DUpEcQk882LcbL+qii4vuymIJehi1xqeQF0wqoXIHCu1CGvLWTFF+b6M96wAqL KJLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mk1hz+aR0+S5nMP4NKFg1YnAMY5/a5jNMR1UmgjUkFA=; b=ccO9g2pCPRdYBTOoYeeJK2OmcxiULx0ohYcZ1pSCiguRUbhTK8MxCApFZ2BEEDgpwg G7Y09yNLRSVo9ERshqdZcCcKMAaINGvlnw65nUvbGlC0GR4E+IqgE7Dhuoh1C04I3RcW scUyV7fEA0n14Ki98XEC2wgtQEWEa6I/wsSVRmV8rqc1R5hNaE5d3ddY3FLkZiQfN4J5 9PP3sFvnctmuUfqDN0QsZAfojOpq0J5/xJdCL6Z7wVnfgIZoSavvemWHvshA0L4GeWft YVUEWBqI00v1smb5X6rLjBSP9BkzAmA8nGeGFLgyxHJYJC8pFQsbPceARaAqkh5LWBdx Da/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=u4EZZQge; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r76-20020a632b4f000000b00534839d1219si2864697pgr.138.2023.05.25.22.16.40; Thu, 25 May 2023 22:16:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=u4EZZQge; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236467AbjEZEpf (ORCPT <rfc822;zhanglyra.2023@gmail.com> + 99 others); Fri, 26 May 2023 00:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236166AbjEZEp0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 26 May 2023 00:45:26 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF9B119 for <linux-kernel@vger.kernel.org>; Thu, 25 May 2023 21:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=mk1hz+aR0+S5nMP4NKFg1YnAMY5/a5jNMR1UmgjUkFA=; b=u4EZZQgeKpbZjOBjlg0b/8jhey NTZsii8TCpgvrsYM2u30CSuUVl+O8HCftHnF+kfPi0AlXS2pP9jSvdtuSoFBewytIBtqJpx2oiDGF 7LWBx0iWdbtngjSaO7naPKp7DBlUfBvyH56+SJV8W2Ie4VB//t8g1URg1ZMKiBwdADc7MBjXb7GLY lOuyj91gtG3nRKw4mNu328PY7IeyO1fgpR9YvEyHilD6AAzF1wf5Sujvs8MEp0q7vizytfhNqhBey N8CWE8CY6WrLIoo0MGa1ojoBsXPeURBB+o5n4YKMWkW0lvm+v1bGBOvsT1qtKn3mVDYGLZeAlhO/R 08UpR0Xw==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q2PKL-0010aD-0T; Fri, 26 May 2023 04:45:21 +0000 From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, kernel test robot <lkp@intel.com>, Oded Gabbay <ogabbay@kernel.org>, dri-devel@lists.freedesktop.org, Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>, Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>, Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>, Krystian Pradzynski <krystian.pradzynski@linux.intel.com>, Jeffrey Hugo <quic_jhugo@quicinc.com>, Daniel Vetter <daniel.vetter@ffwll.ch> Subject: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR Date: Thu, 25 May 2023 21:45:19 -0700 Message-Id: <20230526044519.13441-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766932573604849757?= X-GMAIL-MSGID: =?utf-8?q?1766932573604849757?= |
Series |
accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
|
|
Commit Message
Randy Dunlap
May 26, 2023, 4:45 a.m. UTC
Drivers that use the gen_pool*() family of functions should
select GENERIC_ALLOCATOR to prevent build errors like these:
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
Cc: Oded Gabbay <ogabbay@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/accel/ivpu/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo': > include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init': > drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt': > include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner' > > Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/ > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com> > Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > --- > drivers/accel/ivpu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig > --- a/drivers/accel/ivpu/Kconfig > +++ b/drivers/accel/ivpu/Kconfig > @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU > depends on PCI && PCI_MSI > select FW_LOADER > select SHMEM > + select GENERIC_ALLOCATOR > help > Choose this option if you have a system that has an 14th generation Intel CPU > or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated
On 5/25/2023 10:45 PM, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo': > include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init': > drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt': > include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner' > > Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/ > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com> > Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote: > Drivers that use the gen_pool*() family of functions should > select GENERIC_ALLOCATOR to prevent build errors like these: > > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo': > include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': > include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init': > drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create' > ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt': > include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner' > > Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/ > Cc: Oded Gabbay <ogabbay@kernel.org> > Cc: dri-devel@lists.freedesktop.org > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com> > Cc: Krystian Pradzynski <krystian.pradzynski@linux.intel.com> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Applied to drm-misc-fixes Thanks Stanislaw
diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig --- a/drivers/accel/ivpu/Kconfig +++ b/drivers/accel/ivpu/Kconfig @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU depends on PCI && PCI_MSI select FW_LOADER select SHMEM + select GENERIC_ALLOCATOR help Choose this option if you have a system that has an 14th generation Intel CPU or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated