Message ID | 20230606102058.1010324-1-neelchakrabortykernelwork@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3296000vqr; Tue, 6 Jun 2023 03:43:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jEDcF6vJplMj0DtQalLPjJ0IHT4TNqs2eDpGtgn2zo++3OXRW2wq5+9EkjdvfSB1vaWLk X-Received: by 2002:a05:6a00:230b:b0:659:f4ed:42bc with SMTP id h11-20020a056a00230b00b00659f4ed42bcmr2266058pfh.4.1686048202637; Tue, 06 Jun 2023 03:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686048202; cv=none; d=google.com; s=arc-20160816; b=Xrd2TMqpDQVpHehQFlgIXUNyc12K+X3va+VYmwntMPklYUn8CNmu9RYieDikNZ5ifL 9YuPZDQZybGRbIhqBA7ftNRB1fiJUF7RYCHzUTD4XlxH+OwgGyy0rvSMes9Ji6BnSvkv kfhd/AinI0ToGWiTK799DRlxr/Pope13FlBcFnsuX3eoxrnSPsrWqW7cgbedMN2PVtas vJpH6pR+GpLs30taSG1nGea1LLfLDbcUuqkA/DSfytHQh1rwh8xnEgrClsAuXu6kwLjN rchYVp/xq2kmpvhc5vAuCA0/l/DBWJQ9D63sCXkSB910wRWpfcwn1BHu7bh7b53cBldo 14Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=86esAuV3rhpT10J6tH2DReVxyiryzcCN4UKCqr3CPfA=; b=LCdNATHSms7a41kwmXqdZpPAGjZCK33qU9S6jMLfyamsRMV/jS7hF+sSoQnVvZxfV2 gqetDyh86d3NV6BqlD6SB7YwbrGplSxXrR04BmUEUtwhhnF5gXp4/vH1FQleK7618rhd CmvwS8LXxDH72cXd8v38sMCEj/vWuO/C2JUOYurc88MLew57gBQIOj6KjNUQuHCF2H8t im0oM5wk2NCd9b47TCMBgN7fg8WO8zJGGeGj485EjxkSqdmqzxZNBu4piT52wqxszzTV sTlCoY/ZI3jxI4IZbfTI5hBP/NRNBPKFpSrpRG6Lytp+45LhOhpohL1IL6dMHVYlQPda eP+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=JOvJlRzm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020aa7984c000000b00643970acd01si6806090pfq.319.2023.06.06.03.43.10; Tue, 06 Jun 2023 03:43:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=JOvJlRzm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232450AbjFFKVd (ORCPT <rfc822;xxoosimple@gmail.com> + 99 others); Tue, 6 Jun 2023 06:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbjFFKVc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 6 Jun 2023 06:21:32 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73778E42; Tue, 6 Jun 2023 03:21:28 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-256d1b5f7c0so4413874a91.1; Tue, 06 Jun 2023 03:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686046888; x=1688638888; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=86esAuV3rhpT10J6tH2DReVxyiryzcCN4UKCqr3CPfA=; b=JOvJlRzmVD5S2lz08oqLtvPP7i7Srg3FQB7e8cTnnUWNNN68vLQrXxr0rt/15FrcEi SbBEQJdbTUh3QHU+C771cJwaxPanKsSuyymzWgOP4fTKZvJqHMoRYsvvQTvq+th4GaiF lZ36X1RxLZu7jf3BQ6R8VFkL7Nt1fqObp+ulm1+O58mJFfd3YLBbeJ9ezcD5h+AspliA VYmgGka4YRtBsakSMO5gLbgLy5vL77IPpTxgjoRzxPbi1Zrb+mlNvy96rKZTGzEKzZlV 1QzhvSAkwTECJeAolgKmd7xMrP2/2ufSWJB1ImXjPdL87d6yF7/CInXsudmvB09kWzTG YGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686046888; x=1688638888; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=86esAuV3rhpT10J6tH2DReVxyiryzcCN4UKCqr3CPfA=; b=EGtO0V36pMBlYEGIxd+wg4ohsNP2EGYAkRhBs2xczzeuigWwD3YXRxkPVU/mGgBzXn SuekjD+1b5Ql9+IMpl9zFgA9gS/KIHV2iJ1ACEVncx6eMTDsCdoXQNx2RrQuf8RS+Ges JwmhOuFds17EIA8WTTdZJLx4DBWKuNljHQ7EiZ7rRmlGjQ5WhdS+DUIxmzLwwHjzmxk8 svzTIJJdFd4ZnyV7z5LEcG5mkWI9WyvGtXaORB1TbHBxyXdleR02cBMj5UsILLxeLUUm pKq7yUw6dfrz/tbyAZMpCyHEhHTupu466fgzK3z9oCjfq+QE8T9fdGV97QphV4t+Jo1h 00Bw== X-Gm-Message-State: AC+VfDwWn61XHzFMWTBBS4nzZz/hCfoyCWOB4y0sK5sjZsDZ0WiKr1pk 9W6jG0GgrKTN4hTPt+oS4Glprjm+KOD2gQ== X-Received: by 2002:a17:90a:5604:b0:256:3191:640f with SMTP id r4-20020a17090a560400b002563191640fmr11448526pjf.4.1686046887721; Tue, 06 Jun 2023 03:21:27 -0700 (PDT) Received: from devbox.. ([103.165.115.136]) by smtp.gmail.com with ESMTPSA id l30-20020a63571e000000b0053fb37fb626sm7067917pgb.43.2023.06.06.03.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 03:21:27 -0700 (PDT) From: Neel Chakraborty <neelchakrabortykernelwork@gmail.com> To: b-liu@ti.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Neel Chakraborty <neelchakrabortykernelwork@gmail.com> Subject: [PATCH] drivers: usb: musb: musb_gadget: Removed unneeded code Date: Tue, 6 Jun 2023 15:50:58 +0530 Message-Id: <20230606102058.1010324-1-neelchakrabortykernelwork@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767949679851121987?= X-GMAIL-MSGID: =?utf-8?q?1767949679851121987?= |
Series |
drivers: usb: musb: musb_gadget: Removed unneeded code
|
|
Commit Message
Neel Chakraborty
June 6, 2023, 10:20 a.m. UTC
Removed the static int musb_gadget_vbus_session function as it was
doing nothing.It has reduced 13 lines of code
Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
---
drivers/usb/musb/musb_gadget.c | 13 -------------
1 file changed, 13 deletions(-)
Comments
On Tue, Jun 06, 2023 at 03:50:58PM +0530, Neel Chakraborty wrote: > Removed the static int musb_gadget_vbus_session function as it was > doing nothing.It has reduced 13 lines of code > > Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com> > --- > drivers/usb/musb/musb_gadget.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c > index 31c44325e828..3cb7fc4c84ed 100644 > --- a/drivers/usb/musb/musb_gadget.c > +++ b/drivers/usb/musb/musb_gadget.c > @@ -1612,19 +1612,6 @@ static void musb_pullup(struct musb *musb, int is_on) > musb_writeb(musb->mregs, MUSB_POWER, power); > } > > -#if 0 > -static int musb_gadget_vbus_session(struct usb_gadget *gadget, int is_active) > -{ > - musb_dbg(musb, "<= %s =>\n", __func__); > - > - /* > - * FIXME iff driver's softconnect flag is set (as it is during probe, > - * though that can clear it), just musb_pullup(). > - */ > - > - return -EINVAL; > -} > -#endif > > static int musb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA) > { > -- > 2.40.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 31c44325e828..3cb7fc4c84ed 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -1612,19 +1612,6 @@ static void musb_pullup(struct musb *musb, int is_on) musb_writeb(musb->mregs, MUSB_POWER, power); } -#if 0 -static int musb_gadget_vbus_session(struct usb_gadget *gadget, int is_active) -{ - musb_dbg(musb, "<= %s =>\n", __func__); - - /* - * FIXME iff driver's softconnect flag is set (as it is during probe, - * though that can clear it), just musb_pullup(). - */ - - return -EINVAL; -} -#endif static int musb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA) {