Message ID | 20230528140938.34034-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp982787vqr; Sun, 28 May 2023 07:23:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4uQoMgjbMULIES57kgrFcM2u9CNJcVoOuowsrlw207TAPtByevVsZ56TGUOVyOgp9KuuYE X-Received: by 2002:a17:902:6b0c:b0:1af:c57d:1c7b with SMTP id o12-20020a1709026b0c00b001afc57d1c7bmr7838676plk.32.1685283827629; Sun, 28 May 2023 07:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685283827; cv=none; d=google.com; s=arc-20160816; b=Dn2bUC9aS0TBdQsCBdU8icTUONl3R2WrxDod07ZwMqTf01WRfs6O6M7ScamWdaDd5x UAnxqZG6qOhTjpVI73SE5QUkk+e9pWdIXqxppNZTqeYbtK4mugdRO8x9l+ypoRGwf+lb pO1ZIWShYNMrmwWKKliMsIfJ8+/s9s46rHhWi6YgE+3b81Bk+FG+wCsW7kyys1eso9Lb Ng+LHOVe3xMzGHqomT2p86RB97Y3d2wMJJruobRtG6m1J6Z0/Pq/gBx5QOwMvh3+BHvh IMlzJjvfxrYgA7LF8WHe4OxGUYiT3OpJRgr4uBZUCu4iUAWsd0FxWseI+5LZAt9OWZEN FbSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TmZyQIAWZ9qzK/SwUPPV/kjLjriPcmuglVKy9sETOUg=; b=AUPwTEj9l0z3F21sHg/JoUq2gxyYs7VnwQTk6XmQDnYBKBcqxrGVEBh+7075rVN868 CJdl8t4OCgenFxteaFHP+J18awYVRQb2gv+TjkHQwUaYrxTxPF4l8QGDzyGTfbFdN1m2 2Ko4bIe34dNRe/o0GlJeNZKuHY0+tA6iqrNJ6IVtgSwwyoBL38iMqx1Ks4gcKP1mqbIK BZpf5NFdfQgOu+qqi67e86QNFITcm3RV8O26aF9jYecIDS7JVvTqcB5e3GWd79fgwfGD 6kUHP9MAyxcDg2PAnpBWy5deKXlAUVECva5ZGaJvNHM0VrTPDOel6Tpt7+QAAgA6dG3o KT3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Sr+lEvtQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w18-20020a170902e89200b001ae4a291a2esi5624691plg.267.2023.05.28.07.23.34; Sun, 28 May 2023 07:23:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Sr+lEvtQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbjE1OJm (ORCPT <rfc822;syz17693488234@gmail.com> + 99 others); Sun, 28 May 2023 10:09:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjE1OJl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 28 May 2023 10:09:41 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33926BC; Sun, 28 May 2023 07:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685282980; x=1716818980; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cIR2fr2WmJ//GgKu/Pqss/i9kXIikU40iGweAC9yfuQ=; b=Sr+lEvtQqyQKDaSj0IsRTxppFFSZ+IsNi2g1H6FtOPcjX8dS1B142GMh feNBGvL8bmAjhLHUhGdAYHl6IOS4sUjBByJ3D2E8Ponyf174joM0Avcl9 3YdVLKK/yau2LVVcwyCZggutst+QPs3af8/GPAvAVvE+uIgHEqdNAJmA8 FzI+j01avGV+ohN5fByiclcUNJdMfTWcVHOO85hIcmUubAmvvu7rKzQvZ WNkIW4QCF+1HcLoesUw8GE/c+rOWE/n9JFijLQSbU+KY6u4ldq8m4pLF/ 3LMGhcXte+gVb4ByD7SBL/iWGjxDCdYu/Ax1D+B4UreGThijlDF0TvD/z w==; X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="357766867" X-IronPort-AV: E=Sophos;i="6.00,198,1681196400"; d="scan'208";a="357766867" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2023 07:09:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="699947158" X-IronPort-AV: E=Sophos;i="6.00,198,1681196400"; d="scan'208";a="699947158" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 28 May 2023 07:09:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6578924F; Sun, 28 May 2023 17:09:41 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Stefan Schmidt <stefan@datenfreihafen.org>, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Aring <alex.aring@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call Date: Sun, 28 May 2023 17:09:38 +0300 Message-Id: <20230528140938.34034-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767148174822851561?= X-GMAIL-MSGID: =?utf-8?q?1767148174822851561?= |
Series |
[net-next,v1,1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
|
|
Commit Message
Andy Shevchenko
May 28, 2023, 2:09 p.m. UTC
There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
GPIO sysfs is deprecated. That said, simply drop the stray call.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ieee802154/ca8210.c | 1 -
1 file changed, 1 deletion(-)
Comments
Hi Andy, andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38 +0300: > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > GPIO sysfs is deprecated. That said, simply drop the stray call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Any reason not to consider a backport into stable kernels? Cc: stable + Fixes would certainly be welcome in this case? > --- > drivers/net/ieee802154/ca8210.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > index a2d242034220..f9b10e84de06 100644 > --- a/drivers/net/ieee802154/ca8210.c > +++ b/drivers/net/ieee802154/ca8210.c > @@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi) > ); > if (ret) { > dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); > - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); > gpio_free(pdata->gpio_irq); > } > Thanks, Miquèl
On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > GPIO sysfs is deprecated. That said, simply drop the stray call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On Mon, May 29, 2023 at 10:12:13AM +0200, Miquel Raynal wrote: > andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38 > +0300: > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Any reason not to consider a backport into stable kernels? > Cc: stable + Fixes would certainly be welcome in this case? I don't think it's justified for stable. It doesn't fix any existing regression as far as I understand.
On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote: > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Simon Horman <simon.horman@corigine.com> Thank you! Can this be applied now?
Hi, On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote: > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > Thank you! > Can this be applied now? ping, Miquel? :) - Alex
aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400: > Hi, > > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote: > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > > > Thank you! > > Can this be applied now? > > ping, Miquel? :) I already applied it locally, but I am trying to fix my "thanks for patch" routine to not tell you it was applied on the mtd tree :-p Cheers, Miquèl
Hi Miquel, On Tue, Jun 6, 2023 at 5:47 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400: > > > Hi, > > > > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote: > > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > > > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > > > > > Thank you! > > > Can this be applied now? > > > > ping, Miquel? :) > > I already applied it locally, but I am trying to fix my "thanks for > patch" routine to not tell you it was applied on the mtd tree :-p okay no problem. Fully understandable as we have a new workflow mechanism for 802.15.4. Thanks. :) - Alex
On Tue, Jun 06, 2023 at 11:47:43AM +0200, Miquel Raynal wrote: > aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400: > > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote: > > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote: > > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > > > > > GPIO sysfs is deprecated. That said, simply drop the stray call. > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > > > > > > Thank you! > > > Can this be applied now? > > > > ping, Miquel? :) > > I already applied it locally, but I am trying to fix my "thanks for > patch" routine to not tell you it was applied on the mtd tree :-p Good to know and thank you!
On Sun, 2023-05-28 at 14:09:38 UTC, Andy Shevchenko wrote: > There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > GPIO sysfs is deprecated. That said, simply drop the stray call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Simon Horman <simon.horman@corigine.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging, thanks. Miquel
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index a2d242034220..f9b10e84de06 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi) ); if (ret) { dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); gpio_free(pdata->gpio_irq); }