Message ID | 5a8be692-5779-1b9a-e387-073da84fbebe@linux.vnet.ibm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2490297vqr; Sun, 4 Jun 2023 23:42:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZPCTOQGjBxStT9QLdB5RGpNcaRTROvx592WdvNcjwO44tx83GcpBjGKrvlOg4L5k5ghk5 X-Received: by 2002:a17:907:72c3:b0:971:5a79:29ff with SMTP id du3-20020a17090772c300b009715a7929ffmr5422801ejc.48.1685947354491; Sun, 04 Jun 2023 23:42:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685947354; cv=none; d=google.com; s=arc-20160816; b=RpaCqEP4c/8RYGVLOj/7JDLCZBNceajAXYJEzV69W4Xb3hHw0YKMoe0n+4CWx32Zw2 TyQaVkMPfMn0F4TxtoTrQRH/08q8S988h4QVmfLDWInGm3nR7dxajNxwNb54s1ie/Wi1 jApuf9P3UqaKimj6NOlz9osVKrkjrCyaT4KqjTr81w0slqRA5sztOr/rsA2tI16Lkngd 4VgjsyyLnTQfuvVp/MBagexhxFt2hD5NypQIjrbUsw6ScUbuhXfzcP3B33AbS+4SGPVq tYAf7ElRj6d/pDW12Qx0O5Qb98VMEufgiFugoh7FGrxfvgQl0noHdOe7izWaNezjwA0O AKww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:to:subject:content-language:user-agent :mime-version:date:message-id:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=vX66RcjF9MJlp3JWgkXTjBoNv+Sd+ko6nnAGGkIcv/s=; b=UjfxS5otrs9nZMNxv6cdBVQ0klmRxiOkClLlFlfy7K316BGUm9SuVIiGUZcSmr9985 3oQBhHtMvrsyRbqk+uvouBYyI2ly+p9q6NXAIDFrnJkm8R6Iu/E+YjsESQ4ffu7j7XbK N7fGyStw08I6Jzv/M1gei6q8dZB1W6WZVfm/z2iSThdr1o38TvyFVfj99O8QSwCzQ1+J yajg7GBiIR976HECTAuT1+m4YUyaIyDMP4OGcWCFzHn2ArfHFAFL8D9asRw7gFrxy+Zw K8qNz+iRgkxBFijW+mnlqGYouXjiqtuuPO/zrYMkcLwjACzwh0BT1+qzhnUQzwBWQFgi zhpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YJy1rLt6; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org ([8.43.85.97]) by mx.google.com with ESMTPS id he39-20020a1709073da700b009746322ef2bsi5168461ejc.645.2023.06.04.23.42.34 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 23:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YJy1rLt6; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 698133856606 for <ouuuleilei@gmail.com>; Mon, 5 Jun 2023 06:42:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 698133856606 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685947353; bh=vX66RcjF9MJlp3JWgkXTjBoNv+Sd+ko6nnAGGkIcv/s=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YJy1rLt6t8BJvlO5F6xgLCXUWMF+23rSw7yzsagSiKApVM2yjNzkSkENViQt1VHkZ Z+FTycSBrTALNtMAv1SAVdY6aZ+rjs00G7mlgqhmmTcRUi++h/cJ/nPA3cUvJZ4NEW VCYSaQlFuDPzEOorlbba9nrTsGS1ORhKr1pVGjp4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3819A3857707 for <gcc-patches@gcc.gnu.org>; Mon, 5 Jun 2023 06:41:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3819A3857707 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3556PBlB020235; Mon, 5 Jun 2023 06:41:48 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r1adwrafa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jun 2023 06:41:47 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35520KJk012371; Mon, 5 Jun 2023 06:41:46 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3qyxen8pna-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jun 2023 06:41:46 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3556fjt91049222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jun 2023 06:41:45 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5319558054; Mon, 5 Jun 2023 06:41:45 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 27B0558052; Mon, 5 Jun 2023 06:41:44 +0000 (GMT) Received: from [9.109.208.172] (unknown [9.109.208.172]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jun 2023 06:41:43 +0000 (GMT) Message-ID: <5a8be692-5779-1b9a-e387-073da84fbebe@linux.vnet.ibm.com> Date: Mon, 5 Jun 2023 12:11:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US Subject: [PATCH] rs6000: Remove duplicate expression [PR106907] To: gcc-patches@gcc.gnu.org, bergner@linux.ibm.com, segher@kernel.crashing.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: NL9YwXHsJ5Vj6VOYr-_iFjo4_bFzEItM X-Proofpoint-ORIG-GUID: NL9YwXHsJ5Vj6VOYr-_iFjo4_bFzEItM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-03_08,2023-06-02_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 clxscore=1011 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306050058 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: P Jeevitha via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: P Jeevitha <jeevitha@linux.vnet.ibm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767843932961010001?= X-GMAIL-MSGID: =?utf-8?q?1767843932961010001?= |
Series |
rs6000: Remove duplicate expression [PR106907]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
jeevitha
June 5, 2023, 6:41 a.m. UTC
PR106907 has few warnings spotted from cppcheck. In that addressing duplicate expression issue here. Here the same expression is used twice in logical AND(&&) operation which result in same result so removing that. 2023-06-05 Jeevitha Palanisamy <jeevitha@linux.ibm.com> gcc/ PR target/106907 * config/rs6000/rs6000.cc (vec_const_128bit_to_bytes): Remove duplicate expression.
Comments
Hi! On Mon, Jun 05, 2023 at 12:11:42PM +0530, P Jeevitha wrote: > PR106907 has few warnings spotted from cppcheck. In that addressing duplicate > expression issue here. Here the same expression is used twice in logical > AND(&&) operation which result in same result so removing that. > > 2023-06-05 Jeevitha Palanisamy <jeevitha@linux.ibm.com> > > gcc/ > PR target/106907 > * config/rs6000/rs6000.cc (vec_const_128bit_to_bytes): Remove > duplicate expression. > > > diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc > index 42f49e4a56b..d197c3f3289 100644 > --- a/gcc/config/rs6000/rs6000.cc > +++ b/gcc/config/rs6000/rs6000.cc > @@ -28784,7 +28784,6 @@ vec_const_128bit_to_bytes (rtx op, > > info->all_words_same > = (info->words[0] == info->words[1] > - && info->words[0] == info->words[1] > && info->words[0] == info->words[2] > && info->words[0] == info->words[3]); Thanks! Okay for trunk. Also okay for all backports, no need to wait if unexpected problems in trunk show up. But still, backport to 13 first, then 12, then 11, only stop when it stops applying (or there are no open release branches left) :-) Segher
Thanks for reviewing Segher. Will work on backports as well :). Jeevitha
diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index 42f49e4a56b..d197c3f3289 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -28784,7 +28784,6 @@ vec_const_128bit_to_bytes (rtx op, info->all_words_same = (info->words[0] == info->words[1] - && info->words[0] == info->words[1] && info->words[0] == info->words[2] && info->words[0] == info->words[3]);