| Message ID | 20230602133714.260556-1-raymondhackley@protonmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1046794vqr;
Fri, 2 Jun 2023 07:00:00 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ4b+kd0ozDp2N37Q+Jm3He03M/glyVHNOOcWuRCeooU3GZhH1MYOlDZXxvdKoGsWYUO2Iy7
X-Received: by 2002:a05:6a21:3884:b0:10e:d3a0:cddf with SMTP id
yj4-20020a056a21388400b0010ed3a0cddfmr10357335pzb.12.1685714399703;
Fri, 02 Jun 2023 06:59:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685714399; cv=none;
d=google.com; s=arc-20160816;
b=SDMGt5zvusNnwdlERntxfeYorLAxGkMs/jUGbIy7Q9rC/OqBBj5CSaBA8bwL/fsdpe
3zNyj7ZS77kpdi4NfyTR8ypv0dRIGqDSIxvt0tin5+mm+9s5tV5jYQTgg5WQ9akWyTEz
QrkWjc9GKfbcjvMYNId4s1RKovzmNgUOmnzsJLbw1uZGWCD4L8txLazEHujM/2zI9AVt
UEagBYBCVSDkBOWQgFfYVSsGoY5gFVYPLU2IYMyEKjWrnY3KJkt/WX7zGN2LHkicBeE6
imq8V5UWkgoB2M+nDqQI1Q27mcf1ik/cRFye6vq4dE9ebIWYp1UNb01GSyvPu1Ioi0w/
nBZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:feedback-id:references:in-reply-to:message-id:subject:cc:from:to
:dkim-signature:date;
bh=bsHSAN20PI+leXRVPAKhT58R/jP9fMKdBTvAX0E8FqU=;
b=ciHJrHTbQ2qvhyi4fgYrlu/PGF6gD8W7HPaw+5WlhQ9ehE0/7+KQDBkpagT5GSePL/
IONlT9eEn5sD4agFy9rFutXAGC6Xt+YZ7W8xISPIyhQsd9w2i50ERj2ls922/I5+epPl
7MDHkmqv26DT0u64qfztQTOYIHwQqBGzPE1rkbeh2Cp923imTDoQhNxbqq9Fnne33KeE
4BtJelpY/uetPgDT3E3jJ+zNl0ZoGHpIh/Vh0BH8lE0SKS2Rs19+6OZSshqDEMJuxOXy
4zbCLCNOCIfZlrkROrLkobpUT9h7iox/JqZHYo37fPtdKJIsdPog/V0T8A9OsMXuN8rn
mU5g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@protonmail.com header.s=protonmail3
header.b=DNccUdTJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=protonmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
u72-20020a63794b000000b0053f24deef11si1041623pgc.318.2023.06.02.06.59.45;
Fri, 02 Jun 2023 06:59:59 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@protonmail.com header.s=protonmail3
header.b=DNccUdTJ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=protonmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235760AbjFBNi0 (ORCPT <rfc822;limurcpp@gmail.com> + 99 others);
Fri, 2 Jun 2023 09:38:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46234 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235043AbjFBNiY (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 2 Jun 2023 09:38:24 -0400
Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com
[51.77.79.158])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9707C136;
Fri, 2 Jun 2023 06:38:23 -0700 (PDT)
Date: Fri, 02 Jun 2023 13:38:08 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1685713100; x=1685972300;
bh=bsHSAN20PI+leXRVPAKhT58R/jP9fMKdBTvAX0E8FqU=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector;
b=DNccUdTJebMvcEBYi5E1OBB0768TRLbkYqrJUHLtZ9tns+jgLFGq9evDSFUyLzmqG
G7BCNMchvygYVc1pkDGuBl+ipJwYaaPjpl28ZtqxcS4CyayG2mC1EJ8mh6Y468dH2D
27GMl3y45RL4JN9pHalBVka8l2cV4d6vCsdOdlJ35CfKpGVN7yvhKT8DVBPPmb8pWu
aBfcUhFki+oRA3xJYAybc9EJSqNLnZEbBW+wVdXiYFD60G1Xi7Jzwh6w0MF3+Xx/72
Dotx5FX+ybQXEEv6yK+c3JgMjub153jQBu5WzZ4YRBmiB79mwhe4Tbrniw3mzmGaoV
TYJ/dDlbXVAAA==
To: open list <linux-kernel@vger.kernel.org>
From: Raymond Hackley <raymondhackley@protonmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
"open list : LED SUBSYSTEM" <linux-leds@vger.kernel.org>,
"open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, ~postmarketos/upstreaming@lists.sr.ht
Subject: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document
richtek,rt5033 compatible
Message-ID: <20230602133714.260556-1-raymondhackley@protonmail.com>
In-Reply-To: <20230602133533.260502-1-raymondhackley@protonmail.com>
References: <20230602133533.260502-1-raymondhackley@protonmail.com>
Feedback-ID: 49437091:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1767599662188471733?=
X-GMAIL-MSGID: =?utf-8?q?1767599662188471733?=
|
| Series |
leds: sgm3140: Add richtek,rt5033-led compatible
|
|
Commit Message
Raymond Hackley
June 2, 2023, 1:38 p.m. UTC
Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
camera flash LEDs.
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On 02/06/2023 15:38, Raymond Hackley wrote: > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > camera flash LEDs. What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible. Best regards, Krzysztof
I've not seen this because Protonmail has encoded your mail. On Fri, 02 Jun 2023, Raymond Hackley wrote: > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > camera flash LEDs. > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> > --- > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > index 4d2ffe5fcfc7..37d2a93780ab 100644 > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > @@ -20,6 +20,7 @@ properties: > compatible: > enum: > - ocs,ocp8110 > + - richtek,rt5033-led > - sgmicro,sgm3140 > > enable-gpios: > -- > 2.30.2 > >
Hi Krzysztof, On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 02/06/2023 15:38, Raymond Hackley wrote: > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > > camera flash LEDs. > > > What are the similarities? Same register interface? Same pins? It's not > obvious and your commit should clear explain this. It will be also > justification why you did not make devices compatible. > There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set. Regards, Raymond
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml index 4d2ffe5fcfc7..37d2a93780ab 100644 --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml @@ -20,6 +20,7 @@ properties: compatible: enum: - ocs,ocp8110 + - richtek,rt5033-led - sgmicro,sgm3140 enable-gpios: