Message ID | 20230603072116.1101690-1-linmiaohe@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1519296vqr; Sat, 3 Jun 2023 00:42:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5JCEQgxK92G0t9BwBBBR/ZFHmfWQfTL7sUnV5SVG3e6zmKLG07grsd0/kcrWeubEYr/ine X-Received: by 2002:a05:6a00:1821:b0:655:ebb0:196a with SMTP id y33-20020a056a00182100b00655ebb0196amr252436pfa.25.1685778164272; Sat, 03 Jun 2023 00:42:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685778164; cv=none; d=google.com; s=arc-20160816; b=qluYqbpGfiCrTSgrcHIdQw6dLiRIp4tKyRQfcmnHK7adZG2gIzeodKW4z4c7NKOjxU Vslwvm29JC20hF8MdmU99xT6jjBmFnFGou8VuUxtcu4k/UFIU6C9mPbN0YkSKhGwF2qj zq46mcb10aPnkeayDE4F54Xv9JbOfFfMSeqEEZWuFa7K7IPdjEYry+ieEamoBJhfwKGH VM8hY9n4A0qfoPP6uXIMlS/np4z5CO/sK31qYH9a3It02K2RXvmjwUD4UVi+xw9wyblj 3thK3W/GqckEVkNkQ+jSBpvV6mSd41QGgDLved/rL4qjbbUT39HFjV5M205q1Zw6zVEs O/ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=yOC2rJPp0Z6lhVGnaFpklYzzQjIHB5RDQokyXq361Uw=; b=ny/K17MCIXVGV4c1nU7KvTzKpKyoy1iBcQDsNwmi3zihHrA/cW7lqZwKmzWOuby2dt 9Mtxze+rUNGMDhlc/HoBIDDsfFP/AfDjHrhee7KKSO6SJUP5Sk8ovvZB820a1MmISKsS Ob/MjfKvp14a/HJFpBZ7aKFoP3Ovh9/1ndltVfkBL8RIr2787Wf8YN0tNCe+xnP7H6aR 8PSU8dH0EGNHLPUr65dfhytsbc+c25H8hWsH9cU0n/ppxFmY4ne6xqWEQ/TWwlcbNSjw KyEqbkdmbFHYjV/lWcatfZPYBjHWAH0y+xmxiQxXajpABNa4p5R7HSqlOgbMLnvfrqIU FG4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p64-20020a622943000000b006434d66f94dsi2004817pfp.31.2023.06.03.00.42.32; Sat, 03 Jun 2023 00:42:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbjFCHVa (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Sat, 3 Jun 2023 03:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjFCHV3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 3 Jun 2023 03:21:29 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3041180; Sat, 3 Jun 2023 00:21:28 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QYB7Y07PXztQbQ; Sat, 3 Jun 2023 15:19:05 +0800 (CST) Received: from huawei.com (10.175.104.170) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 3 Jun 2023 15:21:22 +0800 From: Miaohe Lin <linmiaohe@huawei.com> To: <hannes@cmpxchg.org>, <mhocko@kernel.org>, <roman.gushchin@linux.dev>, <shakeelb@google.com>, <akpm@linux-foundation.org> CC: <muchun.song@linux.dev>, <cgroups@vger.kernel.org>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com> Subject: [PATCH] memcg: use helper macro FLUSH_TIME Date: Sat, 3 Jun 2023 15:21:16 +0800 Message-ID: <20230603072116.1101690-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.170] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767666524666836319?= X-GMAIL-MSGID: =?utf-8?q?1767666524666836319?= |
Series |
memcg: use helper macro FLUSH_TIME
|
|
Commit Message
Miaohe Lin
June 3, 2023, 7:21 a.m. UTC
Use helper macro FLUSH_TIME to indicate the flush time to improve the
readability a bit. No functional change intended.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Jun 3, 2023 at 12:21 AM Miaohe Lin <linmiaohe@huawei.com> wrote: > > Use helper macro FLUSH_TIME to indicate the flush time to improve the > readability a bit. No functional change intended. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Shakeel Butt <shakeelb@google.com>
> On Jun 3, 2023, at 15:21, Miaohe Lin <linmiaohe@huawei.com> wrote: > > Use helper macro FLUSH_TIME to indicate the flush time to improve the > readability a bit. No functional change intended. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks
On 03.06.23 09:21, Miaohe Lin wrote: > Use helper macro FLUSH_TIME to indicate the flush time to improve the > readability a bit. No functional change intended. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d8569594239c..f204c9f2e69c 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css) > > if (unlikely(mem_cgroup_is_root(memcg))) > queue_delayed_work(system_unbound_wq, &stats_flush_dwork, > - 2UL*HZ); > + FLUSH_TIME); > lru_gen_online_memcg(memcg); > return 0; > offline_kmem: Reviewed-by: David Hildenbrand <david@redhat.com>
On Sat, Jun 03, 2023 at 03:21:16PM +0800, Miaohe Lin wrote: > Use helper macro FLUSH_TIME to indicate the flush time to improve the > readability a bit. No functional change intended. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Roman Gushchin <roman.gushchin@linux.dev> Thanks!
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d8569594239c..f204c9f2e69c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css) if (unlikely(mem_cgroup_is_root(memcg))) queue_delayed_work(system_unbound_wq, &stats_flush_dwork, - 2UL*HZ); + FLUSH_TIME); lru_gen_online_memcg(memcg); return 0; offline_kmem: