Message ID | 20230602093333.19552-1-juzhe.zhong@rivai.ai |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp900894vqr; Fri, 2 Jun 2023 02:34:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5idWTTReaCEz8hoyrre2MFszhtzFKzkswMPpRrVH1Kz67pPmCSjP/KBz71B3FBGoG/mizb X-Received: by 2002:a17:907:7b91:b0:966:4bb3:df63 with SMTP id ne17-20020a1709077b9100b009664bb3df63mr11467981ejc.63.1685698461840; Fri, 02 Jun 2023 02:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685698461; cv=none; d=google.com; s=arc-20160816; b=LnyXHIi7CL6O/e8U146BrySgpTRcXzIw5+QM/5BoyqQIbFqzxd/B+8nbeID8sAQvvf dLPgqM0RjObtnapE11NC28AwTspD7N2+L3ISE2TcDNtkwWcve3647bqPLUyVeQXkxu7m fTOTK9GnC06OHVU72fu/txR2RO65zKicfh0KL9x3dro7jzb3BRL48izzJFm1ZRZjw+aa L9RBAI8gCGcQxgQZGmo+3yPg8+R9Ww8ZYQlAAuYEcxRVUGsmme0xnrN+mCbOP2NInID8 pni2cZEjtMOMGT144y8mz2sL6ZoLEolHEdM2z3XkzXiDyVm+N6S2RDGdacg+uV/L41za dbbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=/E1wduTfVBTDjCrHrrp3LnCPssY5M6J2YgFSpSt/Vyk=; b=bI+DwzA2xRJRf7CAImv+6KW0wq75zWdJq2Ej4QGR6eeDdDJ8jdLpE6EFFj0s3iby+v PlPopbVNYXPiYtXJtPblfob02IDc5GFq0dytiyRdbtYTPUfhxy30Yfkv7yRyjxCohC38 Mn9E2nBE3H8P65SgqO5iULBbf4qjhOV2cYD/hFZG/uprUwAJW3M8UBISc/Ck0pbmyaMp yMHfoZ64U5WcEY6PWcgOyM1O6HlWUvyoe6Zxu+QfRW/TTal93AeE3xE+6ucouq95UQHB +/qbxh/IoNGjkT2JyOG65oKvGSE6SNenNIG01BA52RG61x/HCNqvrF6e2WEkoehX3qt6 ywYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id qu18-20020a170907111200b009659a13250csi586294ejb.367.2023.06.02.02.34.21 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 02:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44702385624C for <ouuuleilei@gmail.com>; Fri, 2 Jun 2023 09:34:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by sourceware.org (Postfix) with ESMTPS id E114A3858C62 for <gcc-patches@gcc.gnu.org>; Fri, 2 Jun 2023 09:33:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E114A3858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp77t1685698418tig2dody Received: from server1.localdomain ( [58.60.1.22]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 02 Jun 2023 17:33:36 +0800 (CST) X-QQ-SSF: 00400000000000F0R000000A0000000 X-QQ-FEAT: hoArX50alxGAcMgUYEw2YGdfFG4JcCnEc0tWFZVpi0/0eb/BGAvk1PeGgXGIy bkwFkOqdZBHZ+lgwx+NTx0d5EgMI9qpj5olitRNyzQQt4nvichkxFmGbsHToc/+N1/GgWpv 6SKmwUW5roaUT9CA1+23RONxqPhVSgw3Cl31efbfFl6UPAns8M2eyQzwvSyXA+Jf6OTJ4cJ 564yq404i6hpRBXsCyo6eCD1zCc4fF8EdyG8AcE34AXYKzQNn1148pdd09NxjBiT3aU75Bg En6COa3k+bay591xndkBfxOXvEalI6u5ocgCgx8sky/NKZ0jNYFF52I6vTJ5ewGdZxpHt4T 2ycNEIcVNVrO2mUbmkqVN2WQfeJMG0CMu5TvTYFkqJAOqWHiy7GwKCS+2eIk5nvsWjB7J4N 8e6ZvJy/KfPVHLNBkQoHUw== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 7308471027114416576 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, schwab@linux-m68k.org, Juzhe-Zhong <juzhe.zhong@rivai.ai> Subject: [PATCH V2] RISC-V: Fix warning in predicated.md Date: Fri, 2 Jun 2023 17:33:33 +0800 Message-Id: <20230602093333.19552-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, MEDICAL_SUBJECT, MIME_CHARSET_FARAWAY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767558482832224019?= X-GMAIL-MSGID: =?utf-8?q?1767582950213466774?= |
Series |
[V2] RISC-V: Fix warning in predicated.md
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
juzhe.zhong@rivai.ai
June 2, 2023, 9:33 a.m. UTC
From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Notice there is warning in predicates.md:
../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mode_mask(rtx, machine_mode)’:
../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(match_test "INTVAL (op) == GET_MODE_MASK (HImode)
../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
|| INTVAL (op) == GET_MODE_MASK (SImode)"))))
gcc/ChangeLog:
* config/riscv/predicates.md: Change INTVAL into UINTVAL.
---
gcc/config/riscv/predicates.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 6/2/23 03:33, juzhe.zhong@rivai.ai wrote: > From: Juzhe-Zhong <juzhe.zhong@rivai.ai> > > Notice there is warning in predicates.md: > ../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mode_mask(rtx, machine_mode)’: > ../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] > (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > ../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] > || INTVAL (op) == GET_MODE_MASK (SImode)")))) > > gcc/ChangeLog: > > * config/riscv/predicates.md: Change INTVAL into UINTVAL. > > --- > gcc/config/riscv/predicates.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/predicates.md b/gcc/config/riscv/predicates.md > index d14b1ca30bb..04ca6ceabc7 100644 > --- a/gcc/config/riscv/predicates.md > +++ b/gcc/config/riscv/predicates.md > @@ -30,7 +30,7 @@ > (define_predicate "arith_operand_or_mode_mask" > (ior (match_operand 0 "arith_operand") > (and (match_code "const_int") > - (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > + (match_test "UINTVAL (op) == GET_MODE_MASK (HImode) > || UINTVAL (op) == GET_MODE_MASK (SImode)")))) OK. jeff
Committed, thanks Jeff. Pan -----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Jeff Law via Gcc-patches Sent: Saturday, June 3, 2023 4:57 AM To: juzhe.zhong@rivai.ai; gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com; kito.cheng@sifive.com; palmer@dabbelt.com; palmer@rivosinc.com; rdapp.gcc@gmail.com; schwab@linux-m68k.org Subject: Re: [PATCH V2] RISC-V: Fix warning in predicated.md On 6/2/23 03:33, juzhe.zhong@rivai.ai wrote: > From: Juzhe-Zhong <juzhe.zhong@rivai.ai> > > Notice there is warning in predicates.md: > ../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mode_mask(rtx, machine_mode)’: > ../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] > (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > ../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] > || INTVAL (op) == GET_MODE_MASK (SImode)")))) > > gcc/ChangeLog: > > * config/riscv/predicates.md: Change INTVAL into UINTVAL. > > --- > gcc/config/riscv/predicates.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/predicates.md > b/gcc/config/riscv/predicates.md index d14b1ca30bb..04ca6ceabc7 100644 > --- a/gcc/config/riscv/predicates.md > +++ b/gcc/config/riscv/predicates.md > @@ -30,7 +30,7 @@ > (define_predicate "arith_operand_or_mode_mask" > (ior (match_operand 0 "arith_operand") > (and (match_code "const_int") > - (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > + (match_test "UINTVAL (op) == GET_MODE_MASK (HImode) > || UINTVAL (op) == GET_MODE_MASK (SImode)")))) OK. jeff
diff --git a/gcc/config/riscv/predicates.md b/gcc/config/riscv/predicates.md index d14b1ca30bb..04ca6ceabc7 100644 --- a/gcc/config/riscv/predicates.md +++ b/gcc/config/riscv/predicates.md @@ -30,7 +30,7 @@ (define_predicate "arith_operand_or_mode_mask" (ior (match_operand 0 "arith_operand") (and (match_code "const_int") - (match_test "INTVAL (op) == GET_MODE_MASK (HImode) + (match_test "UINTVAL (op) == GET_MODE_MASK (HImode) || UINTVAL (op) == GET_MODE_MASK (SImode)")))) (define_predicate "lui_operand"