Message ID | 7cea42cd09540657875a210cd16421125497d690.1685696114.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp897477vqr; Fri, 2 Jun 2023 02:25:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7r2GkX3vqh340/Qgsm8jKQ5mbbxvihhEZtMMYJzopketbdg/mPTIjPJBj4Wxmjo1HiS70Y X-Received: by 2002:a05:6870:5155:b0:19a:25c2:3f0a with SMTP id z21-20020a056870515500b0019a25c23f0amr1353759oak.31.1685697957075; Fri, 02 Jun 2023 02:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685697957; cv=none; d=google.com; s=arc-20160816; b=MHuecT2h9s0cxdnmB1lneUQ8NSFXFSdB8jFjSbucbMt6kpwaPv3ppXJpsyF9ZtGt0Y q+0tzaYUU4f/rqK5HxCcOb3l3d9GtbokXY39fFdHwPOgUlCIqt8OfFZnmFl/B+0cKVRV w57J5a8YDj1I+xG59v6UAt9evakneAvGd2lvkM3so/32D2ftRSVx22aG+rpz7DXMG+So VjOnk+tr5YlkaKoAiC8EI2LJmaxpIB02X9WhHz7h3qdBBVIxI9nYjwBrO6LVPlQO+kBu gSmDT7sFex/380XHrxl1NDRUnp6VA6usPrcBGzMsN5qj7RwJoh0Ydn/ntNW/18hHWswD GZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4rYCWHMHLbwy7OoyqYFa0Pp5uDoqhOuA/QlIh79NQR4=; b=CyjbSi8OVEjpescS033BQbdAICeH7yRYI84Wvh6hmwsQTEWpYu2OWzRuvGrElJ/gVg B1CyT0BaowZ3AUs3gB6fXQpHWQpwJbAUnH3IpDlXPWWdaitRYPBi94JrF60rUX3GFCf2 CCrjfAJT2ZfQQstJ4d53xQ1ZY6GPfKvNNVpBgpaffia3QjKNoikXfs3PZZDGTIBnQCxp TKdFZ9MlakDSMisdezasrqY67v31iyPmqjHfMnSeFOe5sDier5JLrPLvb29F+t0UEs9x czI9lv1IkOxuJmh+NT8v6d7yrrbbAGHYykrbqC2UIGf5BMumtANHRt5Fd4v5f2VfD4pA FGWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a63b744000000b0051b13a071a8si690458pgt.575.2023.06.02.02.25.42; Fri, 02 Jun 2023 02:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234635AbjFBJNQ (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Fri, 2 Jun 2023 05:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235097AbjFBJMo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 2 Jun 2023 05:12:44 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00CAE1703 for <linux-kernel@vger.kernel.org>; Fri, 2 Jun 2023 02:11:47 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:158c:2ccf:1f70:e136]) by andre.telenet-ops.be with bizsmtp id 49Bg2A0061tRZS8019BgaW; Fri, 02 Jun 2023 11:11:46 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1q50ob-00BvaL-2W; Fri, 02 Jun 2023 11:11:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1q50ou-00ASIJ-6O; Fri, 02 Jun 2023 11:11:40 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Jonathan Corbet <corbet@lwn.net>, Jyri Sarha <jyri.sarha@iki.fi>, Tomi Valkeinen <tomba@kernel.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Biju Das <biju.das.jz@bp.renesas.com> Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 1/3] drm/todo: Add atomic modesetting references Date: Fri, 2 Jun 2023 11:11:34 +0200 Message-Id: <7cea42cd09540657875a210cd16421125497d690.1685696114.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1685696114.git.geert+renesas@glider.be> References: <cover.1685696114.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767582421337044145?= X-GMAIL-MSGID: =?utf-8?q?1767582421337044145?= |
Series |
drm: Atomic modesetting doc and comment improvements
|
|
Commit Message
Geert Uytterhoeven
June 2, 2023, 9:11 a.m. UTC
The section about converting existing KMS drivers to atomic modesetting
mentions the existence of a conversion guide, but does not reference it.
While the guide is old and rusty, it still contains useful information,
so add a link to it. Also link to the LWN.net articles that give an
overview about the atomic mode setting design.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/gpu/todo.rst | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
Comments
Geert Uytterhoeven <geert+renesas@glider.be> writes: Hello Geert, Thanks for your patch. > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still contains useful information, > so add a link to it. Also link to the LWN.net articles that give an > overview about the atomic mode setting design. > This is a great idea and agree that would be very useful to have these. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/gpu/todo.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > really want an atomic modeset interface, so this is all about the bright > future. > > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). Are any of the virtual drivers not yet ported to atomic? This sentence seems to be outdated and maybe you could remove it on a following patch? Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Geert, Thank you for the patch. On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still contains useful information, > so add a link to it. Also link to the LWN.net articles that give an > overview about the atomic mode setting design. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/gpu/todo.rst | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > really want an atomic modeset interface, so this is all about the bright > future. > > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). > +suitable). The "Atomic mode setting design overview" series [2][3] at s/ / / Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > +LWN.net can also be helpful. > > As part of this drivers also need to convert to universal plane (which means > exposing primary & cursor as proper plane objects). But that's much easier to > do by directly using the new atomic helper driver callbacks. > > + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html > + - [2] https://lwn.net/Articles/653071/ > + - [3] https://lwn.net/Articles/653466/ > + > Contact: Daniel Vetter, respective driver maintainers > > Level: Advanced
Hi Javier, On Fri, Jun 2, 2023 at 12:39 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > The section about converting existing KMS drivers to atomic modesetting > > mentions the existence of a conversion guide, but does not reference it. > > While the guide is old and rusty, it still contains useful information, > > so add a link to it. Also link to the LWN.net articles that give an > > overview about the atomic mode setting design. > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android > > really want an atomic modeset interface, so this is all about the bright > > future. > > > > -There is a conversion guide for atomic and all you need is a GPU for a > > +There is a conversion guide for atomic[1] and all you need is a GPU for a > > non-converted driver (again virtual HW drivers for KVM are still all > > -suitable). > > Are any of the virtual drivers not yet ported to atomic? This sentence > seems to be outdated and maybe you could remove it on a following patch? Good question. I'm not sure which driver(s) this refers to. drivers/gpu/drm/vkms/ was introduced much later, and always had DRIVER_ATOMIC. Perhaps just the boochs driver, which was converted? > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks! Gr{oetje,eeting}s, Geert
On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suitable). > +suitable). The "Atomic mode setting design overview" series [2][3] at > +LWN.net can also be helpful. > > As part of this drivers also need to convert to universal plane (which means > exposing primary & cursor as proper plane objects). But that's much easier to > do by directly using the new atomic helper driver callbacks. > > + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html > + - [2] https://lwn.net/Articles/653071/ > + - [3] https://lwn.net/Articles/653466/ > + Looks like footnotes better serve these links above: ---- >8 ---- diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 51eb67f5268c5e..6ea92f48a2e21c 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,18 +49,18 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic[1] and all you need is a GPU for a +There is a conversion guide for atomic [1]_ and all you need is a GPU for a non-converted driver (again virtual HW drivers for KVM are still all -suitable). The "Atomic mode setting design overview" series [2][3] at +suitable). The "Atomic mode setting design overview" series [2]_ [3]_ at LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. - - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html - - [2] https://lwn.net/Articles/653071/ - - [3] https://lwn.net/Articles/653466/ + .. [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + .. [2] https://lwn.net/Articles/653071/ + .. [3] https://lwn.net/Articles/653466/ Contact: Daniel Vetter, respective driver maintainers Thanks.
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 68bdafa0284f55f6..51eb67f5268c5ec1 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,14 +49,19 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic and all you need is a GPU for a +There is a conversion guide for atomic[1] and all you need is a GPU for a non-converted driver (again virtual HW drivers for KVM are still all -suitable). +suitable). The "Atomic mode setting design overview" series [2][3] at +LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. + - [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + - [2] https://lwn.net/Articles/653071/ + - [3] https://lwn.net/Articles/653466/ + Contact: Daniel Vetter, respective driver maintainers Level: Advanced