| Message ID | 20221103230648.53748-3-fabrizio.castro.jz@renesas.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp46910wru;
Thu, 3 Nov 2022 16:09:52 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM476X9/s1W2JdtmkqCsOzpCwwAT4ph5wKKvqmTsA7D78+38nJQ1MhJNnN2gzJNujJKI74AZ
X-Received: by 2002:aa7:c6cd:0:b0:461:87ab:3255 with SMTP id
b13-20020aa7c6cd000000b0046187ab3255mr32800795eds.193.1667516992548;
Thu, 03 Nov 2022 16:09:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1667516992; cv=none;
d=google.com; s=arc-20160816;
b=Q4YGpXTIoMcy7XbDzSiANVMlvdQYFT9jIvZvP3dVKHCpvZPi9ST8GCmcJWc41r++C5
y6U9EgudrnRx9ZZS9/bWWLWZW4Z+4ILnNJ2IlDPCmMVkhCosux+uMB4S6CmXa3rcTtlO
uZMr1qbFU7t+ReDBhN6SZahKnra532ptj783glLDitnoF6Mjr30poNBoknm5zP3+es/P
XTPVRiO+qO6BxjVQbHSXLtAh7wa5kytUq3tdOZzuCxImHm7lr1QM54Zrl8U8/+pgI1di
T/Aiu0NTmpRQ/OoiZ+5P1be8oDjzPCqTw43fJmC3D6KTY0X6wyyXs0COxScwfLtJjii7
RQLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=NLTXwWGdrcHmJ6GzhEGWs9JFlo7FnNUrvkMeb+xBTeY=;
b=s1lDjetdecjDQGvy6qabppwnLKmWSR4tvPuGm7PBB7KjP+LxIKgkbCFrbQqas1YH2R
jayRaOmE5tlbsAwi9ZGvErO9GlgWhH4NB0wa3bEDhM/zoc2hPuqxdK+s4BHGxio2xkrI
DKwBTAHd2BFpeN3X94hYoi8UxXiOlERtf2E2deIRyizKiXmhoXuCgUEHL/npNC/Ebbmj
iDghuMYjoWJUnJCRGW9kB6Jgf7w10laC82Z0ZQtkFjStaQ6H1ibBl4NxR1XE/1BLCt+O
PYbsayVqON7l5tzR+AIMjs2f4q3zuZ0/nVW9fpYBD1zrn7/2viioIaVLaZ55GPSNhVcm
JW4Q==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
y8-20020a056402270800b004617e8811c4si2955615edd.28.2022.11.03.16.09.29;
Thu, 03 Nov 2022 16:09:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231319AbiKCXIB (ORCPT <rfc822;yves.mi.zy@gmail.com> + 99 others);
Thu, 3 Nov 2022 19:08:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41904 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230089AbiKCXHL (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 3 Nov 2022 19:07:11 -0400
Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com
[210.160.252.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 914B51F603;
Thu, 3 Nov 2022 16:07:10 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="5.96,135,1665414000";
d="scan'208";a="141406971"
Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151])
by relmlie6.idc.renesas.com with ESMTP; 04 Nov 2022 08:07:09 +0900
Received: from mulinux.home (unknown [10.226.92.174])
by relmlir5.idc.renesas.com (Postfix) with ESMTP id AD999400B9CF;
Fri, 4 Nov 2022 08:07:05 +0900 (JST)
From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa@kernel.org>, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string
Date: Thu, 3 Nov 2022 23:06:47 +0000
Message-Id: <20221103230648.53748-3-fabrizio.castro.jz@renesas.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221103230648.53748-1-fabrizio.castro.jz@renesas.com>
References: <20221103230648.53748-1-fabrizio.castro.jz@renesas.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1748518298459738267?=
X-GMAIL-MSGID: =?utf-8?q?1748518298459738267?=
|
| Series |
Minor fixes for RZ/V2M
|
|
Commit Message
Fabrizio Castro
Nov. 3, 2022, 11:06 p.m. UTC
s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
renesas,i2c-r9a09g011 is not actually used by the driver, therefore
changing this doesn't cause any harm.
Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 03/11/2022 19:06, Fabrizio Castro wrote: > s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency. > > renesas,i2c-r9a09g011 is not actually used by the driver, therefore > changing this doesn't cause any harm. And what about other users of DTS? One chosen driver implementation might not be enough... > > Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller") You need to explain the bug - where is the issue, how it affects users. Otherwise it is not a bug and there is nothing to fix. > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > --- > Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > index c46378efc123..92e899905ef8 100644 > --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > @@ -16,7 +16,7 @@ properties: > compatible: > items: > - enum: > - - renesas,i2c-r9a09g011 # RZ/V2M > + - renesas,r9a09g011-i2c # RZ/V2M No. Deprecate instead old compatible. There are already users of it, at least in kernel. Not sure about other OS/bootloaders/firmwares. Best regards, Krzysztof
Hi Krzysztof, On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 03/11/2022 19:06, Fabrizio Castro wrote: > > s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency. > > > > renesas,i2c-r9a09g011 is not actually used by the driver, therefore > > changing this doesn't cause any harm. > > And what about other users of DTS? One chosen driver implementation > might not be enough... > > > > > Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller") > > You need to explain the bug - where is the issue, how it affects users. > Otherwise it is not a bug and there is nothing to fix. Yep. The preferred form is "<vendor>,<family>-<module>", blah blah ... > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > --- > > Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > index c46378efc123..92e899905ef8 100644 > > --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > @@ -16,7 +16,7 @@ properties: > > compatible: > > items: > > - enum: > > - - renesas,i2c-r9a09g011 # RZ/V2M > > + - renesas,r9a09g011-i2c # RZ/V2M > > No. > > Deprecate instead old compatible. There are already users of it, at > least in kernel. Not sure about other OS/bootloaders/firmwares. As stated in the cover letter: Since it's early days for r9a09g011.dtsi, and compatible renesas,i2c-r9a09g011 isn't being actively used at the moment, I think it's safe to change to make compatible strings less confusing. The bindings entered in v6.0. The first user in the kernel is not yet in a released kernel, it will be in v6.1. So it can still be fixed in v6.1... Even if we don't fix it before v6.2, I don't think there is much harm in making this change. With the patch description improved: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 04/11/2022 04:55, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> On 03/11/2022 19:06, Fabrizio Castro wrote: >>> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency. >>> >>> renesas,i2c-r9a09g011 is not actually used by the driver, therefore >>> changing this doesn't cause any harm. >> >> And what about other users of DTS? One chosen driver implementation >> might not be enough... >> >>> >>> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller") >> >> You need to explain the bug - where is the issue, how it affects users. >> Otherwise it is not a bug and there is nothing to fix. > > Yep. > > The preferred form is "<vendor>,<family>-<module>", blah blah ... > >>> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> >>> --- >>> Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> index c46378efc123..92e899905ef8 100644 >>> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> @@ -16,7 +16,7 @@ properties: >>> compatible: >>> items: >>> - enum: >>> - - renesas,i2c-r9a09g011 # RZ/V2M >>> + - renesas,r9a09g011-i2c # RZ/V2M >> >> No. >> >> Deprecate instead old compatible. There are already users of it, at >> least in kernel. Not sure about other OS/bootloaders/firmwares. > > As stated in the cover letter: > > Since it's early days for r9a09g011.dtsi, and compatible > renesas,i2c-r9a09g011 isn't being actively used at the moment, > I think it's safe to change to make compatible strings less > confusing. > > The bindings entered in v6.0. > The first user in the kernel is not yet in a released kernel, it will > be in v6.1. So it can still be fixed in v6.1... > Even if we don't fix it before v6.2, I don't think there is much harm in > making this change. > ABI break reasons should be explained in the commit because cover letter does not get merged. Best regards, Krzysztof
Hi Krzysztof and Geert, Thanks for your feedback, I'll send a new version of the bindings and DT patches to improve the changelog. Thanks, Fab > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 04 November 2022 12:55 > Subject: Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific > string > > On 04/11/2022 04:55, Geert Uytterhoeven wrote: > > Hi Krzysztof, > > > > On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> On 03/11/2022 19:06, Fabrizio Castro wrote: > >>> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency. > >>> > >>> renesas,i2c-r9a09g011 is not actually used by the driver, therefore > >>> changing this doesn't cause any harm. > >> > >> And what about other users of DTS? One chosen driver implementation > >> might not be enough... > >> > >>> > >>> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C > controller") > >> > >> You need to explain the bug - where is the issue, how it affects users. > >> Otherwise it is not a bug and there is nothing to fix. > > > > Yep. > > > > The preferred form is "<vendor>,<family>-<module>", blah blah ... > > > >>> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > >>> --- > >>> Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > >>> index c46378efc123..92e899905ef8 100644 > >>> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > >>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > >>> @@ -16,7 +16,7 @@ properties: > >>> compatible: > >>> items: > >>> - enum: > >>> - - renesas,i2c-r9a09g011 # RZ/V2M > >>> + - renesas,r9a09g011-i2c # RZ/V2M > >> > >> No. > >> > >> Deprecate instead old compatible. There are already users of it, at > >> least in kernel. Not sure about other OS/bootloaders/firmwares. > > > > As stated in the cover letter: > > > > Since it's early days for r9a09g011.dtsi, and compatible > > renesas,i2c-r9a09g011 isn't being actively used at the moment, > > I think it's safe to change to make compatible strings less > > confusing. > > > > The bindings entered in v6.0. > > The first user in the kernel is not yet in a released kernel, it will > > be in v6.1. So it can still be fixed in v6.1... > > Even if we don't fix it before v6.2, I don't think there is much harm in > > making this change. > > > > ABI break reasons should be explained in the commit because cover letter > does not get merged. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml index c46378efc123..92e899905ef8 100644 --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml @@ -16,7 +16,7 @@ properties: compatible: items: - enum: - - renesas,i2c-r9a09g011 # RZ/V2M + - renesas,r9a09g011-i2c # RZ/V2M - const: renesas,rzv2m-i2c reg: @@ -66,7 +66,7 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> i2c0: i2c@a4030000 { - compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c"; + compatible = "renesas,r9a09g011-i2c", "renesas,rzv2m-i2c"; reg = <0xa4030000 0x80>; interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 236 IRQ_TYPE_EDGE_RISING>;