diff mbox series

RISC-V: Fix warning in predicated.md

Message ID 20230602030443.124743-1-juzhe.zhong@rivai.ai
State Unresolved
Headers
Series RISC-V: Fix warning in predicated.md |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

juzhe.zhong@rivai.ai June 2, 2023, 3:04 a.m. UTC 
  From: Juzhe-Zhong <juzhe.zhong@rivai.ai>

Notice there is warning in predicates.md:
../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mode_mask(rtx, machine_mode)’:
../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     || INTVAL (op) == GET_MODE_MASK (SImode)"))))

gcc/ChangeLog:

        * config/riscv/predicates.md: Change INTVAL into UINTVAL.

---
 gcc/config/riscv/predicates.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kito Cheng June 2, 2023, 5:13 a.m. UTC | #1 
Ok

<juzhe.zhong@rivai.ai> 於 2023年6月2日 週五 11:05 寫道：

> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
>
> Notice there is warning in predicates.md:
> ../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool
> arith_operand_or_mode_mask(rtx, machine_mode)’:
> ../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
>              (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
> ../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
>      || INTVAL (op) == GET_MODE_MASK (SImode)"))))
>
> gcc/ChangeLog:
>
>         * config/riscv/predicates.md: Change INTVAL into UINTVAL.
>
> ---
>  gcc/config/riscv/predicates.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/predicates.md
> b/gcc/config/riscv/predicates.md
> index 1ed84850e35..d14b1ca30bb 100644
> --- a/gcc/config/riscv/predicates.md
> +++ b/gcc/config/riscv/predicates.md
> @@ -31,7 +31,7 @@
>    (ior (match_operand 0 "arith_operand")
>         (and (match_code "const_int")
>              (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
> -                        || INTVAL (op) == GET_MODE_MASK (SImode)"))))
> +                        || UINTVAL (op) == GET_MODE_MASK (SImode)"))))
>
>  (define_predicate "lui_operand"
>    (and (match_code "const_int")
> --
> 2.36.1
>
>
Li, Pan2 via Gcc-patches June 2, 2023, 6:12 a.m. UTC | #2 
Committed, thanks Kito.

Pan

-----Original Message-----
From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Kito Cheng via Gcc-patches
Sent: Friday, June 2, 2023 1:13 PM
To: 钟居哲 <juzhe.zhong@rivai.ai>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; Kito Cheng <kito.cheng@gmail.com>; Palmer Dabbelt <palmer@dabbelt.com>; Palmer Dabbelt <palmer@rivosinc.com>; Jeff Law <jeffreyalaw@gmail.com>; Robin Dapp <rdapp.gcc@gmail.com>
Subject: Re: [PATCH] RISC-V: Fix warning in predicated.md

Ok

<juzhe.zhong@rivai.ai> 於 2023年6月2日 週五 11:05 寫道：

> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
>
> Notice there is warning in predicates.md:
> ../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool 
> arith_operand_or_mode_mask(rtx, machine_mode)’:
> ../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
>              (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
> ../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
>      || INTVAL (op) == GET_MODE_MASK (SImode)"))))
>
> gcc/ChangeLog:
>
>         * config/riscv/predicates.md: Change INTVAL into UINTVAL.
>
> ---
>  gcc/config/riscv/predicates.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/predicates.md 
> b/gcc/config/riscv/predicates.md index 1ed84850e35..d14b1ca30bb 100644
> --- a/gcc/config/riscv/predicates.md
> +++ b/gcc/config/riscv/predicates.md
> @@ -31,7 +31,7 @@
>    (ior (match_operand 0 "arith_operand")
>         (and (match_code "const_int")
>              (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
> -                        || INTVAL (op) == GET_MODE_MASK (SImode)"))))
> +                        || UINTVAL (op) == GET_MODE_MASK 
> + (SImode)"))))
>
>  (define_predicate "lui_operand"
>    (and (match_code "const_int")
> --
> 2.36.1
>
>
Andreas Schwab June 2, 2023, 9:29 a.m. UTC | #3 
../../gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mod
e_mask(rtx, machine_mode)’:
../../gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
juzhe.zhong@rivai.ai June 2, 2023, 9:31 a.m. UTC | #4 
Oh there is 2 INTVAL (op) == GET_MODE_MASK...
I only change one .... :)



juzhe.zhong@rivai.ai
 
From: Andreas Schwab
Date: 2023-06-02 17:29
To: juzhe.zhong
CC: gcc-patches; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc
Subject: Re: [PATCH] RISC-V: Fix warning in predicated.md
../../gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mod
e_mask(rtx, machine_mode)’:
../../gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
 
-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
juzhe.zhong@rivai.ai June 2, 2023, 9:35 a.m. UTC | #5 
Hi, I fixed it :
https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620462.html 
Just feel free to commit it.

Thanks.


juzhe.zhong@rivai.ai
 
From: Andreas Schwab
Date: 2023-06-02 17:29
To: juzhe.zhong
CC: gcc-patches; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc
Subject: Re: [PATCH] RISC-V: Fix warning in predicated.md
../../gcc/gcc/config/riscv/predicates.md: In function ‘bool arith_operand_or_mod
e_mask(rtx, machine_mode)’:
../../gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
 
-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
diff mbox series

Patch

diff --git a/gcc/config/riscv/predicates.md b/gcc/config/riscv/predicates.md
index 1ed84850e35..d14b1ca30bb 100644
--- a/gcc/config/riscv/predicates.md
+++ b/gcc/config/riscv/predicates.md
@@ -31,7 +31,7 @@ 
   (ior (match_operand 0 "arith_operand")
        (and (match_code "const_int")
             (match_test "INTVAL (op) == GET_MODE_MASK (HImode)
-			 || INTVAL (op) == GET_MODE_MASK (SImode)"))))
+			 || UINTVAL (op) == GET_MODE_MASK (SImode)"))))
 
 (define_predicate "lui_operand"
   (and (match_code "const_int")