Message ID | 20230601103817.4066446-1-abel.vesa@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp215010vqr; Thu, 1 Jun 2023 03:55:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zYpZyYqB4cuUtlEQkBHXPUw3u3Rt5ZTEfpdjBchiodo8fqwu9BvlqXqjeRlSYiAOhtVas X-Received: by 2002:aa7:88c5:0:b0:640:e12a:3a20 with SMTP id k5-20020aa788c5000000b00640e12a3a20mr8199343pff.1.1685616933816; Thu, 01 Jun 2023 03:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685616933; cv=none; d=google.com; s=arc-20160816; b=W8JibVvw6WYgNY/6HteDvo8IEcmDyDFOPqi6fZnneuCpZqXpeVekyEJa4G376IQC8j l3DFaCiqXuBaDiC44JDXUo57hFiRETU6qg618ylPbdH35Ax6ELAb7yQ5HQkExMl98gZL sBCfcA5+1NNueQxo0F1tG09EWsPnC/1xDJg9uTMOYgIleJKbxUfuC/rADbw2GjEhD9Ko R77FYkWK0h6qzQNNmCNN712+tPzT3dRqubDF759xZdHKZaues5I928vLMF3brqcatjmY nj0moimB62rZSxqr84PlU8BR4buQxWvB8LUvxqa7oqbL+M4XQGhvHsKO+5hHV0tthyel AiqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MpSv9l53PjEtQRLkIxBG42do2AGdWpb+x9tdN2ngo3s=; b=RMOAhC8vobAaPNcioSwUZ+fYlX8sSgvACXVByu97hdoH9oGkqu6ReKkazd8ZK1cA6Q zOrCmAwgZLxe1plY/jXt9OWfUj/KN3wiG6yw75UyBtPCu9ar74iCf/SWb0/rXqd4IAT/ ZLrETtKiBEGd2mlJGnk3mqq4/KQulqHggs9uIJ8yMYFPkR5b2eKmUFCzq3Ax3jSC9dOU xt9GmDVWfqj4/ztiUhZvQwB6tuNwC/uMEc357BrqiauXCIzDUUvvL7q+xgoQo86SJv0m xqyBBTIoRYGxQgbAUXSprEsENeh/w5JBdqVzgLhU+DSDmqq7hsNUjKqYhXl26so+jLRv 8GEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oN63DFjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i132-20020a639d8a000000b0053b86623b3asi219087pgd.577.2023.06.01.03.55.21; Thu, 01 Jun 2023 03:55:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oN63DFjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232828AbjFAKif (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Thu, 1 Jun 2023 06:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbjFAKid (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 1 Jun 2023 06:38:33 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22BDCD7 for <linux-kernel@vger.kernel.org>; Thu, 1 Jun 2023 03:38:30 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f4f89f71b8so729233e87.3 for <linux-kernel@vger.kernel.org>; Thu, 01 Jun 2023 03:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685615908; x=1688207908; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MpSv9l53PjEtQRLkIxBG42do2AGdWpb+x9tdN2ngo3s=; b=oN63DFjS5mHVv8CfmEvxgkpA7dlK6AO6hOTpdYY2WmCn222R87NCqrKxUHgyXn/7P7 6v6Wl6gVsyJobkQ23tskYdi4Zv9QFRkXf4Je8MbeZiKam+jOm/GiU+N2b3+RXz4eXSRa ir53JsTo/vt4rc6dIG2Z5Ra7u8k99tGbbcjs2+yRC+wmTaT1IDYoncn8pdGobp8NWsNe cZ7DjD/XU4ygOJQ/3uUANcuyiVORz90NwxuyucE+UyY7G31l9qQgoznWNim79esQTIfL R5tI2oaw8nh/l/tEjZDLVSGFYs3fyvST0pHw7P9T6bQgAAQQRx6/EaK/L28jMpLRtylg 51xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685615908; x=1688207908; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MpSv9l53PjEtQRLkIxBG42do2AGdWpb+x9tdN2ngo3s=; b=LBj5JZsBQwKQv++uhbQOD9wYVG0NsQpnJw78mRf85OwYcimDqfXMNkMI5KBUU1dgFQ pw6pwulwqzBKUVUQPqHRz5Ssff3JEQzLSxBfOwpcgsyUAk4ytxQ86wCnZm4vfsnegokM 0Rtos/cnoR3xHbJx3/w+jNUI779eGcXafZxXYCr8lJoQ4bwE79aDq978VuxoQi7UBVVu rCU89cA17y6j4vgPRzgwpAPkfQTTr2O2S8wRQpCDSg67uFycrv3HwBRJziOpI7VOsfUm 4KkbmbprhD62+/6IVY2bQbt8yEm2DvVdwk2FgUmdKeRpzIDkmrZRNG/YBnDH1ley9AZo gAoA== X-Gm-Message-State: AC+VfDxRdOIMn0T6c6E1HgeOZMyBjbyVfIllP67AeXGxM6SDkHnbs6Ua aAofedmrtbo4TTkmtIHnCSDw+g== X-Received: by 2002:ac2:54a9:0:b0:4f4:b3a6:4135 with SMTP id w9-20020ac254a9000000b004f4b3a64135mr961086lfk.55.1685615908394; Thu, 01 Jun 2023 03:38:28 -0700 (PDT) Received: from hackbox.lan ([86.121.163.20]) by smtp.gmail.com with ESMTPSA id h11-20020a1ccc0b000000b003f423dfc686sm1855975wmb.45.2023.06.01.03.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 03:38:27 -0700 (PDT) From: Abel Vesa <abel.vesa@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC Date: Thu, 1 Jun 2023 13:38:17 +0300 Message-Id: <20230601103817.4066446-1-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767497461898459420?= X-GMAIL-MSGID: =?utf-8?q?1767497461898459420?= |
Series |
arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
|
|
Commit Message
Abel Vesa
June 1, 2023, 10:38 a.m. UTC
The USB HC node is missing the interconnect paths, so add them.
Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 1.06.2023 12:38, Abel Vesa wrote: > The USB HC node is missing the interconnect paths, so add them. > > Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes") For context, it's a fix in the context of "we should prooobably have this if we want to fix the icc driver to include sync state". > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> sidenote: on recent SoCs there's also an USB-IPA path: aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG I don't think we really make use of that upstream today or whether it would make enabling IPA necessary (to enable the clocks and reach the IPA hardware), but it's something to think about. Konrad > arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 75cd374943eb..4991b2e962d1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 { > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; > + interconnect-names = "usb-ddr", "apps-usb"; > + > status = "disabled"; > > usb_1_dwc3: usb@a600000 {
On 23-06-01 12:42:22, Konrad Dybcio wrote: > > > On 1.06.2023 12:38, Abel Vesa wrote: > > The USB HC node is missing the interconnect paths, so add them. > > > > Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes") > For context, it's a fix in the context of "we should prooobably have > this if we want to fix the icc driver to include sync state". Fair enough... > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > > > sidenote: > > on recent SoCs there's also an USB-IPA path: > > aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG AFAIK, support for IPA on SM8550 is not added yet. We can worry about this 3rd path when IPA support for this platform is upstreamed. > > I don't think we really make use of that upstream today or whether it > would make enabling IPA necessary (to enable the clocks and reach the > IPA hardware), but it's something to think about. > > Konrad > > arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > > index 75cd374943eb..4991b2e962d1 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > > @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 { > > > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > > > + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, > > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; > > + interconnect-names = "usb-ddr", "apps-usb"; > > + > > status = "disabled"; > > > > usb_1_dwc3: usb@a600000 {
On 1.06.2023 12:49, Abel Vesa wrote: > On 23-06-01 12:42:22, Konrad Dybcio wrote: >> >> >> On 1.06.2023 12:38, Abel Vesa wrote: >>> The USB HC node is missing the interconnect paths, so add them. >>> >>> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes") >> For context, it's a fix in the context of "we should prooobably have >> this if we want to fix the icc driver to include sync state". > > Fair enough... > >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >>> --- >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> >> >> sidenote: >> >> on recent SoCs there's also an USB-IPA path: >> >> aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG > > AFAIK, support for IPA on SM8550 is not added yet. > > We can worry about this 3rd path when IPA support for this platform is > upstreamed. Right, that's what I'm saying. I'm not even sure we have tethering acceleration upstream (where IPA pushes data quickly for sharing mobile data via USB). Konrad > >> >> I don't think we really make use of that upstream today or whether it >> would make enabling IPA necessary (to enable the clocks and reach the >> IPA hardware), but it's something to think about. >> >> Konrad >>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi >>> index 75cd374943eb..4991b2e962d1 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi >>> @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 { >>> >>> resets = <&gcc GCC_USB30_PRIM_BCR>; >>> >>> + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, >>> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; >>> + interconnect-names = "usb-ddr", "apps-usb"; >>> + >>> status = "disabled"; >>> >>> usb_1_dwc3: usb@a600000 {
On Thu, 1 Jun 2023 13:38:17 +0300, Abel Vesa wrote: > The USB HC node is missing the interconnect paths, so add them. > > Applied, thanks! [1/1] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC commit: 11a1397bbf69e408223bb691858a0fcd295a8f76 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 75cd374943eb..4991b2e962d1 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + status = "disabled"; usb_1_dwc3: usb@a600000 {