Message ID | 20230601054549.10843-11-nikita.shubin@maquefel.me |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp78447vqr; Wed, 31 May 2023 23:05:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5nalWbHlu6pm+fr9w9bb01ryb33nIqNZqwbI4OKNFiBk6ZJEDdM0ENxASCi6Yz0uLQVfgJ X-Received: by 2002:a9d:7511:0:b0:6af:a1d3:e7f1 with SMTP id r17-20020a9d7511000000b006afa1d3e7f1mr4578735otk.31.1685599526366; Wed, 31 May 2023 23:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685599526; cv=none; d=google.com; s=arc-20160816; b=qsZTXowuWZUQ74Q9otoDlPiBVCo0x7a4Qh8nBrktwFOw83iZdRwa98EL1hCZRaFGd3 pTC4nifIsW1GTry67x0E93LyQReoRk3mhTxxI9sGcrCGZ0+hG8/+O1nNEL45GqqDUZHH 1nNz7BDaJylQxt1HrNVqz23rihKXZjWPPQkC1nnCu4zhgB9jE97FRxBMwPmoHdIfAmD1 2v3wf9sCFKOVfaOt9Hs6Gc1UlAf+srRiz6Nv6usd1sq17VwwxihBX+ICU0ZT2hbzFtHu 5yJp8aAUAVItAz0xfaki14N3r7i4BE+Ef5zkmg4SfxYMgdg29ufN1NelCSpQc6+LCDtM Tm9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8mv9WgoxbioXCOy16e14XS+bGBzb5G+x5fHcfpNSO94=; b=x58MZq9gysrqljVsKSwgxAvRm8z/PguCTTBEJ9VVjXTTUr821NdrL/GO4jI7CU/9bf tELOOCeX/v3l3PzVGp3yNNy6oitSRapA4jOrfrbyAHdCOekBMjV0y512VeG1Cd457Fzt iHP9drSq4q1AOEzvxGgPeJ4SZiajXSkTFgiuLXpxiVDd7IdSEMn9mI/VczfziD56Yglv Ji6/8cXl6Tfr2NPFzyoScRbYdzCZ3HQSULmSGkk2qzT2Es55RFAn7eAvNii5984R9e6r pU5zRQjF/NC8RvOpX0ftmE8hBIoOGLXyxwMjjeqaxyZlzND5zKHjoA44YAIedCXdpz6C XgFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@maquefel.me header.s=mail header.b=bAdCoH4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m7-20020a625807000000b0064d56036aeasi4800783pfb.255.2023.05.31.23.05.10; Wed, 31 May 2023 23:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@maquefel.me header.s=mail header.b=bAdCoH4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231690AbjFAFr2 (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Thu, 1 Jun 2023 01:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231532AbjFAFqr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 1 Jun 2023 01:46:47 -0400 Received: from forward103a.mail.yandex.net (forward103a.mail.yandex.net [178.154.239.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E24CD198; Wed, 31 May 2023 22:46:21 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:5e51:0:640:23ee:0]) by forward103a.mail.yandex.net (Yandex) with ESMTP id A6CD546C82; Thu, 1 Jun 2023 08:46:18 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id pjGDMhnDduQ0-hLahdx3m; Thu, 01 Jun 2023 08:46:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1685598378; bh=8mv9WgoxbioXCOy16e14XS+bGBzb5G+x5fHcfpNSO94=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=bAdCoH4GwgznK3z6WyG85AD3cuS2Egc8kxwU4LQF2pAwXudQK4/8SyAz2zPd4g2pl tYafkfQB2IelK0f4aPYMNZXueyIXq78YEL7lWhbSuqEMscSUks5C85aQ9H07wwowdW +ldhDHbBc2TShyNOjNI9+/XGM1rxaaNDnAMOzSKU= Authentication-Results: mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net; dkim=pass header.i=@maquefel.me From: Nikita Shubin <nikita.shubin@maquefel.me> To: Alexander Sverdlin <alexander.sverdlin@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Nikita Shubin <nikita.shubin@maquefel.me>, Michael Peters <mpeters@embeddedTS.com>, Kris Bahnsen <kris@embeddedTS.com>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86 Date: Thu, 1 Jun 2023 08:45:34 +0300 Message-Id: <20230601054549.10843-11-nikita.shubin@maquefel.me> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20230424123522.18302-1-nikita.shubin@maquefel.me> References: <20230424123522.18302-1-nikita.shubin@maquefel.me> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767479208495308994?= X-GMAIL-MSGID: =?utf-8?q?1767479208495308994?= |
Series |
None
|
|
Commit Message
Nikita Shubin
June 1, 2023, 5:45 a.m. UTC
Add YAML bindings for ST M48T86 / Dallas DS12887 RTC.
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
Notes:
v0 -> v1:
- s/dallas/st/
- description for regs
- s/additionalProperties/unevaluatedProperties/
- add ref rtc.yaml
- changed compatible to st,m48t86
- dropped label in example
- replaced Alessandro Alessandro to Alexandre Belloni
.../bindings/rtc/st,m48t86-rtc.yaml | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
Comments
On 01/06/2023 07:45, Nikita Shubin wrote: > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > > Notes: > v0 -> v1: > > - s/dallas/st/ > - description for regs > - s/additionalProperties/unevaluatedProperties/ > - add ref rtc.yaml > - changed compatible to st,m48t86 > - dropped label in example > - replaced Alessandro Alessandro to Alexandre Belloni > > .../bindings/rtc/st,m48t86-rtc.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > new file mode 100644 > index 000000000000..eb8e6451d7c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml Filename based on compatible, so drop "rtc". > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM typo: with > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + > +properties: > + compatible: > + enum: > + - st,m48t86 > + > + reg: > + items: > + - description: index register > + - description: data register > + > +allOf: > + - $ref: rtc.yaml > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg required goes after properties: Keep the same order in all your patches. > + > +examples: > + - | > + rtc@10800000 { > + compatible = "st,m48t86"; > + reg = <0x10800000 0x1>, <0x11700000 0x1>; One byte long? Not a word? > + }; > + > +... Best regards, Krzysztof
Hello Krzysztof! On Thu, 2023-06-01 at 10:18 +0200, Krzysztof Kozlowski wrote: > On 01/06/2023 07:45, Nikita Shubin wrote: > > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC. > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > --- > > > > Notes: > > v0 -> v1: > > > > - s/dallas/st/ > > - description for regs > > - s/additionalProperties/unevaluatedProperties/ > > - add ref rtc.yaml > > - changed compatible to st,m48t86 > > - dropped label in example > > - replaced Alessandro Alessandro to Alexandre Belloni > > > > .../bindings/rtc/st,m48t86-rtc.yaml | 38 > > +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86- > > rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > new file mode 100644 > > index 000000000000..eb8e6451d7c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml > > Filename based on compatible, so drop "rtc". > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM > > typo: with > > > + > > +maintainers: > > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > > + > > +properties: > > + compatible: > > + enum: > > + - st,m48t86 > > + > > + reg: > > + items: > > + - description: index register > > + - description: data register > > + > > +allOf: > > + - $ref: rtc.yaml > > + > > +unevaluatedProperties: false > > + > > +required: > > + - compatible > > + - reg > > required goes after properties: > > Keep the same order in all your patches. > > > + > > +examples: > > + - | > > + rtc@10800000 { > > + compatible = "st,m48t86"; > > + reg = <0x10800000 0x1>, <0x11700000 0x1>; > > One byte long? Not a word? They are indeed one byte long: https://elixir.bootlin.com/linux/v6.4-rc7/source/drivers/rtc/rtc-m48t86.c#L46 > > > + }; > > + > > +... > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml new file mode 100644 index 000000000000..eb8e6451d7c8 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM + +maintainers: + - Alexandre Belloni <alexandre.belloni@bootlin.com> + +properties: + compatible: + enum: + - st,m48t86 + + reg: + items: + - description: index register + - description: data register + +allOf: + - $ref: rtc.yaml + +unevaluatedProperties: false + +required: + - compatible + - reg + +examples: + - | + rtc@10800000 { + compatible = "st,m48t86"; + reg = <0x10800000 0x1>, <0x11700000 0x1>; + }; + +...