Message ID | 20230530162454.51708-2-vkoul@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2310458vqr; Tue, 30 May 2023 09:34:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4mgZMIaKee6dWf2AGOS0HcKa2O5o3BnsxZRn16OkD5AyPVTdpYEz2SJJiRIj3wgpHel3PS X-Received: by 2002:a05:6a21:380f:b0:101:2f83:5fba with SMTP id yi15-20020a056a21380f00b001012f835fbamr2307557pzb.31.1685464465795; Tue, 30 May 2023 09:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685464465; cv=none; d=google.com; s=arc-20160816; b=WU9kTV4KWDfjAVykevGUQ1PgGQD+26o3UszNpILTJ023A0tnNdm3B4Xo3xeL3X1h0j z2mCQ8ELEzcGjoF5vsaCBXDpKkYuyAjtZ3QNVohcX3WTOnlkx0k5IU9ATThIUzgi4By3 7/hakp5LinMtqhQVL9Ak9AX3MOg+VRhuhO0laMlHqSwRkDZRT3x3YqPM7gF1WA/+lFiG lR9yK3qKs8v7Qb+5D3zDGky7J0oZptHg86dVSKeVDnkl8dzgJ/jQoMXrzC6vu8BmG70Y lVRhiNATT7xmO0iav90NSnqpH+OLdeCeNDFuro+WnjnUE3KgcqNWsdZnxv0Q39jYMpb5 3VJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=clxbWvEvnNNdBtGYwyTe+1FjtHfRv0CYtwdtQHxaTBA=; b=VJQ2N57vTiaYgxoWG7PtUlq3HfbrUYfU2qf6MJFwJA7LNovhQ2TbNNgMcXM/H0m1EE YgCoF2KEjjhQT+OSC/hq1TH4Dh/zyUpjBQZfQLjpn/divqGEL0Z3wmtD7nMhYSw2zavf u3s2rk+ZPeBP0EHyIfxndwcgrRDb0Ms3fREvsoV7HUr2uBiEdQt+yJYsBLrRrn8ZXC+S GhBN3jPzCRtoKF0GRNbwWbtBHT324DDBhTORqUwEyIpG2oPDgk0JrXlHAzgpfiI7vEpe jeKiyJYaZvpc36sxTaqgXnCmOTI5vDl0csHgHLT2MeDjQIGs9jm6knSdywFlXmjG1lH2 3kzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aetMphh/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020aa78bd6000000b00643b2b72c8esi1917909pfd.317.2023.05.30.09.34.11; Tue, 30 May 2023 09:34:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aetMphh/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232045AbjE3QZf (ORCPT <rfc822;andrewvogler123@gmail.com> + 99 others); Tue, 30 May 2023 12:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231910AbjE3QZb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 30 May 2023 12:25:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187BF11D; Tue, 30 May 2023 09:25:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5766560CA4; Tue, 30 May 2023 16:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A570C433A7; Tue, 30 May 2023 16:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685463907; bh=c6AGKWOZbqw3+DTVVifBJKHqZLfhJBeG4c33ZI92WM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aetMphh/jp8E0sT6W7xZw6g52tpK/B5/isECt+TrDMWR04Iq2g0PsJ+jpw9CRJ86/ n+LfNNkKUr74k5VyLtYuTUWTMH2h4pb+XwMmr/ns+s6qIDuMytgDQXYGZjejEcpxU+ lsKhwaPEmqQnMivvdZTsXnBRv/titSJ7H4NUSMmUw8zu7UUT5m3iXIPELFQrSil+Cf q17+aLGapTXgWNmbKvG3G5BazxDxqaIHf/elDxNWdMoNrk4+757J75rsNt94XoBKq0 zFQSsPcAwP33412Z3HQlBoZVBNJaa0NHGeFqhKHZjfjRGDBKKyVJt+PRDh+qkXOcSM lKSscywRwf6Yg== From: Vinod Koul <vkoul@kernel.org> To: Bjorn Andersson <andersson@kernel.org> Cc: linux-arm-msm@vger.kernel.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= <kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org> Subject: [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts Date: Tue, 30 May 2023 21:54:40 +0530 Message-Id: <20230530162454.51708-2-vkoul@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230530162454.51708-1-vkoul@kernel.org> References: <20230530162454.51708-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767337587287642699?= X-GMAIL-MSGID: =?utf-8?q?1767337587287642699?= |
Series |
Introduce the SC8180x devices
|
|
Commit Message
Vinod Koul
May 30, 2023, 4:24 p.m. UTC
Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x
compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to
YAML") converted the description to yaml
But there are still some errors specific to sc8180x which this change
attempts to fix. The clocks and resets for sc8180 pcie controller are
different so need to be documented separately
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 29 ++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
Comments
On 30/05/2023 18:24, Vinod Koul wrote: > Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x > compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to > YAML") converted the description to yaml > > But there are still some errors specific to sc8180x which this change > attempts to fix. The clocks and resets for sc8180 pcie controller are > different so need to be documented separately I don't get what's the error here to fix. The clocks you list are already there as part of oneOf. > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../devicetree/bindings/pci/qcom,pcie.yaml | 29 ++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 81971be4e554..40a1f451a3d3 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -476,6 +476,33 @@ allOf: > items: > - const: pci # PCIe core reset > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-sc8180x > + then: > + properties: > + clocks: > + minItems: 8 > + maxItems: 8 > + clock-names: > + items: > + - const: pipe # PIPE clock > + - const: aux # Auxiliary clock > + - const: cfg # Configuration clock > + - const: bus_master # Master AXI clock > + - const: bus_slave # Slave AXI clock > + - const: slave_q2a # Slave Q2A clock > + - const: ref # REFERENCE clock > + - const: tbu # PCIe TBU clock > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: pci # PCIe core reset > + > - if: > properties: > compatible: > @@ -524,7 +551,6 @@ allOf: > compatible: > contains: > enum: > - - qcom,pcie-sc8180x > - qcom,pcie-sm8150 > - qcom,pcie-sm8250 > then: > @@ -749,6 +775,7 @@ allOf: > contains: > enum: > - qcom,pcie-sa8540p > + - qcom,pcie-sc8180x > - qcom,pcie-sc8280xp > then: > required: Best regards, Krzysztof
On 31-05-23, 10:19, Krzysztof Kozlowski wrote: > On 30/05/2023 18:24, Vinod Koul wrote: > > Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x > > compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to > > YAML") converted the description to yaml > > > > But there are still some errors specific to sc8180x which this change > > attempts to fix. The clocks and resets for sc8180 pcie controller are > > different so need to be documented separately > > I don't get what's the error here to fix. The clocks you list are > already there as part of oneOf. It was listed with sm8150 block which has different set of clocks than used in sc81880x, so this needs to have its own block of clocks and resets > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > .../devicetree/bindings/pci/qcom,pcie.yaml | 29 ++++++++++++++++++- > > 1 file changed, 28 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index 81971be4e554..40a1f451a3d3 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -476,6 +476,33 @@ allOf: > > items: > > - const: pci # PCIe core reset > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - qcom,pcie-sc8180x > > + then: > > + properties: > > + clocks: > > + minItems: 8 > > + maxItems: 8 > > + clock-names: > > + items: > > + - const: pipe # PIPE clock > > + - const: aux # Auxiliary clock > > + - const: cfg # Configuration clock > > + - const: bus_master # Master AXI clock > > + - const: bus_slave # Slave AXI clock > > + - const: slave_q2a # Slave Q2A clock > > + - const: ref # REFERENCE clock > > + - const: tbu # PCIe TBU clock > > + resets: > > + maxItems: 1 > > + reset-names: > > + items: > > + - const: pci # PCIe core reset > > + > > - if: > > properties: > > compatible: > > @@ -524,7 +551,6 @@ allOf: > > compatible: > > contains: > > enum: > > - - qcom,pcie-sc8180x > > - qcom,pcie-sm8150 > > - qcom,pcie-sm8250 > > then: > > @@ -749,6 +775,7 @@ allOf: > > contains: > > enum: > > - qcom,pcie-sa8540p > > + - qcom,pcie-sc8180x > > - qcom,pcie-sc8280xp > > then: > > required: > > Best regards, > Krzysztof
On 01/06/2023 09:21, Vinod Koul wrote: > On 31-05-23, 10:19, Krzysztof Kozlowski wrote: >> On 30/05/2023 18:24, Vinod Koul wrote: >>> Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x >>> compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to >>> YAML") converted the description to yaml >>> >>> But there are still some errors specific to sc8180x which this change >>> attempts to fix. The clocks and resets for sc8180 pcie controller are >>> different so need to be documented separately >> >> I don't get what's the error here to fix. The clocks you list are >> already there as part of oneOf. > > It was listed with sm8150 block which has different set of clocks than > used in sc81880x, so this needs to have its own block of clocks and > resets Ah, after careful check I see indeed difference in one clock. Best regards, Krzysztof
On 30/05/2023 18:24, Vinod Koul wrote: > Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x > compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to > YAML") converted the description to yaml > > But there are still some errors specific to sc8180x which this change > attempts to fix. The clocks and resets for sc8180 pcie controller are > different so need to be documented separately > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 81971be4e554..40a1f451a3d3 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -476,6 +476,33 @@ allOf: items: - const: pci # PCIe core reset + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-sc8180x + then: + properties: + clocks: + minItems: 8 + maxItems: 8 + clock-names: + items: + - const: pipe # PIPE clock + - const: aux # Auxiliary clock + - const: cfg # Configuration clock + - const: bus_master # Master AXI clock + - const: bus_slave # Slave AXI clock + - const: slave_q2a # Slave Q2A clock + - const: ref # REFERENCE clock + - const: tbu # PCIe TBU clock + resets: + maxItems: 1 + reset-names: + items: + - const: pci # PCIe core reset + - if: properties: compatible: @@ -524,7 +551,6 @@ allOf: compatible: contains: enum: - - qcom,pcie-sc8180x - qcom,pcie-sm8150 - qcom,pcie-sm8250 then: @@ -749,6 +775,7 @@ allOf: contains: enum: - qcom,pcie-sa8540p + - qcom,pcie-sc8180x - qcom,pcie-sc8280xp then: required: