diff mbox series

[v1,16/43] pwm: ep93xx: add DT support for Cirrus EP93xx

Message ID 20230601053546.9574-17-nikita.shubin@maquefel.me
State New
Headers
Series None |

Commit Message

Nikita Shubin June 1, 2023, 5:34 a.m. UTC 
  - find register range from the device tree
- provide clock access via of

Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---

Notes:
    v0 -> v1:
    
    - fixed headers
    - fixed id table

 drivers/pwm/pwm-ep93xx.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Uwe Kleine-König June 1, 2023, 7:01 a.m. UTC | #1 
Hello,

On Thu, Jun 01, 2023 at 08:34:07AM +0300, Nikita Shubin wrote:
> - find register range from the device tree
> - provide clock access via of
> 
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>

Looks good to me,

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

There don't seem to be dependencies interdependencies to other patches
in this series?! What is the merge plan here. Should this patch go in
via the PWM tree, or will the whole series go in via armsoc?

Best regards
Uwe
Nikita Shubin June 1, 2023, 10:12 a.m. UTC | #2 
Hello Uwe!

On Thu, 1 Jun 2023 09:01:28 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> Hello,
> 
> On Thu, Jun 01, 2023 at 08:34:07AM +0300, Nikita Shubin wrote:
> > - find register range from the device tree
> > - provide clock access via of
> > 
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>  
> 
> Looks good to me,
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thank you.

> 
> There don't seem to be dependencies interdependencies to other patches
> in this series?! What is the merge plan here. Should this patch go in
> via the PWM tree, or will the whole series go in via armsoc?

We are hoping to get it merged as a whole, and not in pieces.

So we are trying to get Ack for all patches in series.

> 
> Best regards
> Uwe
>
Andy Shevchenko June 3, 2023, 8:12 p.m. UTC | #3 
Thu, Jun 01, 2023 at 08:34:07AM +0300, Nikita Shubin kirjoitti:
> - find register range from the device tree

> - provide clock access via of

Not sure what does this supose to mean. Copy'n'paste mistake?

Please, revisit commit messages in *all* your patches.
With this addressed, for this patch
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> 
> Notes:
>     v0 -> v1:
>     
>     - fixed headers
>     - fixed id table
> 
>  drivers/pwm/pwm-ep93xx.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
> index c45a75e65c86..361984ef4c0b 100644
> --- a/drivers/pwm/pwm-ep93xx.c
> +++ b/drivers/pwm/pwm-ep93xx.c
> @@ -17,6 +17,7 @@
>   */
>  
>  #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/clk.h>
> @@ -190,9 +191,16 @@ static int ep93xx_pwm_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id ep93xx_pwm_of_ids[] = {
> +	{ .compatible = "cirrus,ep9301-pwm" },
> +	{ /* sentinel */}
> +};
> +MODULE_DEVICE_TABLE(of, ep93xx_pwm_of_ids);
> +
>  static struct platform_driver ep93xx_pwm_driver = {
>  	.driver = {
>  		.name = "ep93xx-pwm",
> +		.of_match_table = ep93xx_pwm_of_ids,
>  	},
>  	.probe = ep93xx_pwm_probe,
>  };
> -- 
> 2.37.4
>
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
index c45a75e65c86..361984ef4c0b 100644
--- a/drivers/pwm/pwm-ep93xx.c
+++ b/drivers/pwm/pwm-ep93xx.c
@@ -17,6 +17,7 @@ 
  */
 
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/clk.h>
@@ -190,9 +191,16 @@  static int ep93xx_pwm_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id ep93xx_pwm_of_ids[] = {
+	{ .compatible = "cirrus,ep9301-pwm" },
+	{ /* sentinel */}
+};
+MODULE_DEVICE_TABLE(of, ep93xx_pwm_of_ids);
+
 static struct platform_driver ep93xx_pwm_driver = {
 	.driver = {
 		.name = "ep93xx-pwm",
+		.of_match_table = ep93xx_pwm_of_ids,
 	},
 	.probe = ep93xx_pwm_probe,
 };