diff mbox series

soc: qcom: icc-bwmon: Fix MSM8998 count unit

Message ID 20230531-topic-msm8998-bwmon-v1-1-454f9d550ee5@linaro.org
State New
Headers
Series soc: qcom: icc-bwmon: Fix MSM8998 count unit |

Commit Message

Konrad Dybcio May 31, 2023, 4:33 p.m. UTC 
  MSM8998's BWMON counts in megabytes. Fix it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/soc/qcom/icc-bwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: d4cee89031c80066ec461bb77b5e13a4f37d5fd2
change-id: 20230531-topic-msm8998-bwmon-ba20827e470e

Best regards,

Comments

Krzysztof Kozlowski May 31, 2023, 5:03 p.m. UTC | #1 
On 31/05/2023 18:33, Konrad Dybcio wrote:
> MSM8998's BWMON counts in megabytes. Fix it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/soc/qcom/icc-bwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If this is
https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
(and QLT 1872) then add reported-by tag.

Change seems logical, although not really documented (a bit
contradictory information for sdm845), so assuming this was really tested:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Konrad Dybcio May 31, 2023, 5:05 p.m. UTC | #2 
On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
> On 31/05/2023 18:33, Konrad Dybcio wrote:
>> MSM8998's BWMON counts in megabytes. Fix it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  drivers/soc/qcom/icc-bwmon.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> If this is
> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
> (and QLT 1872) then add reported-by tag.
It's not, I fired up 8998, added debug prints and ran mybw.

> 
> Change seems logical, although not really documented (a bit
> contradictory information for sdm845), so assuming this was really tested:
It's not for sdm845, after the last cleanup both BWMONs on that
one got its own driver data struct.

Konrad
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski May 31, 2023, 5:10 p.m. UTC | #3 
On 31/05/2023 19:05, Konrad Dybcio wrote:
> 
> 
> On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
>> On 31/05/2023 18:33, Konrad Dybcio wrote:
>>> MSM8998's BWMON counts in megabytes. Fix it.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>  drivers/soc/qcom/icc-bwmon.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> If this is
>> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
>> (and QLT 1872) then add reported-by tag.
> It's not, I fired up 8998, added debug prints and ran mybw.
> 
>>
>> Change seems logical, although not really documented (a bit
>> contradictory information for sdm845), so assuming this was really tested:
> It's not for sdm845, after the last cleanup both BWMONs on that
> one got its own driver data struct.

Ah, ok, Acks stays :)

Best regards,
Krzysztof
Bjorn Andersson June 13, 2023, 10:30 p.m. UTC | #4 
On Wed, 31 May 2023 18:33:03 +0200, Konrad Dybcio wrote:
> MSM8998's BWMON counts in megabytes. Fix it.
> 
> 

Applied, thanks!

[1/1] soc: qcom: icc-bwmon: Fix MSM8998 count unit
      commit: 1c8267cd14ed6a592a2c2a8eb0fefad4eabe5b4f

Best regards,
diff mbox series

Patch

diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index f65bfeca7ed6..40068a285913 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -806,7 +806,7 @@  static int bwmon_remove(struct platform_device *pdev)
 
 static const struct icc_bwmon_data msm8998_bwmon_data = {
 	.sample_ms = 4,
-	.count_unit_kb = 64,
+	.count_unit_kb = 1024,
 	.default_highbw_kbps = 4800 * 1024, /* 4.8 GBps */
 	.default_medbw_kbps = 512 * 1024, /* 512 MBps */
 	.default_lowbw_kbps = 0,