arm64: dts: mediatek: mt8183: kukui: Add scp firmware-name

Message ID 20230220093343.3447381-1-hsinyi@chromium.org
State New
Headers
Series arm64: dts: mediatek: mt8183: kukui: Add scp firmware-name |

Commit Message

Hsin-Yi Wang Feb. 20, 2023, 9:33 a.m. UTC
  The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

AngeloGioacchino Del Regno Feb. 20, 2023, 11:08 a.m. UTC | #1
Il 20/02/23 10:33, Hsin-Yi Wang ha scritto:
> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  
Chen-Yu Tsai Feb. 21, 2023, 3:24 a.m. UTC | #2
On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
  
Hsin-Yi Wang May 30, 2023, 5:12 a.m. UTC | #3
On Tue, Feb 21, 2023 at 11:25 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >
> > The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

hi Matthias,

Kindly ping on the patch, thanks!
  
AngeloGioacchino Del Regno May 30, 2023, 7:12 a.m. UTC | #4
Il 30/05/23 07:12, Hsin-Yi Wang ha scritto:
> On Tue, Feb 21, 2023 at 11:25 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
>>
>> On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>>>
>>> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
>>>
>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>
>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> 
> hi Matthias,
> 
> Kindly ping on the patch, thanks!

Agreed. Matthias, please pick this one.

Hsin-Yi, can you also please send a version of this patch for stable?

Thanks,
Angelo
  
Matthias Brugger May 31, 2023, 7:30 a.m. UTC | #5
On 30/05/2023 09:12, AngeloGioacchino Del Regno wrote:
> Il 30/05/23 07:12, Hsin-Yi Wang ha scritto:
>> On Tue, Feb 21, 2023 at 11:25 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
>>>
>>> On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>>>>
>>>> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
>>>>
>>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>>
>>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>>
>> hi Matthias,
>>
>> Kindly ping on the patch, thanks!
> 
> Agreed. Matthias, please pick this one.
> 
> Hsin-Yi, can you also please send a version of this patch for stable?
> 

Applied thanks!
  
Hsin-Yi Wang May 31, 2023, 7:47 a.m. UTC | #6
On Wed, May 31, 2023 at 3:30 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 30/05/2023 09:12, AngeloGioacchino Del Regno wrote:
> > Il 30/05/23 07:12, Hsin-Yi Wang ha scritto:
> >> On Tue, Feb 21, 2023 at 11:25 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> >>>
> >>> On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >>>>
> >>>> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
> >>>>
> >>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> >>>
> >>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> >>
> >> hi Matthias,
> >>
> >> Kindly ping on the patch, thanks!
> >
> > Agreed. Matthias, please pick this one.
> >
> > Hsin-Yi, can you also please send a version of this patch for stable?

I sent a patch based on stable:
https://patchwork.kernel.org/project/linux-mediatek/patch/20230531074421.888652-1-hsinyi@chromium.org/

> >
>
> Applied thanks!

Thanks!
  
Hsin-Yi Wang May 31, 2023, 8:10 a.m. UTC | #7
On Wed, May 31, 2023 at 3:47 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> On Wed, May 31, 2023 at 3:30 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> >
> >
> >
> > On 30/05/2023 09:12, AngeloGioacchino Del Regno wrote:
> > > Il 30/05/23 07:12, Hsin-Yi Wang ha scritto:
> > >> On Tue, Feb 21, 2023 at 11:25 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> > >>>
> > >>> On Mon, Feb 20, 2023 at 5:34 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> > >>>>
> > >>>> The upstream SCP firmware path is /lib/firmware/mediatek/mt8183/scp.img
> > >>>>
> > >>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > >>>
> > >>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> > >>
> > >> hi Matthias,
> > >>
> > >> Kindly ping on the patch, thanks!
> > >
> > > Agreed. Matthias, please pick this one.
> > >
> > > Hsin-Yi, can you also please send a version of this patch for stable?
>
> I sent a patch based on stable:
> https://patchwork.kernel.org/project/linux-mediatek/patch/20230531074421.888652-1-hsinyi@chromium.org/
>

Archived the above patch. I'll wait for the original patch landed then
send it to stable.

> > >
> >
> > Applied thanks!
>
> Thanks!
  

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index fbe14b13051a..8390e89dbc83 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -807,6 +807,8 @@  &pwm0 {
 
 &scp {
 	status = "okay";
+
+	firmware-name = "mediatek/mt8183/scp.img";
 	pinctrl-names = "default";
 	pinctrl-0 = <&scp_pins>;