diff mbox series

[net-next,v1,1/1] dsa: lan9303: Remove stray gpiod_unexport() call

Message ID 20230528142531.38602-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [net-next,v1,1/1] dsa: lan9303: Remove stray gpiod_unexport() call |

Commit Message

Andy Shevchenko May 28, 2023, 2:25 p.m. UTC 
  There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
GPIO sysfs is deprecated. That said, simply drop the stray call.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/dsa/lan9303-core.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Lunn May 29, 2023, 3 p.m. UTC | #1 
On Sun, May 28, 2023 at 05:25:31PM +0300, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org May 30, 2023, 11:20 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sun, 28 May 2023 17:25:31 +0300 you wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/dsa/lan9303-core.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next,v1,1/1] dsa: lan9303: Remove stray gpiod_unexport() call
    https://git.kernel.org/netdev/net-next/c/3ea3c9cff7f9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index cbe831875347..b560e73c14ca 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -1462,7 +1462,6 @@  int lan9303_remove(struct lan9303 *chip)
 
 	/* assert reset to the whole device to prevent it from doing anything */
 	gpiod_set_value_cansleep(chip->reset_gpio, 1);
-	gpiod_unexport(chip->reset_gpio);
 
 	return 0;
 }