Message ID | 20230529073845.2859178-1-guoren@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1340063vqr; Mon, 29 May 2023 00:42:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4MQZWD67r0KgVJDEC/2O9OTYe1G4qHC4b9ROZHBTHlTK7WYxzau1zdZ4Lc3GKgxCQmuncs X-Received: by 2002:a05:6a20:728c:b0:10d:8f40:6454 with SMTP id o12-20020a056a20728c00b0010d8f406454mr8585512pzk.36.1685346126852; Mon, 29 May 2023 00:42:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685346126; cv=none; d=google.com; s=arc-20160816; b=XwqzNM2dgcFZAcjJNmr+Sp2LvzlYejlKXaokyfZStpDhNN6SvFiDpCt7/V3tJY/xz9 5lIEuqy7ZizYwDXkLc9k/CCLEz8pAKt0OWrZr3IlOcj/oglun4AYJGioI48Lr48zQhcT FKdJ36gBoucvA9hSuORJm6P20ZPBguL1lTV9kOjsBcIZZZt1y6K0LjpMngRGOb5TdQD8 sytPQeoMn/evT6IbBTNwRDSuiUhToaJEXvK/u9aw/fWf3Y9XVqZdjzB6NVnq9JlYeIEF 4loeSd1ys0/2f7N+cFhd6643b2R1PEYTNURcnCqpG6hRgV3hdNZ6P1HjBBAcPcZ/1wWO A/Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yM1QFGiCeWcV/9DCqKsn4EaVQJKYsfRuqsOlTJiHY+w=; b=GB1t6Qo6ekEpS0T4KTZfDiKzbv+g7t8wD0uPoJilkeUNFtrv7U/bVUDWN7Dv7DROZQ nCI2o/4iCoNXconJRJTM0CqlwHOX92Q9lzVTdaY+CWks7EeAXMMBGFhgv/p1okLTNCdt VkD4DW2xc9WgpcLIGglk0lxVtqp4fjMouovL4M6RyxWQ0imq6rTBGVDIY7v0F4dLwv5k qbd9guGXw+awVkRq979/0sPG+cIaqQHKTW6hMnkdHRaaEMBpA1Rb1KN+KQ4vNcJ2Tfqi 6O5vkKecaO4hPLOKWtdgDs5lUqMeP0UEcCIWr/uYag1Y3YcdDvmJCfn63LZi/BDXc3hn yWlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SKYzK0tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020a635855000000b0051fb6ca1e69si109183pgm.180.2023.05.29.00.41.54; Mon, 29 May 2023 00:42:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SKYzK0tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230424AbjE2Hi7 (ORCPT <rfc822;callmefire3@gmail.com> + 99 others); Mon, 29 May 2023 03:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbjE2Hi6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 29 May 2023 03:38:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D279AC for <linux-kernel@vger.kernel.org>; Mon, 29 May 2023 00:38:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3946615F7 for <linux-kernel@vger.kernel.org>; Mon, 29 May 2023 07:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C88EC433EF; Mon, 29 May 2023 07:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685345936; bh=2L03bJl1JvE9E9WzzUYTOxEyFHRi8LoxGv46OCU6JGg=; h=From:To:Cc:Subject:Date:From; b=SKYzK0tcInU/JLYLpz78c3bJNrLK2QLdpzE+WFK9GHt1celhAZScPSLWIFJVgwd1l G9+lOlTghfGaZT9Id0/EC+rUy0XsObm+b/treJk76pes14RNSoQ1QHNYGLIObb8tOd tzQi73cnRHq7djsnYoFzd8ZhhJzW2vBhRbPSfsOQ/GUi3qUQkIoowRTQ8KRTnb5SJF 2aRxLsq6sMdOXqE73RvLxDw5RK6IOPaQpwooCc0DkKNMxmVFTR+eAgCjQXU4JnndzG Enve7ntYb4wC6V9aTc0mEtx/9ach7AynwYFY9p/K3i/yMFTt9jm6Izlhc6Xvqk2IK1 7PsX/IvKAvMXQ== From: guoren@kernel.org To: guoren@kernel.org, greentime.hu@sifive.com, vincent.chen@sifive.com, andy.chiu@sifive.com, paul.walmsley@sifive.com, palmer@rivosinc.com Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com> Subject: [PATCH] riscv: vector: Fixup modules compile error Date: Mon, 29 May 2023 03:38:45 -0400 Message-Id: <20230529073845.2859178-1-guoren@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767213499809531635?= X-GMAIL-MSGID: =?utf-8?q?1767213499809531635?= |
Series |
riscv: vector: Fixup modules compile error
|
|
Commit Message
Guo Ren
May 29, 2023, 7:38 a.m. UTC
From: Guo Ren <guoren@linux.alibaba.com> Some .ko also need the riscv_v_user_allowed symbol. ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] undefined! make[3]: *** [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: Module.symvers] Error 1 Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Signed-off-by: Guo Ren <guoren@kernel.org> --- arch/riscv/kernel/vector.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > Some .ko also need the riscv_v_user_allowed symbol. > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > undefined! > make[3]: *** > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > Module.symvers] Error 1 > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > --- > arch/riscv/kernel/vector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > index 1c4ac821e008..3ae08816d608 100644 > --- a/arch/riscv/kernel/vector.c > +++ b/arch/riscv/kernel/vector.c > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > { > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > } > +EXPORT_SYMBOL(riscv_v_user_allowed); Is there a reason that this should not be EXPORT_SYMBOL_GPL()? I figure Andy will roll this into this next revision.. Cheers, Conor.
On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > undefined! > > make[3]: *** > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > Module.symvers] Error 1 > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Signed-off-by: Guo Ren <guoren@kernel.org> > > --- > > arch/riscv/kernel/vector.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > index 1c4ac821e008..3ae08816d608 100644 > > --- a/arch/riscv/kernel/vector.c > > +++ b/arch/riscv/kernel/vector.c > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > { > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > } > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? Good question, but I just follow our arch/riscv habbit, maybe we should change all of that in another patch. ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l 66 ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l 15 > > I figure Andy will roll this into this next revision. > > Cheers, > Conor.
On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > undefined! > > > make[3]: *** > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > Module.symvers] Error 1 > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > --- > > > arch/riscv/kernel/vector.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > index 1c4ac821e008..3ae08816d608 100644 > > > --- a/arch/riscv/kernel/vector.c > > > +++ b/arch/riscv/kernel/vector.c > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > { > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > } > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > Good question, but I just follow our arch/riscv habbit, maybe we > should change all of that in another patch. > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > 66 > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > 15 Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? Seems EXPORT_SYMBOL_GPL has more limitations. :c:func:`EXPORT_SYMBOL_GPL()` ----------------------------- Defined in ``include/linux/export.h`` Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL compatible license. It implies that the function is considered an internal implementation issue, and not really an interface. Some maintainers and developers may however require EXPORT_SYMBOL_GPL() when adding any new APIs or functionality. For kvm is okay: MODULE_AUTHOR("Qumranet"); MODULE_LICENSE("GPL"); So, I would leave the decition to Andy. If he didn't want it used with other non-gpl modules, choose the EXPORT_SYMBOL_GPL. > > > > > I figure Andy will roll this into this next revision. > > > > Cheers, > > Conor. > > > > -- > Best Regards > Guo Ren
On Tue, May 30, 2023 at 2:52 PM Guo Ren <guoren@kernel.org> wrote: > > On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > > undefined! > > > > make[3]: *** > > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > > Module.symvers] Error 1 > > > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > --- > > > > arch/riscv/kernel/vector.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > > index 1c4ac821e008..3ae08816d608 100644 > > > > --- a/arch/riscv/kernel/vector.c > > > > +++ b/arch/riscv/kernel/vector.c > > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > > { > > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > > } > > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > > Good question, but I just follow our arch/riscv habbit, maybe we > > should change all of that in another patch. > > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > > 66 > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > > 15 > > Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? > Seems EXPORT_SYMBOL_GPL has more limitations. > > :c:func:`EXPORT_SYMBOL_GPL()` > ----------------------------- > > Defined in ``include/linux/export.h`` > > Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols > exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by > modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL > compatible license. It implies that the function is considered an > internal implementation issue, and not really an interface. Some > maintainers and developers may however require EXPORT_SYMBOL_GPL() > when adding any new APIs or functionality. > > For kvm is okay: > > MODULE_AUTHOR("Qumranet"); > MODULE_LICENSE("GPL"); > > So, I would leave the decition to Andy. If he didn't want it used with > other non-gpl modules, choose the EXPORT_SYMBOL_GPL. Do you have any use case for exporting this function to non-GPL licensed modules? I exported the function with EXPORT_SYMBOL_GPL() in v20[1] because I thought most maintainers would accept GPL rather than non-GPL one. And it seems most drivers would never call this function anyway. > > > > > > > > > I figure Andy will roll this into this next revision. The fix for this has been included in v20[1]. However, I also changed the function name s/riscv_v_user_allowed/riscv_v_vstate_ctrl_user_allowed/. > > > > > > Cheers, > > > Conor. > > > > > > > > -- > > Best Regards > > Guo Ren > > > > -- > Best Regards > Guo Ren [1]: https://lore.kernel.org/all/20230518161949.11203-21-andy.chiu@sifive.com/ Cheers, Andy
On Tue, May 30, 2023 at 5:49 PM Andy Chiu <andy.chiu@sifive.com> wrote: > > On Tue, May 30, 2023 at 2:52 PM Guo Ren <guoren@kernel.org> wrote: > > > > On Tue, May 30, 2023 at 10:59 AM Guo Ren <guoren@kernel.org> wrote: > > > > > > On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@microchip.com> wrote: > > > > > > > > On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote: > > > > > From: Guo Ren <guoren@linux.alibaba.com> > > > > > > > > > > Some .ko also need the riscv_v_user_allowed symbol. > > > > > > > > > > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko] > > > > > undefined! > > > > > make[3]: *** > > > > > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136: > > > > > Module.symvers] Error 1 > > > > > > > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > > > > Signed-off-by: Guo Ren <guoren@kernel.org> > > > > > --- > > > > > arch/riscv/kernel/vector.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > > > > index 1c4ac821e008..3ae08816d608 100644 > > > > > --- a/arch/riscv/kernel/vector.c > > > > > +++ b/arch/riscv/kernel/vector.c > > > > > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) > > > > > { > > > > > return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; > > > > > } > > > > > +EXPORT_SYMBOL(riscv_v_user_allowed); > > > > > > > > Is there a reason that this should not be EXPORT_SYMBOL_GPL()? > > > Good question, but I just follow our arch/riscv habbit, maybe we > > > should change all of that in another patch. > > > > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL arch/riscv -r | wc -l > > > 66 > > > ➜ linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL arch/riscv -r | wc -l > > > 15 > > > > Why !MODULE_LICENSE(GPL) modules couldn't use riscv_v_user_allowed? > > Seems EXPORT_SYMBOL_GPL has more limitations. > > > > :c:func:`EXPORT_SYMBOL_GPL()` > > ----------------------------- > > > > Defined in ``include/linux/export.h`` > > > > Similar to :c:func:`EXPORT_SYMBOL()` except that the symbols > > exported by :c:func:`EXPORT_SYMBOL_GPL()` can only be seen by > > modules with a :c:func:`MODULE_LICENSE()` that specifies a GPL > > compatible license. It implies that the function is considered an > > internal implementation issue, and not really an interface. Some > > maintainers and developers may however require EXPORT_SYMBOL_GPL() > > when adding any new APIs or functionality. > > > > For kvm is okay: > > > > MODULE_AUTHOR("Qumranet"); > > MODULE_LICENSE("GPL"); > > > > So, I would leave the decition to Andy. If he didn't want it used with > > other non-gpl modules, choose the EXPORT_SYMBOL_GPL. > > Do you have any use case for exporting this function to non-GPL > licensed modules? I exported the function with EXPORT_SYMBOL_GPL() in > v20[1] because I thought most maintainers would accept GPL rather than > non-GPL one. And it seems most drivers would never call this function > anyway. I just found Linux-next build is broken, so I sent the patch. It seems you've solved that. That's okay. > > > > > > > > > > > > > > I figure Andy will roll this into this next revision. > > The fix for this has been included in v20[1]. However, I also changed > the function name > s/riscv_v_user_allowed/riscv_v_vstate_ctrl_user_allowed/. > > > > > > > > > Cheers, > > > > Conor. > > > > > > > > > > > > -- > > > Best Regards > > > Guo Ren > > > > > > > > -- > > Best Regards > > Guo Ren > > [1]: https://lore.kernel.org/all/20230518161949.11203-21-andy.chiu@sifive.com/ > > Cheers, > Andy
On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > I just found Linux-next build is broken, so I sent the patch. It seems > you've solved that. That's okay. Are you sure that linux-next is broken because of this? This series should not be in linux-next...
On Wed, May 31, 2023 at 12:04 AM Conor Dooley <conor@kernel.org> wrote: > > On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > > I just found Linux-next build is broken, so I sent the patch. It seems > > you've solved that. That's okay. > > Are you sure that linux-next is broken because of this? > This series should not be in linux-next... I mean: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/log/?h=for-next
On Wed, May 31, 2023 at 12:14 AM Guo Ren <guoren@kernel.org> wrote: > > On Wed, May 31, 2023 at 12:04 AM Conor Dooley <conor@kernel.org> wrote: > > > > On Tue, May 30, 2023 at 11:37:38PM +0800, Guo Ren wrote: > > > I just found Linux-next build is broken, so I sent the patch. It seems > > > you've solved that. That's okay. > > > > Are you sure that linux-next is broken because of this? > > This series should not be in linux-next... > I mean: > > https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/log/?h=for-next I would change it to +risc-v git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git#for-next next. > > > > -- > Best Regards > Guo Ren
diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c index 1c4ac821e008..3ae08816d608 100644 --- a/arch/riscv/kernel/vector.c +++ b/arch/riscv/kernel/vector.c @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void) { return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON; } +EXPORT_SYMBOL(riscv_v_user_allowed); bool riscv_v_first_use_handler(struct pt_regs *regs) {