RISC-V: Remove redundant printf of abs-run.c
Checks
Commit Message
From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Notice that this testcase cause unexpected fail:
FAIL: gcc.target/riscv/rvv/autovec/unop/abs-run.c (test for excess errors)
Excess errors:
/work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7: warning: implicit declaration of function 'printf' [-Wimplicit-function-declaration]
/work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7: warning: incompatible implicit declaration of built-in function 'printf' [-Wbuiltin-declaration-mismatch]
/work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7: warning: incompatible implicit declaration of built-in function 'printf' [-Wbuiltin-declaration-mismatch]
/work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7: warning: incompatible implicit declaration of built-in function 'printf' [-Wbuiltin-declaration-mismatch]
/work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7: warning: incompatible implicit declaration of built-in function 'printf' [-Wbuiltin-declaration-mismatch]
spawn /work/home/jzzhong/work/rvv-opensource/output/sim/bin/spike --isa=RV64GCVZfh /work/home/jzzhong/work/rvv-opensource/output/sim/riscv64-rivai-elf/bin/pk ./abs-run.exe^M
bbl loader^M^M
0 0 -64^M
1 63 -63^M
2 2 -62^M
3 61 -61^M
4 4 -60^M
5 59 -59^M
6 6 -58^M
7 57 -57^M
8 8 -56^M
9 55 -55^M
10 10 -54^M
11 53 -53^M
12 12 -52^M
13 51 -51^M
Remove printf since it's unnecessary.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/rvv/autovec/unop/abs-run.c: Remove redundant printf.
---
gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c | 1 -
1 file changed, 1 deletion(-)
Comments
Ok
<juzhe.zhong@rivai.ai> 於 2023年5月29日 週一 11:39 寫道:
> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
>
> Notice that this testcase cause unexpected fail:
> FAIL: gcc.target/riscv/rvv/autovec/unop/abs-run.c (test for excess errors)
> Excess errors:
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: implicit declaration of function 'printf'
> [-Wimplicit-function-declaration]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
>
> spawn /work/home/jzzhong/work/rvv-opensource/output/sim/bin/spike
> --isa=RV64GCVZfh
> /work/home/jzzhong/work/rvv-opensource/output/sim/riscv64-rivai-elf/bin/pk
> ./abs-run.exe^M
> bbl loader^M^M
> 0 0 -64^M
> 1 63 -63^M
> 2 2 -62^M
> 3 61 -61^M
> 4 4 -60^M
> 5 59 -59^M
> 6 6 -58^M
> 7 57 -57^M
> 8 8 -56^M
> 9 55 -55^M
> 10 10 -54^M
> 11 53 -53^M
> 12 12 -52^M
> 13 51 -51^M
>
> Remove printf since it's unnecessary.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/rvv/autovec/unop/abs-run.c: Remove redundant
> printf.
>
> ---
> gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> index 7404dbe037e..d864b54229b 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> @@ -19,7 +19,6 @@
> vabs_##TYPE (a##TYPE, a##TYPE, SZ); \
> for (int i = 0; i < SZ; i++) \
> { \
> - printf ("%d %d %d\n", i, a##TYPE[i], i - 64); \
> if (i & 1) \
> assert (a##TYPE[i] == abs (i - 64)); \
> else \
> --
> 2.36.3
>
>
Committed, thanks Kito.
Pan
-----Original Message-----
From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Kito Cheng via Gcc-patches
Sent: Monday, May 29, 2023 11:43 AM
To: 钟居哲 <juzhe.zhong@rivai.ai>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; Kito Cheng <kito.cheng@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>; Palmer Dabbelt <palmer@rivosinc.com>; Jeff Law <jeffreyalaw@gmail.com>; Robin Dapp <rdapp.gcc@gmail.com>
Subject: Re: [PATCH] RISC-V: Remove redundant printf of abs-run.c
Ok
<juzhe.zhong@rivai.ai> 於 2023年5月29日 週一 11:39 寫道:
> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
>
> Notice that this testcase cause unexpected fail:
> FAIL: gcc.target/riscv/rvv/autovec/unop/abs-run.c (test for excess
> errors) Excess errors:
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: implicit declaration of function 'printf'
> [-Wimplicit-function-declaration]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
> /work/home/jzzhong/work/rvv-opensource/software/host/toolchain/gcc/riscv-gcc/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c:22:7:
> warning: incompatible implicit declaration of built-in function 'printf'
> [-Wbuiltin-declaration-mismatch]
>
> spawn /work/home/jzzhong/work/rvv-opensource/output/sim/bin/spike
> --isa=RV64GCVZfh
> /work/home/jzzhong/work/rvv-opensource/output/sim/riscv64-rivai-elf/bi
> n/pk
> ./abs-run.exe^M
> bbl loader^M^M
> 0 0 -64^M
> 1 63 -63^M
> 2 2 -62^M
> 3 61 -61^M
> 4 4 -60^M
> 5 59 -59^M
> 6 6 -58^M
> 7 57 -57^M
> 8 8 -56^M
> 9 55 -55^M
> 10 10 -54^M
> 11 53 -53^M
> 12 12 -52^M
> 13 51 -51^M
>
> Remove printf since it's unnecessary.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/rvv/autovec/unop/abs-run.c: Remove
> redundant printf.
>
> ---
> gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> index 7404dbe037e..d864b54229b 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/unop/abs-run.c
> @@ -19,7 +19,6 @@
> vabs_##TYPE (a##TYPE, a##TYPE, SZ); \
> for (int i = 0; i < SZ; i++) \
> { \
> - printf ("%d %d %d\n", i, a##TYPE[i], i - 64); \
> if (i & 1) \
> assert (a##TYPE[i] == abs (i - 64)); \
> else \
> --
> 2.36.3
>
>
@@ -19,7 +19,6 @@
vabs_##TYPE (a##TYPE, a##TYPE, SZ); \
for (int i = 0; i < SZ; i++) \
{ \
- printf ("%d %d %d\n", i, a##TYPE[i], i - 64); \
if (i & 1) \
assert (a##TYPE[i] == abs (i - 64)); \
else \