Message ID | 20230516105241.30091-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp331503vqo; Tue, 16 May 2023 03:55:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Yuv5kFuqonulmgvqA+yw0u4KUhdwfouiIMGOGYGyWmfUEdiBj1gKDgPgBFjc7K/bWavDK X-Received: by 2002:a05:6a20:7283:b0:102:dd98:509b with SMTP id o3-20020a056a20728300b00102dd98509bmr28737791pzk.21.1684234522546; Tue, 16 May 2023 03:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684234522; cv=none; d=google.com; s=arc-20160816; b=JOqq4VxuN0PVAuIBPRC+d3bHxPBEkIsWTNBbVulw1Zivg+mLENnZ+CUdiFZCgjstTc CdKRzhjUPFgkx7CMciBejjly+3Eq8G8CHnv4SxsJl3q9QP94ZsmLSrWX7/W6u8RpHccY T69S2eXcLxzA6IYXlDRjJ2PTKIcz2v9CxVsrZS/ttE1PH/XZC3vpq1ncOmnPdsRYdP6L LJvw41s2T6HVYlXhp2fnTG9ni0K1hgFTh3HWw7frV1mksU3WvpWNns7jjX8MpFfYQwbd sYqT8meXIdQBNXJo1J+1mthVwRedcTNt27yGFZ04Zrbmjlrbz7MbHNUr0omv+Zxr9GND K/iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9EHv3ysgWqpDvJne4zzetbniLNKwuwcftVNB7lMePiI=; b=utQo34ChDb53TRy6wdxQ0LgErJHRdF03+sqsTiAznGaqYz5qfN0heBvCfo9p+uEsSs Iqd+hwLJ0IZNHnMsh/PviMadoDNHZcrdsj6W1e4NHIIyZo4JezF+ppY3GEesW+kQFcJB lAXY9/CBFrVlULK/m2AzRmGdoLFBlmPgQ3+SwDArxWVRXQmTqubrxcW//QxC2mz/gh1d 5jKTKpvIOnSKF0CLWKyibTix3Atr8k7ZVjuxQdXew7JQ0Yzxb5U3E6Fk8sEGf764WkIm Z5s1qoG/pgLiV5V9HzX/ounp8Rn3i3fYMM6lQ7bGfIQN4aqFXrPN9BW+B3JSKqyWPGEL /17Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yJFrK6Au; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j29-20020a633c1d000000b005137bf7e2d3si17927717pga.582.2023.05.16.03.55.10; Tue, 16 May 2023 03:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yJFrK6Au; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbjEPKwv (ORCPT <rfc822;peekingduck44@gmail.com> + 99 others); Tue, 16 May 2023 06:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232277AbjEPKwu (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 16 May 2023 06:52:50 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3714173D for <linux-kernel@vger.kernel.org>; Tue, 16 May 2023 03:52:47 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-965ddb2093bso2099117966b.2 for <linux-kernel@vger.kernel.org>; Tue, 16 May 2023 03:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684234366; x=1686826366; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9EHv3ysgWqpDvJne4zzetbniLNKwuwcftVNB7lMePiI=; b=yJFrK6Auu1WAYPkKLNAjoCY6y5xTy6C0ggygP803Nt4uVP5fd9LfYcTmvDZrDCEBIe I0lSjd8j061/YMDDxpHsc140w2KOVlUNPFKhkERsu5ByVoz+Ngv5+dvfQoLVm5WsaNBD KqbgwF+AIslhMZWTJCDa02JaWg0UPc3PZ9jK/nos2lUQmFS+9WqEs1KYHwyMNG05f4lo EEY9DUvG54jRGg5XvG53OaA/wsC+MiUfQiSAfmB8nGER5hf/LVvfCpznRP6gS72Da5Z6 q+nQCoLnBs4KGH3UcYfiDkJCZhH60JRGHkioq6mziR5dn3i9UFIVE5a+EH2P57f4ow9/ U00Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684234366; x=1686826366; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9EHv3ysgWqpDvJne4zzetbniLNKwuwcftVNB7lMePiI=; b=Ge7MpCiU1Ub4EY5JKCkxqBIZXzEEUjiX9/F4f1WwagTFzaUtPGjYZgJ1h8/XgUxRyM l6PMEOrndfm3g5SYVNHnH1QHWK79H4qG8k5a05HJVxY095yNIeYAdRH+GyaMrhWZl9Tx Tet7NJnSqh2H1SjLGnQEYQ3cEbK98da/Sgp81DnrRmhd9n/Ltm65ehDjTxRDaeF/A1M4 OsbMjNF+GXilhfJ5gA+q6cglZLIFTUcy0xiyjhM6w0rZi/2VhsCmn1VFpaCXBac080qF kagubJsSEfHvQGUr44DA5M4hjymFDZ5ROUuM2N70MN4UbDoNTyw3jkheIe9Ft8pkARmu eppQ== X-Gm-Message-State: AC+VfDx9FYHpz9SBiFUoTtqCjbUxM5zQwFipumD/7vmadL7b1LT12ubt UQdSfNWrK/zpTOvFw/lHiP9drw== X-Received: by 2002:a17:907:97ce:b0:96a:4bca:8408 with SMTP id js14-20020a17090797ce00b0096a4bca8408mr20224189ejc.60.1684234366295; Tue, 16 May 2023 03:52:46 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:77d1:16a1:abe1:84fc]) by smtp.gmail.com with ESMTPSA id d1-20020a1709067a0100b0096b0e93193asm3679019ejo.90.2023.05.16.03.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 03:52:45 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Bjorn Andersson <andersson@kernel.org>, Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Taniya Das <tdas@codeaurora.org>, Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>, Vinod Koul <vkoul@kernel.org>, "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh@kernel.org> Subject: [PATCH v2 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock Date: Tue, 16 May 2023 12:52:39 +0200 Message-Id: <20230516105241.30091-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766047898628653741?= X-GMAIL-MSGID: =?utf-8?q?1766047898628653741?= |
Series |
[v2,1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock
|
|
Commit Message
Krzysztof Kozlowski
May 16, 2023, 10:52 a.m. UTC
The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") already consumed it on the clock. This fixes warnings like: sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long Fixes: 98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. Re-word commit msg and fixes tag (Konrad) 2. Add tags --- Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Comments
On 16/05/2023 11:52, Krzysztof Kozlowski wrote: > The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom: > gcc: Add global clock controller driver for SM8250") already consumed it > on the clock. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings") > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v2: > 1. Re-word commit msg and fixes tag (Konrad) > 2. Add tags > --- > Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > index b752542ee20c..ead6665b9a45 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > @@ -23,11 +23,13 @@ properties: > clocks: > items: > - description: Board XO source > + - description: Board active XO source > - description: Sleep clock source > > clock-names: > items: > - const: bi_tcxo > + - const: bi_tcxo_ao > - const: sleep_clk > > required: > @@ -47,8 +49,9 @@ examples: > compatible = "qcom,gcc-sm8250"; > reg = <0x00100000 0x1f0000>; > clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > <&sleep_clk>; > - clock-names = "bi_tcxo", "sleep_clk"; > + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>; LGTM Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Tue, 16 May 2023 12:52:39 +0200, Krzysztof Kozlowski wrote: > The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom: > gcc: Add global clock controller driver for SM8250") already consumed it > on the clock. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > > [...] Applied, thanks! [1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock commit: 2310ab77f1ee2611e34345ca1746c9e8aaa5bc31 [2/3] dt-bindings: clock: qcom,gcc-sc7180: document CX power domain commit: 21a95637a3fda45e6d3fd7a57d6ada204e28e484 [3/3] dt-bindings: clock: qcom,gcc-sc7280: document CX power domain commit: 7a52084ae14f49582b0ce19106cdad094499e204 Best regards,
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml index b752542ee20c..ead6665b9a45 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml @@ -23,11 +23,13 @@ properties: clocks: items: - description: Board XO source + - description: Board active XO source - description: Sleep clock source clock-names: items: - const: bi_tcxo + - const: bi_tcxo_ao - const: sleep_clk required: @@ -47,8 +49,9 @@ examples: compatible = "qcom,gcc-sm8250"; reg = <0x00100000 0x1f0000>; clocks = <&rpmhcc RPMH_CXO_CLK>, + <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>; - clock-names = "bi_tcxo", "sleep_clk"; + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;