diff mbox series

dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property

Message ID 1667448757-7001-1-git-send-email-radhey.shyam.pandey@amd.com
State New
Headers
Series dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property |

Commit Message

Pandey, Radhey Shyam Nov. 3, 2022, 4:12 a.m. UTC 
  xlnx,bus-width is a required property. In yaml conversion somehow
it got missed out. Bring it back and mention it in required list.
Also add Harini and myself to the maintainer list.

Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml    | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Comments

Peter Korsgaard Nov. 3, 2022, 7:02 a.m. UTC | #1 
>>>>> "Radhey" == Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> writes:

 > xlnx,bus-width is a required property. In yaml conversion somehow
 > it got missed out. Bring it back and mention it in required list.
 > Also add Harini and myself to the maintainer list.

 > Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
 > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
 > ---
 >  .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml    | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > index c0a1408b12ec..a10019d3a650 100644
 > --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > @@ -13,6 +13,8 @@ description: |
 
 >  maintainers:
 >    - Michael Tretter <m.tretter@pengutronix.de>
 > +  - Harini Katakam <harini.katakam@amd.com>
 > +  - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

That should ideally be in a separate patch.


 >  allOf:
 >    - $ref: "../dma-controller.yaml#"
 > @@ -65,6 +67,7 @@ required:
 >    - interrupts
 >    - clocks
 >    - clock-names
 > +  - xlnx,bus-width

Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Krzysztof Kozlowski Nov. 3, 2022, 1:20 p.m. UTC | #2 
On 03/11/2022 00:12, Radhey Shyam Pandey wrote:
> xlnx,bus-width is a required property. In yaml conversion somehow
> it got missed out. Bring it back and mention it in required list.
> Also add Harini and myself to the maintainer list.
> 
> Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Michael Tretter Nov. 3, 2022, 1:39 p.m. UTC | #3 
On Thu, 03 Nov 2022 09:42:37 +0530, Radhey Shyam Pandey wrote:
> xlnx,bus-width is a required property. In yaml conversion somehow
> it got missed out. Bring it back and mention it in required list.
> Also add Harini and myself to the maintainer list.
> 
> Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

> ---
>  .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml    | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index c0a1408b12ec..a10019d3a650 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> @@ -13,6 +13,8 @@ description: |
>  
>  maintainers:
>    - Michael Tretter <m.tretter@pengutronix.de>
> +  - Harini Katakam <harini.katakam@amd.com>
> +  - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>  
>  allOf:
>    - $ref: "../dma-controller.yaml#"
> @@ -65,6 +67,7 @@ required:
>    - interrupts
>    - clocks
>    - clock-names
> +  - xlnx,bus-width
>  
>  additionalProperties: false
>  
> 
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> -- 
> 2.25.1
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
index c0a1408b12ec..a10019d3a650 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
+++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
@@ -13,6 +13,8 @@  description: |
 
 maintainers:
   - Michael Tretter <m.tretter@pengutronix.de>
+  - Harini Katakam <harini.katakam@amd.com>
+  - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
 
 allOf:
   - $ref: "../dma-controller.yaml#"
@@ -65,6 +67,7 @@  required:
   - interrupts
   - clocks
   - clock-names
+  - xlnx,bus-width
 
 additionalProperties: false