Message ID | 20221103013510.3062-1-zeming@nfschina.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp259057wru; Wed, 2 Nov 2022 18:49:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7o8bph/ExpBe/Sk/L5U5PdJZ14hJT26iB1brObmcTxoWz2LRNuqB2nau4vhBhZhL5OSScN X-Received: by 2002:a17:906:371a:b0:7ad:c01c:6fa0 with SMTP id d26-20020a170906371a00b007adc01c6fa0mr22031229ejc.267.1667440185824; Wed, 02 Nov 2022 18:49:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667440185; cv=none; d=google.com; s=arc-20160816; b=ayAAXZaLOWiKOK8wpMEidRPTNKt2+yra8Y0ffD2I2kaQMIyN0S/ycCu0xSXn04gcEd LP9uSuvHIuDz9A7gQRJr2Xq3PGI4IGsijmuOPzBk4x3B33huGbdiFfGBAmhF8/G7U13u BlH1124pvztcP2TwltzMb9TMAubW3Lf4J1/KuvaD828cqhp193BaQZV7+bL0dOzIcPUK bYykF73Y/nOIKnb8t+1SI2Ec3cJQF2a2LJjNCBW61YSfNdErF99H+dQx/WNZ/cLl2Vtb Jr0m70wNU0sBnkTxD41UAP24Jf2gp/LiOJ5aw8GlFPeUcSft81yiTd4EpYQWfunMx0lI vnLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=TJVP/INg0dAge77Tr9cV8pMCB6q5uaRh+Tw3NV8nI04=; b=yiYKqrZFOG1T5bxjTnZEvPaa81V2OUEUvDhvsJNxpQEO380fDFLYWsFYenKiBfkIK4 JQOttd4HHZbEWbHTTWIammRlT8OGFKHSza7pJOxblUq6CtFVZkKB19+uZzRMJQwCHg00 a6g7hnQAtOmzv954dpFXpunSTdlNILCHvJllJVnq7tyPdJ+KeznM8FSgPEkttWDfPnta mkyhkTvp9YyVyJFzRx+0zar86AJd8eQ+HZf3FRwepWfKiCO/8hdNS4dB2XY/5/SSEFEu t4hOkkokJe4R8vqEVTlMLPhMqUTtujehy0JOKk+WV8pGMpZ5m7zyBSEdGTkx34BWBUsc NbwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt41-20020a1709072da900b0078d2a84f2f8si21550586ejc.645.2022.11.02.18.49.19; Wed, 02 Nov 2022 18:49:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbiKCBfY (ORCPT <rfc822;yves.mi.zy@gmail.com> + 99 others); Wed, 2 Nov 2022 21:35:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiKCBfW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 2 Nov 2022 21:35:22 -0400 Received: from mail.nfschina.com (unknown [124.16.136.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E72EA60FF; Wed, 2 Nov 2022 18:35:21 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 550361E80D1A; Thu, 3 Nov 2022 09:33:19 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HAREzzNqmZJH; Thu, 3 Nov 2022 09:33:16 +0800 (CST) Received: from localhost.localdomain (unknown [219.141.250.2]) (Authenticated sender: zeming@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 8E2B81E80CEE; Thu, 3 Nov 2022 09:33:16 +0800 (CST) From: Li zeming <zeming@nfschina.com> To: chuck.lever@oracle.com, jlayton@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com> Subject: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions Date: Thu, 3 Nov 2022 09:35:10 +0800 Message-Id: <20221103013510.3062-1-zeming@nfschina.com> X-Mailer: git-send-email 2.18.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748437759889465675?= X-GMAIL-MSGID: =?utf-8?q?1748437759889465675?= |
Series |
sunrpc: svc: Remove unnecessary (void*) conversions
|
|
Commit Message
Li zeming
Nov. 3, 2022, 1:35 a.m. UTC
The iov_base pointer does not need to cast the type.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
include/linux/sunrpc/svc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote: > The iov_base pointer does not need to cast the type. > > Signed-off-by: Li zeming <zeming@nfschina.com> > --- > include/linux/sunrpc/svc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h > index daecb009c05b..4b0eead91c94 100644 > --- a/include/linux/sunrpc/svc.h > +++ b/include/linux/sunrpc/svc.h > @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov) > > static inline void svc_ungetu32(struct kvec *iov) > { > - __be32 *vp = (__be32 *)iov->iov_base; > + __be32 *vp = iov->iov_base; > iov->iov_base = (void *)(vp - 1); > iov->iov_len += sizeof(*vp); > } Reviewed-by: Jeff Layton <jlayton@kernel.org>
On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote: > The iov_base pointer does not need to cast the type. > > Signed-off-by: Li zeming <zeming@nfschina.com> > --- > include/linux/sunrpc/svc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h > index daecb009c05b..4b0eead91c94 100644 > --- a/include/linux/sunrpc/svc.h > +++ b/include/linux/sunrpc/svc.h > @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov) > > static inline void svc_ungetu32(struct kvec *iov) > { > - __be32 *vp = (__be32 *)iov->iov_base; > + __be32 *vp = iov->iov_base; > iov->iov_base = (void *)(vp - 1); > iov->iov_len += sizeof(*vp); > } If you're going to submit a patch just in order to strip unnecessary casts, then why are you leaving the equally unnecessary cast in the next line? That said, why waste time "fixing" an inlined function that is not actually called anywhere in the kernel? svc_ungetu32() should just be removed.
> On Nov 3, 2022, at 8:49 AM, Trond Myklebust <trondmy@kernel.org> wrote: > > On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote: >> The iov_base pointer does not need to cast the type. >> >> Signed-off-by: Li zeming <zeming@nfschina.com> >> --- >> include/linux/sunrpc/svc.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h >> index daecb009c05b..4b0eead91c94 100644 >> --- a/include/linux/sunrpc/svc.h >> +++ b/include/linux/sunrpc/svc.h >> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov) >> >> static inline void svc_ungetu32(struct kvec *iov) >> { >> - __be32 *vp = (__be32 *)iov->iov_base; >> + __be32 *vp = iov->iov_base; >> iov->iov_base = (void *)(vp - 1); >> iov->iov_len += sizeof(*vp); >> } > > If you're going to submit a patch just in order to strip unnecessary > casts, then why are you leaving the equally unnecessary cast in the > next line? > > That said, why waste time "fixing" an inlined function that is not > actually called anywhere in the kernel? svc_ungetu32() should just be > removed. Sorry for the delay, I was expecting an electrical service outage here at home yesterday, so the lab was powered off. So, Li, can you drop this one, and instead send a patch that removes the definition of svc_ungetu32 ? -- Chuck Lever
of course, I will submit a new one to delete the static svc_ungetu32() function for Patch.
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h index daecb009c05b..4b0eead91c94 100644 --- a/include/linux/sunrpc/svc.h +++ b/include/linux/sunrpc/svc.h @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov) static inline void svc_ungetu32(struct kvec *iov) { - __be32 *vp = (__be32 *)iov->iov_base; + __be32 *vp = iov->iov_base; iov->iov_base = (void *)(vp - 1); iov->iov_len += sizeof(*vp); }