Message ID | 20230418143854.8vHWQKLM@linutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2911758vqo; Tue, 18 Apr 2023 07:53:14 -0700 (PDT) X-Google-Smtp-Source: AKy350ZvqOVTT+MVyNY6Lw/qVDzSJTsWxJm6wMrapIzEWzHCxocrTNNB7fhulNbNOE44HoXVYJWY X-Received: by 2002:a17:90b:1e53:b0:244:9227:5eca with SMTP id pi19-20020a17090b1e5300b0024492275ecamr1901593pjb.49.1681829594652; Tue, 18 Apr 2023 07:53:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681829594; cv=none; d=google.com; s=arc-20160816; b=zGQYcaYTGxuJOvTNJ3XgtSurNNuQxCTA7288ZN2VeJbe+HMSrS67fPfHtE81uDoYYs aYG89TLdLOeMYbYfi94M9MedbPeZe9JJKKMB/wsiT+eqwVLW0oygfvtdEtYIg4rlgYWb 5A53w39h4NRHflp9iIM6UZ0z1ZvEfmBljfzDDPmr5Yt1crVOa5EL61f5ib32WBCNqnx7 DwGOu/MOh7pda/AnpUtpgZeGADbzL7MclEv6KzPZ4XkGS6W2Xp2cVC28bw6cPFIxX4t1 TlbUpmCTHlA4kT58oUKzlK8UIxmCaYO6uCQFIk/oPflwDvo2S2U3zSA4JaugudHqsofB bMew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:dkim-signature:dkim-signature:date; bh=HDWs2ddjtNGHMlnGV0ZEvDXQY8w3gDQpVYK7AV0UPeM=; b=cg0/UxhnlHlac2rG3ztJ4EPZjbeT87Qwn2vCAJYRoG9YEp25GfEhuK65XoLC+jGROG EUgHlfQhl5yu3NaIJvIMIc8dEcwgSTYVOyyM1KIpzG8KU3K+012vmabFYNlZEC2vyHSM BS7SOWE0yFE2+S7tBYCVEdrOiZ6GGInymz+roCC43sBxb27m4EArscnnNpgWAnL1hIpI fA3dil4qh9pWWk+LnXJtJ8wSNuzf95T+EE/zpzOzdfjwPEDtENwW6XKXJq5W6iU9h6N8 9WCncKy9dkDoE66CeA/SwoFD73YKsiQxAYQ4yMPxxfN2ShYvZnmG4uUvuHKkn8h5XDBe 544A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NBZYVBat; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc7-20020a17090b318700b002474ddc6a90si9478201pjb.125.2023.04.18.07.53.02; Tue, 18 Apr 2023 07:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NBZYVBat; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbjDROi7 (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Tue, 18 Apr 2023 10:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjDROi6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 10:38:58 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F317A448E; Tue, 18 Apr 2023 07:38:56 -0700 (PDT) Date: Tue, 18 Apr 2023 16:38:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681828735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=HDWs2ddjtNGHMlnGV0ZEvDXQY8w3gDQpVYK7AV0UPeM=; b=NBZYVBatqhtjwKHQ5vPt8VNVjpzPLJWQ5ocxzLNpS5CvbX88osqVD1IlNnnOUo8Y4oRHM8 VxV3qlpujjYbTOxbY0ukfx0ub9H6bXxbV4sWxNKZWcxwbDqMKsT1miEtNSDV+o7+zinIc+ xIYAElLGGaKXjQoimk5dcROOT5iE1bU+bBB9WYds13aAxhujX8oDGPQwJ5XzGT2D079ZcN bmB92Ah5XFiaV3PvkASobNMA9ZqWBmpFbaCBibuUQTdG7K04dbEgjIl4csZIAYf8j36KcD P1a8klNLECKDajx2yaQbncfIKMQCsY4V25v6aqJHgwPBHj5vqjd0+sYYE7wrSA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681828735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=HDWs2ddjtNGHMlnGV0ZEvDXQY8w3gDQpVYK7AV0UPeM=; b=1a7Le/7KspJHQ+qTPfNPzGWYt1DvHAOu29Huc/FQm6XkCacKlPN60IZyZ9j4qc1SlXKNOj whrW4glXW0Bcd7Aw== From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, Thomas Gleixner <tglx@linutronix.de> Subject: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode(). Message-ID: <20230418143854.8vHWQKLM@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763526149150430279?= X-GMAIL-MSGID: =?utf-8?q?1763526149150430279?= |
Series |
tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
|
|
Commit Message
Sebastian Andrzej Siewior
April 18, 2023, 2:38 p.m. UTC
The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
since these modes are not decoded. The author was not aware of the fancy
decoding function which makes the life easier.
Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
modes.
Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/trace/events/timer.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote: > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > since these modes are not decoded. The author was not aware of the fancy > decoding function which makes the life easier. > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > modes. > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Good catch. Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -Mukesh > --- > include/trace/events/timer.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h > index 2e713a7d9aa3a..5d43751a766c6 100644 > --- a/include/trace/events/timer.h > +++ b/include/trace/events/timer.h > @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel, > { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \ > { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \ > { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \ > - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }) > + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \ > + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \ > + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \ > + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \ > + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" }) > > /** > * hrtimer_init - called when the hrtimer is initialized
On Tue, 18 Apr 2023 16:38:54 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > since these modes are not decoded. The author was not aware of the fancy > decoding function which makes the life easier. > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > modes. > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve
On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote: > On Tue, 18 Apr 2023 16:38:54 +0200 > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > > since these modes are not decoded. The author was not aware of the fancy > > decoding function which makes the life easier. > > > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > > modes. > > > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> Could this be either routed via the tracing tree or the tip tree but please route this :) Sebastian
On Wed, 24 May 2023 17:39:28 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > On 2023-04-24 17:44:41 [-0400], Steven Rostedt wrote: > > On Tue, 18 Apr 2023 16:38:54 +0200 > > Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > > > > The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number > > > since these modes are not decoded. The author was not aware of the fancy > > > decoding function which makes the life easier. > > > > > > Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD > > > modes. > > > > > > Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode") > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > > > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> > > Could this be either routed via the tracing tree or the tip tree but > please route this :) > Events are normally owned by the subsystem they are used in. So it should go through tip. But if I get an ack from the subsystem maintainer, I can route it through tracing. -- Steve
On Wed, 24 May 2023 20:25:26 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > Events are normally owned by the subsystem they are used in. So it > should go through tip. But if I get an ack from the subsystem > maintainer, I can route it through tracing. Thomas, care to give me an ack? Or do you want to take it? -- Steve
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h index 2e713a7d9aa3a..5d43751a766c6 100644 --- a/include/trace/events/timer.h +++ b/include/trace/events/timer.h @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel, { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \ { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \ { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \ - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }) + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \ + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \ + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \ + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \ + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" }) /** * hrtimer_init - called when the hrtimer is initialized