Message ID | 20230523100958.340512-1-juzhe.zhong@rivai.ai |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2025561vqo; Tue, 23 May 2023 03:12:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7S4/4vO6pwWG1yyaH10sGL22J+IUoWCRFdKdUHMoMbxDPeypXrmt8YPhQd/+2yGAAEIIQU X-Received: by 2002:a17:906:d555:b0:94f:3074:14fe with SMTP id cr21-20020a170906d55500b0094f307414femr12192319ejc.17.1684836721371; Tue, 23 May 2023 03:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684836721; cv=none; d=google.com; s=arc-20160816; b=h+fgF8k1NI6NfhIN7g8S+FsIidlvlrVnu+ru98GoZPJxh7mIACY2m7zMpeVczkEI7b IecS4moffsyJCU4WhnwugiOrLS3TmaBC+pzUwr+C6OlXAdVoqzFJZs9Kd3Q/aJJqluYj THe/gixfaRh/c9jPdcwesdphy/pJe8G939tu4qC47HigRrS8M0EnFY4c5iX0USx2IFxJ MY8hTQjZDjHGSh1V/7SFNn/4Ldqrzj7L8ns5D+lzMA+qgV/LPnRGJ8z3N11GQXwDQKk3 8B5g6hQnBUkmZISzDaFr/hIqJGjlK2xvazKr2MkEV4/dN0veFsAnVoUhFtWbQpbmHKyN bo5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=XQ7/4Lu/1rPqGuQ0cfyJmHPDpSAEcq3uFR2Ph91vbz8=; b=e02ffId339zYa8JBDIV36j/659ahAo0EmH3DEl+UdLxl5D1CEHU43JpJ/1zjroCws0 H64L03Tzd812nz0XXPbylXUGozK0s9NiMHJuUtWPkQfF3Eca5UkPn/Xez2C6zx6dBu2C 8iO9uaOLSNrzcEJH28u5vebZPv6i7cHFM7qeAD24nY61Y2xg8ZMiurlJq+8lxcrno9Y5 3YctK/FT9bsLbqFnnpai13lyscdKIHARz9P4UPX8UnXJd2rgtb83GBHrx/f1MtVwGyhR c9VwsKhNNcwkUM6t8wflqw6kYCsQP7sfOAYU54Pj2IgzsAMvTlI3YNpPrWJAOF5+P0+3 Fk8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id gs14-20020a170906f18e00b00965cf8f1be1si595840ejb.617.2023.05.23.03.12.01 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 03:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1057A385802F for <ouuuleilei@gmail.com>; Tue, 23 May 2023 10:11:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) by sourceware.org (Postfix) with ESMTPS id 5DFA93858C27 for <gcc-patches@gcc.gnu.org>; Tue, 23 May 2023 10:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DFA93858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp79t1684836600t8zrx6ii Received: from rios-cad5.localdomain ( [58.60.1.11]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 May 2023 18:09:59 +0800 (CST) X-QQ-SSF: 01400000000000F0R000000A0000000 X-QQ-FEAT: 7YFKcddXagjNWgleLaYcQ5ek5O3ZZ4QTKErRieRb76to++n9Zl8MaI8vFTuKz +u1+hWIXObaUwe545RJFAsdc8U7OGOa1sI5w7ItzPMWZKUScuK+Tic2jz6Iom1DCM6s7++2 n9t1bhzn59F3qOWfCPd3ZWf8U5l9ukiiKyTQAbWk6POPOtClWopKDjc8M5z4FKxro0NG35s 7K81znQKZDiXj3hi7FJ8c2rHLeoMjxaDrgAGTO1TqQpUcnvSvByP9jZVLhzyM4vrGvt++LU h2E6woULYpAAEFDRkGecl/e/xZoC6J5nbHBzbr1nNQRWbOUPK/C/zC/rjztVKRfye5eF0uc 5Ni7Hql7I9dcNdmd5Rauy5jRWJ22zBLJuI8GVrHzSM/H5fsH5XtDtidBTcDxHYZDgfM+XBU DB/97DZXIXg= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 8508083255586100953 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, Juzhe-Zhong <juzhe.zhong@rivai.ai> Subject: [PATCH] RISC-V: Fix warning of vxrm pattern Date: Tue, 23 May 2023 18:09:58 +0800 Message-Id: <20230523100958.340512-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766679350042994643?= X-GMAIL-MSGID: =?utf-8?q?1766679350042994643?= |
Series |
RISC-V: Fix warning of vxrm pattern
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
juzhe.zhong@rivai.ai
May 23, 2023, 10:09 a.m. UTC
From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
I just notice the warning:
../../../riscv-gcc/gcc/config/riscv/vector.md:618:1: warning: source missing a mode?
gcc/ChangeLog:
* config/riscv/vector.md: Add mode.
---
gcc/config/riscv/vector.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 5/23/23 04:09, juzhe.zhong@rivai.ai wrote: > From: Juzhe-Zhong <juzhe.zhong@rivai.ai> > > I just notice the warning: > ../../../riscv-gcc/gcc/config/riscv/vector.md:618:1: warning: source missing a mode? > > gcc/ChangeLog: > > * config/riscv/vector.md: Add mode. While I'm a big fan of the gen* warnings, I do wish they had a bit more smarts to avoid the missing mode warnings for arguments which are restricted to CONST_INTs which don't have modes. Oh well. OK for the trunk. jeff
Committed, thanks Jeff. Pan -----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Jeff Law via Gcc-patches Sent: Tuesday, May 23, 2023 9:43 PM To: juzhe.zhong@rivai.ai; gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com; kito.cheng@sifive.com; palmer@dabbelt.com; palmer@rivosinc.com; rdapp.gcc@gmail.com Subject: Re: [PATCH] RISC-V: Fix warning of vxrm pattern On 5/23/23 04:09, juzhe.zhong@rivai.ai wrote: > From: Juzhe-Zhong <juzhe.zhong@rivai.ai> > > I just notice the warning: > ../../../riscv-gcc/gcc/config/riscv/vector.md:618:1: warning: source missing a mode? > > gcc/ChangeLog: > > * config/riscv/vector.md: Add mode. While I'm a big fan of the gen* warnings, I do wish they had a bit more smarts to avoid the missing mode warnings for arguments which are restricted to CONST_INTs which don't have modes. Oh well. OK for the trunk. jeff
diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md index ac244430970..13b94862693 100644 --- a/gcc/config/riscv/vector.md +++ b/gcc/config/riscv/vector.md @@ -617,7 +617,7 @@ ;; Set VXRM (define_insn "vxrmsi" [(set (reg:SI VXRM_REGNUM) - (match_operand 0 "const_int_operand" "i"))] + (match_operand:SI 0 "const_int_operand" "i"))] "TARGET_VECTOR" "csrwi\tvxrm,%0" [(set_attr "type" "wrvxrm")