diff mbox series

sunrpc: svc: Remove unnecessary (void*) conversions

Message ID 20221103013510.3062-1-zeming@nfschina.com
State New
Headers
Series sunrpc: svc: Remove unnecessary (void*) conversions |

Commit Message

Li zeming Nov. 3, 2022, 1:35 a.m. UTC 
  The iov_base pointer does not need to cast the type.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 include/linux/sunrpc/svc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Layton Nov. 3, 2022, 9:43 a.m. UTC | #1 
On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  include/linux/sunrpc/svc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>  
>  static inline void svc_ungetu32(struct kvec *iov)
>  {
> -	__be32 *vp = (__be32 *)iov->iov_base;
> +	__be32 *vp = iov->iov_base;
>  	iov->iov_base = (void *)(vp - 1);
>  	iov->iov_len += sizeof(*vp);
>  }

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Trond Myklebust Nov. 3, 2022, 12:49 p.m. UTC | #2 
On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  include/linux/sunrpc/svc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>  
>  static inline void svc_ungetu32(struct kvec *iov)
>  {
> -       __be32 *vp = (__be32 *)iov->iov_base;
> +       __be32 *vp = iov->iov_base;
>         iov->iov_base = (void *)(vp - 1);
>         iov->iov_len += sizeof(*vp);
>  }

If you're going to submit a patch just in order to strip unnecessary
casts, then why are you leaving the equally unnecessary cast in the
next line?

That said, why waste time "fixing" an inlined function that is not
actually called anywhere in the kernel? svc_ungetu32() should just be
removed.
Chuck Lever Nov. 3, 2022, 1:07 p.m. UTC | #3 
> On Nov 3, 2022, at 8:49 AM, Trond Myklebust <trondmy@kernel.org> wrote:
> 
> On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
>> The iov_base pointer does not need to cast the type.
>> 
>> Signed-off-by: Li zeming <zeming@nfschina.com>
>> ---
>>  include/linux/sunrpc/svc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
>> index daecb009c05b..4b0eead91c94 100644
>> --- a/include/linux/sunrpc/svc.h
>> +++ b/include/linux/sunrpc/svc.h
>> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>>  
>>  static inline void svc_ungetu32(struct kvec *iov)
>>  {
>> -       __be32 *vp = (__be32 *)iov->iov_base;
>> +       __be32 *vp = iov->iov_base;
>>         iov->iov_base = (void *)(vp - 1);
>>         iov->iov_len += sizeof(*vp);
>>  }
> 
> If you're going to submit a patch just in order to strip unnecessary
> casts, then why are you leaving the equally unnecessary cast in the
> next line?
> 
> That said, why waste time "fixing" an inlined function that is not
> actually called anywhere in the kernel? svc_ungetu32() should just be
> removed.

Sorry for the delay, I was expecting an electrical service outage
here at home yesterday, so the lab was powered off.

So, Li, can you drop this one, and instead send a patch that removes
the definition of svc_ungetu32 ?


--
Chuck Lever
Li zeming Nov. 4, 2022, 1:02 a.m. UTC | #4 
of course, I will submit a new one to delete the static svc_ungetu32() function for Patch.
diff mbox series

Patch

diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index daecb009c05b..4b0eead91c94 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -222,7 +222,7 @@  static inline __be32 svc_getu32(struct kvec *iov)
 
 static inline void svc_ungetu32(struct kvec *iov)
 {
-	__be32 *vp = (__be32 *)iov->iov_base;
+	__be32 *vp = iov->iov_base;
 	iov->iov_base = (void *)(vp - 1);
 	iov->iov_len += sizeof(*vp);
 }