Message ID | 20230405-add-dsc-support-v4-1-15daf84f8dcb@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1712320vqo; Mon, 22 May 2023 13:53:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ777pXq0+QbFxUFeFp4+3Le2UYcKGvl99lVO2hka/IUK49qF8WD9Gp1fCTLAFiRLThg3IB9 X-Received: by 2002:a05:6a20:2445:b0:100:c4f1:72a0 with SMTP id t5-20020a056a20244500b00100c4f172a0mr13326124pzc.3.1684788815292; Mon, 22 May 2023 13:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684788815; cv=none; d=google.com; s=arc-20160816; b=huCR2bpHPCSmNJPSC1gcyHrdKp9uw/2Rf//jYYUo4JJyhmE92ofYdq1nvrWfPhNHOr GbS0NpKVqoF5HH75Du2IoTeDsFoIVbsjhqySXXcg/HeJIb09CP4qq38dZf2OjBvhnqx1 j3jY/xgbzG0u2vAB8Ywr/0j170YT5pW4OY5yJbOQNMDE7Q7eNN2rLMSUa1sQoDrGjYiH T39+ehVCwfJVaItJusKhl2zHwv904gGEWs6QfJFoGpSdRXqgCLZ07k/BkiBINXZqN6BM lUO8a8lfZFvfwaejtYrSMrOGr7GDaIOpg7YjVUwOpU5iaXR8wameCn9BBMaxQo/vUME2 YN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=20fUdjKb0L5Q6fUK1/+acIicb3euvbBfhny9y9fPK+I=; b=JdoJDfkixqwCzxRr4gRgSrSTo9ZQo5VYq2B/TwoNjeUFReUuGETTbPDkqvXRO1si1T bNOT0KV6ZgfP57wJocehdlBPNf0JdM/idWn9WrOCk4FDTTyi/iXJBAXKqQU0HBVJxVkx 0d+ZJ3uzkKJjbIZ2eY8hsYnkA3yS+vZWJh1nEvRo6x5JYjx2XuCYGLsI0tkryeTq8tns 43SSmMTFcL4bVOlLFR3khqYRk4nhVTAUwWwTNDj8HNFRXb4383ln93U3fTKog6XRcoSd GnYzCNhTrfxSWrCcsGU67nH1uZ2AxyrFdkbo5luzyn0IGd0U/dar3iqN2OLcWVTo1yPj SYsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CLIri8d5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c65-20020a633544000000b005308ce5382dsi641468pga.861.2023.05.22.13.53.23; Mon, 22 May 2023 13:53:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CLIri8d5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233643AbjEVUbM (ORCPT <rfc822;wlfightup@gmail.com> + 99 others); Mon, 22 May 2023 16:31:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232946AbjEVUar (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 22 May 2023 16:30:47 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29FB7BB; Mon, 22 May 2023 13:30:46 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34MKBj9c028605; Mon, 22 May 2023 20:30:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : references : in-reply-to : to : cc; s=qcppdkim1; bh=20fUdjKb0L5Q6fUK1/+acIicb3euvbBfhny9y9fPK+I=; b=CLIri8d5ELKwY8npXFtXnEbkGAXohxF5KrpSnVvweLSw+1h+ombPhLRmg87AprDZyekP NBpaVgmkhYAuxjYZvQuAqsg6gRdNbC97hHqTTDpM5bQ6mRrzbqSFSv648GB3H0IHMqBC hYYvsRDOg8w0uKVyD7vRqzz+lHJXLdAMJj4tzhY7gEprC1vCmdoomL74/UgEOaf5psWd rZUrL+E32obr8tg5ykkQhpfvod9dUi2HHrRfo+1qcBPaZAatWJlzRzgpeGecNXMevuNv nA4lMW+voO5kT/v8DMm7mLqQlJx/PtwrKL35SypqS2nyM+feBq1HaH01EILOMV5aLohu YA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qrf7780u8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 May 2023 20:30:40 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34MKUdKq032333 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 May 2023 20:30:39 GMT Received: from jesszhan-linux.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 22 May 2023 13:30:38 -0700 From: Jessica Zhang <quic_jesszhan@quicinc.com> Date: Mon, 22 May 2023 13:30:20 -0700 Subject: [PATCH v4 1/5] msm/drm/dsi: Round up DSC hdisplay calculation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20230405-add-dsc-support-v4-1-15daf84f8dcb@quicinc.com> References: <20230405-add-dsc-support-v4-0-15daf84f8dcb@quicinc.com> In-Reply-To: <20230405-add-dsc-support-v4-0-15daf84f8dcb@quicinc.com> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Marijn Suijten <marijn.suijten@somainline.org> CC: Konrad Dybcio <konrad.dybcio@linaro.org>, <linux-arm-msm@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, <freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>, Jessica Zhang <quic_jesszhan@quicinc.com> X-Mailer: b4 0.13-dev-bfdf5 X-Developer-Signature: v=1; a=ed25519-sha256; t=1684787438; l=1159; i=quic_jesszhan@quicinc.com; s=20230329; h=from:subject:message-id; bh=O4fwebqw0hZk0HtxPHrQdfcePbHGcCiry7MxFu+pVeQ=; b=Y03jQ54j5G4jD5FzIJx2BSh5ipYUTVQlBmsaQjieawffFKtNBR1tw3SW1dFRNYlQpj3/dmDkK 5Bg1S2f59o7C9vm+0aMskdUDgKNKX9Qlq9SKrXIHmz75VpMibXhspn7 X-Developer-Key: i=quic_jesszhan@quicinc.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: aT2v6_vs8CMrDNTlc8_R9Gr9zbja4ldo X-Proofpoint-ORIG-GUID: aT2v6_vs8CMrDNTlc8_R9Gr9zbja4ldo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-22_14,2023-05-22_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305220173 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766629116471815357?= X-GMAIL-MSGID: =?utf-8?q?1766629116471815357?= |
Series |
Add DSC v1.2 Support for DSI
|
|
Commit Message
Jessica Zhang
May 22, 2023, 8:30 p.m. UTC
Currently, when compression is enabled, hdisplay is reduced via integer division. This causes issues for modes where the original hdisplay is not a multiple of 3. To fix this, use DIV_ROUND_UP to divide hdisplay. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2023-05-22 13:30:20, Jessica Zhang wrote: > Currently, when compression is enabled, hdisplay is reduced via integer > division. This causes issues for modes where the original hdisplay is > not a multiple of 3. > > To fix this, use DIV_ROUND_UP to divide hdisplay. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> Nit: probably these should go in the opposite order. And if they're all supposed to be chronological, I think it is: Suggested-by: Fixes: Signed-off-by: Reviewed-by: But unsure if that's a hard requirement, or even correct at all. - Marijn > Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 9223d7ec5a73..18d38b90eb28 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) > * pulse width same > */ > h_total -= hdisplay; > - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; > + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); > h_total += hdisplay; > ha_end = ha_start + hdisplay; > } > > -- > 2.40.1 >
On 22.05.2023 22:44, Marijn Suijten wrote: > On 2023-05-22 13:30:20, Jessica Zhang wrote: >> Currently, when compression is enabled, hdisplay is reduced via integer >> division. This causes issues for modes where the original hdisplay is >> not a multiple of 3. >> >> To fix this, use DIV_ROUND_UP to divide hdisplay. >> >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > > Nit: probably these should go in the opposite order. And if they're > all supposed to be chronological, I think it is: > > Suggested-by: > Fixes: > Signed-off-by: > Reviewed-by: > > But unsure if that's a hard requirement, or even correct at all. > > - Marijn Or you can rely on b4 to pick that up if it comes from others Konrad > >> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") >> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index 9223d7ec5a73..18d38b90eb28 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) >> * pulse width same >> */ >> h_total -= hdisplay; >> - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; >> + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); >> h_total += hdisplay; >> ha_end = ha_start + hdisplay; >> } >> >> -- >> 2.40.1 >>
On 2023-05-22 22:52:40, Konrad Dybcio wrote: > > > On 22.05.2023 22:44, Marijn Suijten wrote: > > On 2023-05-22 13:30:20, Jessica Zhang wrote: > >> Currently, when compression is enabled, hdisplay is reduced via integer > >> division. This causes issues for modes where the original hdisplay is > >> not a multiple of 3. > >> > >> To fix this, use DIV_ROUND_UP to divide hdisplay. > >> > >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > Nit: probably these should go in the opposite order. And if they're > > all supposed to be chronological, I think it is: > > > > Suggested-by: > > Fixes: > > Signed-off-by: > > Reviewed-by: > > > > But unsure if that's a hard requirement, or even correct at all. > > > > - Marijn > Or you can rely on b4 to pick that up if it comes from others The problem is that somewhat stupidly, b4 (trailers -u) puts them in the wrong (not chronological) order, so it's pretty much useless for this. Unless there's a required ordering specified somewhere in the docs, that is *not* chronological, and that b4 is abiding by? (that is my question above) - Marijn > > Konrad <snip>
On 5/22/2023 1:44 PM, Marijn Suijten wrote: > On 2023-05-22 13:30:20, Jessica Zhang wrote: >> Currently, when compression is enabled, hdisplay is reduced via integer >> division. This causes issues for modes where the original hdisplay is >> not a multiple of 3. >> >> To fix this, use DIV_ROUND_UP to divide hdisplay. >> >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > > Nit: probably these should go in the opposite order. And if they're > all supposed to be chronological, I think it is: > > Suggested-by: > Fixes: > Signed-off-by: > Reviewed-by: > > But unsure if that's a hard requirement, or even correct at all. Hi Marijn, I don't see any explicit documentation on the order of R-b tags. FWIW, I see in the git log that S-o-b always goes at the bottom of the commit message. I would prefer the S-o-b to always be at the bottom (as it helps me avoid duplicate S-o-b's when doing `git commit -s`), though I can flip the order of the R-b and suggested-by tags. Thanks, Jessica Zhang > > - Marijn > >> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") >> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index 9223d7ec5a73..18d38b90eb28 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) >> * pulse width same >> */ >> h_total -= hdisplay; >> - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; >> + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); >> h_total += hdisplay; >> ha_end = ha_start + hdisplay; >> } >> >> -- >> 2.40.1 >>
On 5/22/2023 2:45 PM, Jessica Zhang wrote: > > > On 5/22/2023 1:44 PM, Marijn Suijten wrote: >> On 2023-05-22 13:30:20, Jessica Zhang wrote: >>> Currently, when compression is enabled, hdisplay is reduced via integer >>> division. This causes issues for modes where the original hdisplay is >>> not a multiple of 3. >>> >>> To fix this, use DIV_ROUND_UP to divide hdisplay. >>> >>> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >>> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> >> >> Nit: probably these should go in the opposite order. And if they're >> all supposed to be chronological, I think it is: >> >> Suggested-by: >> Fixes: >> Signed-off-by: >> Reviewed-by: >> >> But unsure if that's a hard requirement, or even correct at all. > > Hi Marijn, > > I don't see any explicit documentation on the order of R-b tags. FWIW, I > see in the git log that S-o-b always goes at the bottom of the commit > message. > > I would prefer the S-o-b to always be at the bottom (as it helps me > avoid duplicate S-o-b's when doing `git commit -s`), though I can flip > the order of the R-b and suggested-by tags. Correction -- I can reorder the tags so that it's: Suggested-by: Fixes: Reviewed-by: Signed-off-by: Thanks, Jessica Zhang > > Thanks, > > Jessica Zhang > >> >> - Marijn >> >>> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") >>> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> >>> --- >>> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c >>> b/drivers/gpu/drm/msm/dsi/dsi_host.c >>> index 9223d7ec5a73..18d38b90eb28 100644 >>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >>> @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host >>> *msm_host, bool is_bonded_dsi) >>> * pulse width same >>> */ >>> h_total -= hdisplay; >>> - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; >>> + hdisplay = >>> DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); >>> h_total += hdisplay; >>> ha_end = ha_start + hdisplay; >>> } >>> >>> -- >>> 2.40.1 >>>
On Tue, 23 May 2023 at 00:45, Jessica Zhang <quic_jesszhan@quicinc.com> wrote: > > > > On 5/22/2023 1:44 PM, Marijn Suijten wrote: > > On 2023-05-22 13:30:20, Jessica Zhang wrote: > >> Currently, when compression is enabled, hdisplay is reduced via integer > >> division. This causes issues for modes where the original hdisplay is > >> not a multiple of 3. > >> > >> To fix this, use DIV_ROUND_UP to divide hdisplay. > >> > >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > Nit: probably these should go in the opposite order. And if they're > > all supposed to be chronological, I think it is: > > > > Suggested-by: > > Fixes: > > Signed-off-by: > > Reviewed-by: > > > > But unsure if that's a hard requirement, or even correct at all. > > Hi Marijn, > > I don't see any explicit documentation on the order of R-b tags. FWIW, I > see in the git log that S-o-b always goes at the bottom of the commit > message. > > I would prefer the S-o-b to always be at the bottom (as it helps me > avoid duplicate S-o-b's when doing `git commit -s`), though I can flip > the order of the R-b and suggested-by tags. I'd second Jessica here. Consider these tags as a history or a transcript: I would not vote on the particular order of the Suggested-by/Fixes tags, I don't think that is important. These come first. Then the patch goes through different cycles. of reviews, which gain Reviewed-by tags. In the same way Link/Patchwork/whatever other tags are added in the historical order. By having the submitter's S-o-b at the bottom, the submitter adds the final signature under everything else being stated/recorded. Of course, in a more complicated story, there might be other developers taking part (Co-Developed-By + Signed-off-by), etc. Note: all described is just my perception and might differ from the BCP regarding the tags. > > Thanks, > > Jessica Zhang > > > > > - Marijn > > > >> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") > >> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > >> --- > >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > >> index 9223d7ec5a73..18d38b90eb28 100644 > >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > >> @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) > >> * pulse width same > >> */ > >> h_total -= hdisplay; > >> - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; > >> + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); > >> h_total += hdisplay; > >> ha_end = ha_start + hdisplay; > >> } > >> > >> -- > >> 2.40.1 > >>
On 2023-05-23 01:14:40, Dmitry Baryshkov wrote: > On Tue, 23 May 2023 at 00:45, Jessica Zhang <quic_jesszhan@quicinc.com> wrote: > > > > > > > > On 5/22/2023 1:44 PM, Marijn Suijten wrote: > > > On 2023-05-22 13:30:20, Jessica Zhang wrote: > > >> Currently, when compression is enabled, hdisplay is reduced via integer > > >> division. This causes issues for modes where the original hdisplay is > > >> not a multiple of 3. > > >> > > >> To fix this, use DIV_ROUND_UP to divide hdisplay. > > >> > > >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > > > Nit: probably these should go in the opposite order. And if they're > > > all supposed to be chronological, I think it is: > > > > > > Suggested-by: > > > Fixes: > > > Signed-off-by: > > > Reviewed-by: > > > > > > But unsure if that's a hard requirement, or even correct at all. > > > > Hi Marijn, > > > > I don't see any explicit documentation on the order of R-b tags. FWIW, I > > see in the git log that S-o-b always goes at the bottom of the commit > > message. > > > > I would prefer the S-o-b to always be at the bottom (as it helps me > > avoid duplicate S-o-b's when doing `git commit -s`), though I can flip > > the order of the R-b and suggested-by tags. > > I'd second Jessica here. Consider these tags as a history or a transcript: > > I would not vote on the particular order of the Suggested-by/Fixes > tags, I don't think that is important. These come first. Then the > patch goes through different cycles. of reviews, which gain > Reviewed-by tags. > > In the same way Link/Patchwork/whatever other tags are added in the > historical order. > > By having the submitter's S-o-b at the bottom, the submitter adds the > final signature under everything else being stated/recorded. Correct, so the s-o-b can always be kept / moved back to the bottom on a resend, stating that they sign off on "all that was written previously" including picking up reviews. However, for the rest of your reply about "history / transcript", you seem to agree exactly with my point of keeping (or rather, simply appending) these in chronological order? - Marijn > > Of course, in a more complicated story, there might be other > developers taking part (Co-Developed-By + Signed-off-by), etc. > > Note: all described is just my perception and might differ from the > BCP regarding the tags. <snip>
On 23/05/2023 01:18, Marijn Suijten wrote: > On 2023-05-23 01:14:40, Dmitry Baryshkov wrote: >> On Tue, 23 May 2023 at 00:45, Jessica Zhang <quic_jesszhan@quicinc.com> wrote: >>> >>> >>> >>> On 5/22/2023 1:44 PM, Marijn Suijten wrote: >>>> On 2023-05-22 13:30:20, Jessica Zhang wrote: >>>>> Currently, when compression is enabled, hdisplay is reduced via integer >>>>> division. This causes issues for modes where the original hdisplay is >>>>> not a multiple of 3. >>>>> >>>>> To fix this, use DIV_ROUND_UP to divide hdisplay. >>>>> >>>>> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >>>>> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org> >>>> >>>> Nit: probably these should go in the opposite order. And if they're >>>> all supposed to be chronological, I think it is: >>>> >>>> Suggested-by: >>>> Fixes: >>>> Signed-off-by: >>>> Reviewed-by: >>>> >>>> But unsure if that's a hard requirement, or even correct at all. >>> >>> Hi Marijn, >>> >>> I don't see any explicit documentation on the order of R-b tags. FWIW, I >>> see in the git log that S-o-b always goes at the bottom of the commit >>> message. >>> >>> I would prefer the S-o-b to always be at the bottom (as it helps me >>> avoid duplicate S-o-b's when doing `git commit -s`), though I can flip >>> the order of the R-b and suggested-by tags. >> >> I'd second Jessica here. Consider these tags as a history or a transcript: >> >> I would not vote on the particular order of the Suggested-by/Fixes >> tags, I don't think that is important. These come first. Then the >> patch goes through different cycles. of reviews, which gain >> Reviewed-by tags. >> >> In the same way Link/Patchwork/whatever other tags are added in the >> historical order. >> >> By having the submitter's S-o-b at the bottom, the submitter adds the >> final signature under everything else being stated/recorded. > > Correct, so the s-o-b can always be kept / moved back to the bottom on a > resend, stating that they sign off on "all that was written previously" > including picking up reviews. > > However, for the rest of your reply about "history / transcript", you > seem to agree exactly with my point of keeping (or rather, simply > appending) these in chronological order? Yes. > > - Marijn > >> >> Of course, in a more complicated story, there might be other >> developers taking part (Co-Developed-By + Signed-off-by), etc. >> >> Note: all described is just my perception and might differ from the >> BCP regarding the tags. > > <snip>
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 9223d7ec5a73..18d38b90eb28 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) * pulse width same */ h_total -= hdisplay; - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); h_total += hdisplay; ha_end = ha_start + hdisplay; }