Message ID | 20230518152244.2178-2-jszhang@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp591846vqo; Thu, 18 May 2023 08:48:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6HizWmghNZo8x8zvT2sD4wEmgIAAOc3mEfGudzLl9C7weHEebJMCLlsR22MQ3tdWVFPdqk X-Received: by 2002:a05:6a21:99a0:b0:104:beb4:da2c with SMTP id ve32-20020a056a2199a000b00104beb4da2cmr17383pzb.52.1684424927966; Thu, 18 May 2023 08:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684424927; cv=none; d=google.com; s=arc-20160816; b=dOWnDcdkaX0oYWjPr421LmNeCkzZB3emCrw/s0uX6/QlVYSU3YVF+C5RaJhaKe2R2u uuxBXFm5p6A6jzW9UI9LdEXVBdoZp6o3ajGYHBRfeU7wxFq04IiPcDKSMEKbKqXfitSt xOMy7HApgxEBQ3wKt2fkT4bOM0hqjfMLnQf/HrykMBkDRP6v7fVwNirV2nqxI7ZyOoQW w6Gtlo18LCGwVtfJcmms2FhZnOoZSHfcKO5uhee1fihJM7wEpiefUs3C0s6HwG1AjT/W z/G/LCoGgTP/vkuPY0mrJuqwa0tQvL4AksorA48SH01OOfCycYh3ReOIIV4fvfkK5vuE UAKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vSROk8N9/8KzjvcClUa1vrQfOjZWzZbsilag/agVm18=; b=TYvcMXqXIfJsqWNZoY8bM4JKuUa2H9le1n+A+cJdjsZJnfphsxNezlUGuvSWREl8Dg PdpJV4WBHk114+XQqNp6YhwsNmYrKK3VIYYjn9h9zkbBRYXB8DEys6HZLD6Y4hsYtICw +UL4xu3GModfPFDKJISUT9k6PFzoxIbO4UTNOHmqI0RTM0CmilZBEcxS+YkINmepRFCN HVCa0vSNvEVNXjgul/oyHcAYUDVqopqlm+XrMp1QcUM0dclvpygp/a/CPMgauJOpN3lC Id5t7ltIT5wUhDZ85RKjgVGfAUZEgR7iOq2rwf9wdLQR3lzu46pbhzRz21MP5ETxuz2s h/Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZUPCod8n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l10-20020a17090a384a00b0024bf50a83e7si4357112pjf.174.2023.05.18.08.48.30; Thu, 18 May 2023 08:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZUPCod8n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231709AbjERPeI (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Thu, 18 May 2023 11:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbjERPeF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 18 May 2023 11:34:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4005B12C; Thu, 18 May 2023 08:34:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7451165032; Thu, 18 May 2023 15:34:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42D3FC433A1; Thu, 18 May 2023 15:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684424040; bh=8o3w2PNumfMmW1nsxUiJwSK+1Wm7LHqx/wBqf4PFRQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZUPCod8nmuFnBbgzwj18nPIcjTiXQu7I1k69OCF5REnqW7VzJIiOiHKg/4CwGx5Gz C086refVmixdfnGDGUXEccsOtrGlLURjLOe02aMuDMNmeZdAu999a0k0EeLYb++Ro0 Fh4BCqA7yo9rbf0O0INt0BRGWTdqM1bZy7yu0cabzvXog4JDImknRCe5jHnzt4lytZ KanHpnCUPmbfWFXf2hav/+kZ51HIGuOSRDW9HgKAtLzTHU3kxRBUr0AAOvSqlaKk6G wEa2xAdvIdoyYZ3Idna2IhUQVsKogjGrgkGtXx7MWOMVW/7zVvJB75fHeUthntzb4P avLs2VGEGiJaQ== From: Jisheng Zhang <jszhang@kernel.org> To: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Conor Dooley <conor.dooley@microchip.com>, Palmer Dabbelt <palmer@rivosinc.com> Subject: [PATCH v4 01/10] dt-bindings: vendor-prefixes: add bouffalolab Date: Thu, 18 May 2023 23:22:35 +0800 Message-Id: <20230518152244.2178-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230518152244.2178-1-jszhang@kernel.org> References: <20230518152244.2178-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766247553181883638?= X-GMAIL-MSGID: =?utf-8?q?1766247553181883638?= |
Series |
riscv: add Bouffalolab bl808 support
|
|
Commit Message
Jisheng Zhang
May 18, 2023, 3:22 p.m. UTC
In the following commits, we will support bl808 SoC which is from Bouffalo Lab Technology (Nanjing) Co., Ltd. Add bouffalolab vendor prefix binding. Link: https://en.bouffalolab.com/ Signed-off-by: Jisheng Zhang <jszhang@kernel.org> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Comments
Hi Jisheng, Thanks for updating this series! On 5/18/23 10:22, Jisheng Zhang wrote: > In the following commits, we will support bl808 SoC which is from > Bouffalo Lab Technology (Nanjing) Co., Ltd. > > Add bouffalolab vendor prefix binding. > > Link: https://en.bouffalolab.com/ > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 82d39ab0231b..3566346f2f9e 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -200,6 +200,8 @@ patternProperties: > description: BOE Technology Group Co., Ltd. > "^bosch,.*": > description: Bosch Sensortec GmbH > + "^bouffalolab,.*": > + description: Bouffalo Lab Technology (Nanjing) Co., Ltd. Have you thought about using the "bflb" abbreviation as the vendor prefix, like you use throughout the driver code? This would save quite some space in the DTB, and seems to be the most common variant seen in the vendor SDK: bouffalo_sdk$ git grep -i bflb | wc -l 14364 bouffalo_sdk$ git grep -i bouffalo | wc -l 1042 bouffalo_sdk$ git grep -i bouffalolab | wc -l 179 So that is what we were using for bringing up Linux and U-Boot over at https://github.com/openbouffalo. On the other hand, "bouffalolab" is certainly accurate as well, so I understand if you prefer it. And we will of course adapt to whatever gets merged, since our goal is upstreaming. The vendor code drop[1] provided only one example, "bflb-uart,uart0", which is not very helpful. Maybe you have received further information from them? What do you think? Regards, Samuel [1]: https://github.com/bouffalolab/bl808_linux/blob/main/linux-5.10.4-808/drivers/tty/serial/bflb_uart.c#L700
On Thu, May 18, 2023 at 09:53:12PM -0500, Samuel Holland wrote: > Hi Jisheng, > > Thanks for updating this series! > > On 5/18/23 10:22, Jisheng Zhang wrote: > > In the following commits, we will support bl808 SoC which is from > > Bouffalo Lab Technology (Nanjing) Co., Ltd. > > > > Add bouffalolab vendor prefix binding. > > > > Link: https://en.bouffalolab.com/ > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > --- > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 82d39ab0231b..3566346f2f9e 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -200,6 +200,8 @@ patternProperties: > > description: BOE Technology Group Co., Ltd. > > "^bosch,.*": > > description: Bosch Sensortec GmbH > > + "^bouffalolab,.*": > > + description: Bouffalo Lab Technology (Nanjing) Co., Ltd. > > Have you thought about using the "bflb" abbreviation as the vendor I did think about bflb vs bouffalolab. Here is what I thought: I came across "marvell" vs "mrvl" sevral years ago, I got an impression "marvell" vendor prefix is preferred if I read the discussions correctly. As for Bouffalolab vendor prefix, I have no preference, maybe DT maintainers can provide inputs here. Rob, Conor, Krzysztof, what's your opinion? Thanks > prefix, like you use throughout the driver code? This would save quite > some space in the DTB, and seems to be the most common variant seen in > the vendor SDK: > > bouffalo_sdk$ git grep -i bflb | wc -l > 14364 > bouffalo_sdk$ git grep -i bouffalo | wc -l > 1042 > bouffalo_sdk$ git grep -i bouffalolab | wc -l > 179 > > So that is what we were using for bringing up Linux and U-Boot over at > https://github.com/openbouffalo. > > On the other hand, "bouffalolab" is certainly accurate as well, so I > understand if you prefer it. And we will of course adapt to whatever > gets merged, since our goal is upstreaming. > > The vendor code drop[1] provided only one example, "bflb-uart,uart0", > which is not very helpful. Maybe you have received further information > from them? > > What do you think? > > Regards, > Samuel > > [1]: > https://github.com/bouffalolab/bl808_linux/blob/main/linux-5.10.4-808/drivers/tty/serial/bflb_uart.c#L700 >
On Sun, May 21, 2023 at 05:02:23PM +0800, Jisheng Zhang wrote: > On Thu, May 18, 2023 at 09:53:12PM -0500, Samuel Holland wrote: > > Hi Jisheng, > > > > Thanks for updating this series! > > > > On 5/18/23 10:22, Jisheng Zhang wrote: > > > In the following commits, we will support bl808 SoC which is from > > > Bouffalo Lab Technology (Nanjing) Co., Ltd. > > > > > > Add bouffalolab vendor prefix binding. > > > > > > Link: https://en.bouffalolab.com/ > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > > --- > > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > index 82d39ab0231b..3566346f2f9e 100644 > > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > @@ -200,6 +200,8 @@ patternProperties: > > > description: BOE Technology Group Co., Ltd. > > > "^bosch,.*": > > > description: Bosch Sensortec GmbH > > > + "^bouffalolab,.*": > > > + description: Bouffalo Lab Technology (Nanjing) Co., Ltd. > > > > Have you thought about using the "bflb" abbreviation as the vendor > > I did think about bflb vs bouffalolab. Here is what I thought: I came > across "marvell" vs "mrvl" sevral years ago, I got an impression > "marvell" vendor prefix is preferred if I read the discussions > correctly. > > As for Bouffalolab vendor prefix, I have no preference, maybe DT > maintainers can provide inputs here. > Rob, Conor, Krzysztof, what's your opinion? I had a look through the blame for vendor-prefixes.yaml since I had no clue how easy it would be to find the marvell discussion - the commit for gateworks' deprecated entry (done by Krzysztof says "Favor the longer one (more descriptive)" & I think the same point is valid here. I would have no idea what "bflb" was if I came across it in isolation! Cheers, Conor.
On Sun, May 21, 2023 at 05:02:23PM +0800, Jisheng Zhang wrote: > On Thu, May 18, 2023 at 09:53:12PM -0500, Samuel Holland wrote: > > Hi Jisheng, > > > > Thanks for updating this series! > > > > On 5/18/23 10:22, Jisheng Zhang wrote: > > > In the following commits, we will support bl808 SoC which is from > > > Bouffalo Lab Technology (Nanjing) Co., Ltd. > > > > > > Add bouffalolab vendor prefix binding. > > > > > > Link: https://en.bouffalolab.com/ > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > > --- > > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > index 82d39ab0231b..3566346f2f9e 100644 > > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > > @@ -200,6 +200,8 @@ patternProperties: > > > description: BOE Technology Group Co., Ltd. > > > "^bosch,.*": > > > description: Bosch Sensortec GmbH > > > + "^bouffalolab,.*": > > > + description: Bouffalo Lab Technology (Nanjing) Co., Ltd. > > > > Have you thought about using the "bflb" abbreviation as the vendor > > I did think about bflb vs bouffalolab. Here is what I thought: I came > across "marvell" vs "mrvl" sevral years ago, I got an impression > "marvell" vendor prefix is preferred if I read the discussions > correctly. > > As for Bouffalolab vendor prefix, I have no preference, maybe DT > maintainers can provide inputs here. > Rob, Conor, Krzysztof, what's your opinion? The general preference is to match the vendor's domain name (minus the .com, etc.). Originally, the preference was stock ticker symbol, but we've pretty much moved away from that. So that's 'bouffalolab'. Acked-by: Rob Herring <robh@kernel.org> Rob
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 82d39ab0231b..3566346f2f9e 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -200,6 +200,8 @@ patternProperties: description: BOE Technology Group Co., Ltd. "^bosch,.*": description: Bosch Sensortec GmbH + "^bouffalolab,.*": + description: Bouffalo Lab Technology (Nanjing) Co., Ltd. "^boundary,.*": description: Boundary Devices Inc. "^brcm,.*":