diff mbox series

[v1,17/17] block, blksnap: adds a blksnap to the kernel tree

Message ID 20221102155101.4550-18-sergei.shtepa@veeam.com
State New
Headers
Series blksnap - creating non-persistent snapshots for backup |

Commit Message

Sergei Shtepa Nov. 2, 2022, 3:51 p.m. UTC 
  Signed-off-by: Sergei Shtepa <sergei.shtepa@veeam.com>
---
 drivers/block/Kconfig  | 2 ++
 drivers/block/Makefile | 2 ++
 2 files changed, 4 insertions(+)

Comments

kernel test robot Nov. 3, 2022, 2 a.m. UTC | #1 
Hi Sergei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.1-rc3 next-20221102]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sergei-Shtepa/blksnap-creating-non-persistent-snapshots-for-backup/20221103-004434
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20221102155101.4550-18-sergei.shtepa%40veeam.com
patch subject: [PATCH v1 17/17] block, blksnap: adds a blksnap to the kernel tree
config: csky-randconfig-c033-20221103
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b9fa151bb0035ff8a24621ba486011660510dc45
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sergei-Shtepa/blksnap-creating-non-persistent-snapshots-for-backup/20221103-004434
        git checkout b9fa151bb0035ff8a24621ba486011660510dc45
        # save the config file
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 ARCH=csky 

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   csky-linux-ld: csky-linux-ld: DWARF error: could not find abbrev number 3562
   drivers/block/blksnap/sysfs.o: in function `sysfs_init':
>> sysfs.c:(.text+0x78): multiple definition of `sysfs_init'; csky-linux-ld: DWARF error: could not find abbrev number 49
   fs/sysfs/mount.o:mount.c:(.init.text+0x0): first defined here

cocci warnings: (new ones prefixed by >>)
>> drivers/block/blksnap/diff_area.c:223:9-16: WARNING: ERR_CAST can be used with bdev
--
>> drivers/block/blksnap/tracker.c:422:9-16: WARNING: ERR_CAST can be used with bdev
--
>> drivers/block/blksnap/ctrl.c:290:8-15: WARNING opportunity for memdup_user
--
>> drivers/block/blksnap/snapimage.c:115:2-3: Unneeded semicolon
diff mbox series

Patch

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index db1b4b202646..882b3dd0264d 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -410,4 +410,6 @@  config BLK_DEV_UBLK
 
 source "drivers/block/rnbd/Kconfig"
 
+source "drivers/block/blksnap/Kconfig"
+
 endif # BLK_DEV
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index 101612cba303..8414c47960c2 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -40,3 +40,5 @@  obj-$(CONFIG_BLK_DEV_NULL_BLK)	+= null_blk/
 obj-$(CONFIG_BLK_DEV_UBLK)			+= ublk_drv.o
 
 swim_mod-y	:= swim.o swim_asm.o
+
+obj-$(CONFIG_BLK_SNAP) += blksnap/