Message ID | 20230511005403.24689-1-jsnitsel@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4036379vqo; Wed, 10 May 2023 18:23:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4rPtX3eppAu/BeEfryNGF8XS/UVmHmHEvr9LZ+IAa8mvA2EoJxA91LiFbpa9ppyZqhGdWR X-Received: by 2002:a05:6a21:7891:b0:101:209e:bc57 with SMTP id bf17-20020a056a21789100b00101209ebc57mr11066216pzc.50.1683768233218; Wed, 10 May 2023 18:23:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683768233; cv=none; d=google.com; s=arc-20160816; b=IFibW9323zI46oEeQc4WF4j/x14cqFUASIrV7fTgwyzzaJMaYwUtB5hNiu6dtwwz95 FuWMHvoSAGdumIFuehOsgJFljvt+duqegdQPniia21XMNp/hQ6U3KOUFLeFsVK2PlbVn wYIsNY2CTnjzFDl7wNaqsdzq/TqoatRU3FjkRlwB3gzbOGDVybGZ1bN7ZJs2HgTjF2Rs mnZYnIhwiMlQKVmLehJkcS9Vo+WfHvtm44FQVcDuRZCgBnx12QpUN5jHR74NT7JSxaqw sp34oFQDhnh+nZAC+7eClFAKo1VMMVOZsImXy7b6Z/tTDfL+S/8FP/nlvOcz9VxN5SlW DCOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gQADr3uLo7kuMaIoXdW68k59lf8w0tnVTrTJLVpL2l4=; b=mtBk18gibhP2J0zjjToO7phq0dnkKu02setDOKW+mK/dhzjtoI0u6lnIuhnY2D9eIi 4PIg3xbmH3AqXbbSOTiTGkLqABk6f2ryT7lkdBoCMadJALXoI0PidIBkXagn2nRHXFgt 4PJ9HQYtFHbUIuq6M17NrJcQXneiXFKJCiEdAaoUyrec79yUopoWbwC13FasjRy1q+Fv BZ34vPXe9TgToSaAJNNnjYRbk9AY54y+XFi970vE3t0PKhW/Cj9QHm9kkfWGS/QDuoey IkQRsGcWsicEP7khtXuQa/M+FPeEDo3xQH9rBbro/CyA26nlIiQ9m1Up8kLXmKQshJhj D5UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M2TlbuSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a637f46000000b0050bf5a814a8si4854836pgn.403.2023.05.10.18.23.40; Wed, 10 May 2023 18:23:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M2TlbuSF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236708AbjEKAzB (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Wed, 10 May 2023 20:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232030AbjEKAy7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 10 May 2023 20:54:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9EF719B7 for <linux-kernel@vger.kernel.org>; Wed, 10 May 2023 17:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683766449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gQADr3uLo7kuMaIoXdW68k59lf8w0tnVTrTJLVpL2l4=; b=M2TlbuSFCvwf3UIPuO9k005kzaKzvtiQ11rzX7UNsZtIzo94zfqBEfynaEPksUDvQ0pxRM KW/xZwr2Dzg2pKedcSS/WRe1G02lX6q/wnB4czWTzeuHJzPGSIIYh72gHJw+NDNfS8j8r+ +AmDf7XIhKagx3sPgx0dYrDd0xGhowk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-49nZcDDvOsKY-XjYHmJ1TQ-1; Wed, 10 May 2023 20:54:06 -0400 X-MC-Unique: 49nZcDDvOsKY-XjYHmJ1TQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7AC2100F64F; Thu, 11 May 2023 00:54:05 +0000 (UTC) Received: from cantor.redhat.com (unknown [10.2.16.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD736141511D; Thu, 11 May 2023 00:54:04 +0000 (UTC) From: Jerry Snitselaar <jsnitsel@redhat.com> To: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org Cc: Peter Zijlstra <peterz@infradead.org>, stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>, Jarkko Sakkinen <jarkko@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca> Subject: [PATCH] tpm/tpm_tis: Disable interrupts for more Lenovo devices Date: Wed, 10 May 2023 17:54:03 -0700 Message-Id: <20230511005403.24689-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765558958857920983?= X-GMAIL-MSGID: =?utf-8?q?1765558958857920983?= |
Series |
tpm/tpm_tis: Disable interrupts for more Lenovo devices
|
|
Commit Message
Jerry Snitselaar
May 11, 2023, 12:54 a.m. UTC
The P360 Tiny suffers from an irq storm issue like the T490s, so add
an entry for it to tpm_tis_dmi_table, and force polling. There also
previously was a report from the previous attempt to enable interrupts
that involved a ThinkPad L490. So an entry is added for it as well.
Reported-by: Peter Zijlstra <peterz@infradead.org> # P360 Tiny
Closes: https://lore.kernel.org/linux-integrity/20230505130731.GO83892@hirez.programming.kicks-ass.net/
Cc: stable@vger.kernel.org # 6.2
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
---
drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
Comments
On Wed, May 10, 2023 at 05:54:03PM -0700, Jerry Snitselaar wrote: > The P360 Tiny suffers from an irq storm issue like the T490s, so add > an entry for it to tpm_tis_dmi_table, and force polling. There also > previously was a report from the previous attempt to enable interrupts > that involved a ThinkPad L490. So an entry is added for it as well. > > Reported-by: Peter Zijlstra <peterz@infradead.org> # P360 Tiny > Closes: https://lore.kernel.org/linux-integrity/20230505130731.GO83892@hirez.programming.kicks-ass.net/ > Cc: stable@vger.kernel.org # 6.2 For the stable folks this can be ignored though it won't hurt anything if someone does backport it. The code enabling interrupts went into 6.4-rc1, not 6.2. Regards, Jerry
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 7af389806643..709b4e13bd6e 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -122,6 +122,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkStation P360 Tiny", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkStation P360 Tiny"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad L490", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), + }, + }, {} };