[v6,2/6] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support
Commit Message
Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
needs to be set first to 'enable' the eud module.
So, update the dt-bindings to accommodate the third register
property (TCSR Base) required by the driver on these SoCs.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
.../bindings/soc/qcom/qcom,eud.yaml | 42 +++++++++++++++++--
1 file changed, 39 insertions(+), 3 deletions(-)
Comments
On 17/05/2023 23:17, Bhupesh Sharma wrote:
> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
>
> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> needs to be set first to 'enable' the eud module.
>
> So, update the dt-bindings to accommodate the third register
> property (TCSR Base) required by the driver on these SoCs.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Also - no improvements.
Best regards,
Krzysztof
Hi Krzysztof,
On Thu, 18 May 2023 at 13:08, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/05/2023 23:17, Bhupesh Sharma wrote:
> > Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
> >
> > On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> > needs to be set first to 'enable' the eud module.
> >
> > So, update the dt-bindings to accommodate the third register
> > property (TCSR Base) required by the driver on these SoCs.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
>
> Also - no improvements.
Oops, seems I missed your review on v5 due to a label filter for
'linux-usb' list.
I will take care in future versions.
Please let me know if the R-B tag is still valid though :)
Thanks.
@@ -18,12 +18,16 @@ properties:
items:
- enum:
- qcom,sc7280-eud
+ - qcom,sm6115-eud
- const: qcom,eud
reg:
- items:
- - description: EUD Base Register Region
- - description: EUD Mode Manager Register
+ minItems: 2
+ maxItems: 3
+
+ reg-names:
+ minItems: 2
+ maxItems: 3
interrupts:
description: EUD interrupt
@@ -52,6 +56,38 @@ required:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7280-eud
+ then:
+ properties:
+ reg:
+ maxItems: 2
+ reg-names:
+ items:
+ - const: eud-base
+ - const: eud-mode-mgr
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm6115-eud
+ then:
+ properties:
+ reg:
+ maxItems: 3
+ reg-names:
+ items:
+ - const: eud-base
+ - const: eud-mode-mgr
+ - const: tcsr-base
+
examples:
- |
eud@88e0000 {