diff mbox series

[committed] tree-ssa-math-opts: correct -ffp-contract= check

Message ID 20230517184352.32144-1-amonakov@ispras.ru
State Accepted
Headers
Series [committed] tree-ssa-math-opts: correct -ffp-contract= check |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Alexander Monakov May 17, 2023, 6:43 p.m. UTC 
  Since tree-ssa-math-opts may freely contract across statement boundaries
we should enable it only for -ffp-contract=fast instead of disabling it
for -ffp-contract=off.

No functional change, since -ffp-contract=on is not exposed yet.

gcc/ChangeLog:

	* tree-ssa-math-opts.cc (convert_mult_to_fma): Enable only for
	FP_CONTRACT_FAST (no functional change).
---

Preapproved in PR 106092, pushed to trunk.

 gcc/tree-ssa-math-opts.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Biener May 18, 2023, 6:15 a.m. UTC | #1 
On Wed, May 17, 2023 at 8:44 PM Alexander Monakov via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Since tree-ssa-math-opts may freely contract across statement boundaries
> we should enable it only for -ffp-contract=fast instead of disabling it
> for -ffp-contract=off.
>
> No functional change, since -ffp-contract=on is not exposed yet.

OK.

> gcc/ChangeLog:
>
>         * tree-ssa-math-opts.cc (convert_mult_to_fma): Enable only for
>         FP_CONTRACT_FAST (no functional change).
> ---
>
> Preapproved in PR 106092, pushed to trunk.
>
>  gcc/tree-ssa-math-opts.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/tree-ssa-math-opts.cc b/gcc/tree-ssa-math-opts.cc
> index b58a2ac9e6..d71c51dc0e 100644
> --- a/gcc/tree-ssa-math-opts.cc
> +++ b/gcc/tree-ssa-math-opts.cc
> @@ -3320,7 +3320,7 @@ convert_mult_to_fma (gimple *mul_stmt, tree op1, tree op2,
>    imm_use_iterator imm_iter;
>
>    if (FLOAT_TYPE_P (type)
> -      && flag_fp_contract_mode == FP_CONTRACT_OFF)
> +      && flag_fp_contract_mode != FP_CONTRACT_FAST)
>      return false;
>
>    /* We don't want to do bitfield reduction ops.  */
> --
> 2.39.2
>
diff mbox series

Patch

diff --git a/gcc/tree-ssa-math-opts.cc b/gcc/tree-ssa-math-opts.cc
index b58a2ac9e6..d71c51dc0e 100644
--- a/gcc/tree-ssa-math-opts.cc
+++ b/gcc/tree-ssa-math-opts.cc
@@ -3320,7 +3320,7 @@  convert_mult_to_fma (gimple *mul_stmt, tree op1, tree op2,
   imm_use_iterator imm_iter;
 
   if (FLOAT_TYPE_P (type)
-      && flag_fp_contract_mode == FP_CONTRACT_OFF)
+      && flag_fp_contract_mode != FP_CONTRACT_FAST)
     return false;
 
   /* We don't want to do bitfield reduction ops.  */