diff mbox series

gpio: mockup: Fix mode of debugfs files

Message ID 20230517054756.11119-1-zev@bewilderbeest.net
State New
Headers
Series gpio: mockup: Fix mode of debugfs files |

Commit Message

Zev Weiss May 17, 2023, 5:47 a.m. UTC 
  This driver's debugfs files have had a read operation since commit
2a9e27408e12 ("gpio: mockup: rework debugfs interface"), but were
still being created with write-only mode bits.  Update them to
indicate that the files can also be read.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
Cc: stable@kernel.org # v5.1+
---
 drivers/gpio/gpio-mockup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartosz Golaszewski May 17, 2023, 9:19 a.m. UTC | #1 
On Wed, May 17, 2023 at 7:50 AM Zev Weiss <zev@bewilderbeest.net> wrote:
>
> This driver's debugfs files have had a read operation since commit
> 2a9e27408e12 ("gpio: mockup: rework debugfs interface"), but were
> still being created with write-only mode bits.  Update them to
> indicate that the files can also be read.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> Cc: stable@kernel.org # v5.1+
> ---
>  drivers/gpio/gpio-mockup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index e6a7049bef64..b32063ac845a 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -369,7 +369,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
>                 priv->offset = i;
>                 priv->desc = gpiochip_get_desc(gc, i);
>
> -               debugfs_create_file(name, 0200, chip->dbg_dir, priv,
> +               debugfs_create_file(name, 0600, chip->dbg_dir, priv,
>                                     &gpio_mockup_debugfs_ops);
>         }
>  }
> --
> 2.40.1
>

Good catch, applied, thanks!

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index e6a7049bef64..b32063ac845a 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -369,7 +369,7 @@  static void gpio_mockup_debugfs_setup(struct device *dev,
 		priv->offset = i;
 		priv->desc = gpiochip_get_desc(gc, i);
 
-		debugfs_create_file(name, 0200, chip->dbg_dir, priv,
+		debugfs_create_file(name, 0600, chip->dbg_dir, priv,
 				    &gpio_mockup_debugfs_ops);
 	}
 }