diff mbox series

dt-bindings: net: nxp,sja1105: document spi-cpol

Message ID 20221102161211.51139-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series dt-bindings: net: nxp,sja1105: document spi-cpol |

Commit Message

Krzysztof Kozlowski Nov. 2, 2022, 4:12 p.m. UTC 
  Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
to fix dtbs_check warnings:

  arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring Nov. 2, 2022, 6:35 p.m. UTC | #1 
On Wed, 02 Nov 2022 12:12:11 -0400, Krzysztof Kozlowski wrote:
> Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
> to fix dtbs_check warnings:
> 
>   arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


ethernet-switch@1: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'fsl,spi-cs-sck-delay', 'fsl,spi-sck-cs-delay', 'spi-cpha' were unexpected)
	arch/arm/boot/dts/ls1021a-tsn.dtb

switch@0: Unevaluated properties are not allowed ('clocks', 'reset-gpios', 'spi-cpha' were unexpected)
	arch/arm/boot/dts/imx6qp-prtwd3.dtb
	arch/arm/boot/dts/stm32mp151a-prtt1c.dtb
Krzysztof Kozlowski Nov. 2, 2022, 6:49 p.m. UTC | #2 
On 02/11/2022 14:35, Rob Herring wrote:
> 
> On Wed, 02 Nov 2022 12:12:11 -0400, Krzysztof Kozlowski wrote:
>> Some boards use SJA1105 Ethernet Switch with SPI CPOL, so document this
>> to fix dtbs_check warnings:
>>
>>   arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb: ethernet-switch@0: Unevaluated properties are not allowed ('spi-cpol' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> ethernet-switch@1: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'fsl,spi-cs-sck-delay', 'fsl,spi-sck-cs-delay', 'spi-cpha' were unexpected)
> 	arch/arm/boot/dts/ls1021a-tsn.dtb

I'll add cpha, but fsl,spi-cs-sck-delay are coming from unconverted
schema - spi-fsl-dspi.txt.

> 
> switch@0: Unevaluated properties are not allowed ('clocks', 'reset-gpios', 'spi-cpha' were unexpected)
> 	arch/arm/boot/dts/imx6qp-prtwd3.dtb
> 	arch/arm/boot/dts/stm32mp151a-prtt1c.dtb
> 

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
index 1e26d876d146..a73905a50ee5 100644
--- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
@@ -36,6 +36,8 @@  properties:
   reg:
     maxItems: 1
 
+  spi-cpol: true
+
   # Optional container node for the 2 internal MDIO buses of the SJA1110
   # (one for the internal 100base-T1 PHYs and the other for the single
   # 100base-TX PHY). The "reg" property does not have physical significance.