Message ID | 1216e96b279d08230cb2aa61d536f44c1e9b800a.1667254476.git.daniel@makrotopia.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2584121wru; Mon, 31 Oct 2022 15:29:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4srHuE6KVI3SbMAYsA4tYZ2x8URR0wNTcFjpHuN0rT4Dcukjg5GtvzyDAavorXxaCaYASe X-Received: by 2002:a17:907:d22:b0:78e:2788:51ae with SMTP id gn34-20020a1709070d2200b0078e278851aemr14713574ejc.689.1667255378760; Mon, 31 Oct 2022 15:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667255378; cv=none; d=google.com; s=arc-20160816; b=X/7NTkI1O7JYl8mXBLmJOMoJqFYxUukih/v2ENcQphBAlOhoBzcf7ahivcoCbAkait xK8B+eQrAn1TT1hKWfr7+HDbpW9Z5sTgZecOt13KXawQvhzx1hz0tJpBgJqE4TkcSTO3 mHHDDsXmGIbbpruAkrCvSPrGx7g4Sg0TR6f7z/LZN/GB5bNxPv5rdblBiQsmKmcjlnjH n2EjkfVmT02PowbUc6kfGiN2HRkbowBjcZXRYNX25l4JHLbK09BvjivV9NBvouY+Wnwe OSuwaJr63RTv9dH8oVh3wkTcmbMLLzFbmwfzk+OPCTJUk5sGJ/P8BRKnT6uLPrF8GhD5 OJng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date; bh=9lf0+H+Lyxb3lTb0W28LZOfwl4eCR2cGKE01WzgOLhk=; b=k/1Be4QpMPYgHFDwtLP9uTwL2MQ+4HOfrWJwzA8hgnfJ4hofgSOKOo2me7VOahOFtx Nw0gj6OpYZzuSX7zGGxsqDB2Z1fziW6cNKXRzbEcEejNaf7Qmwu/unhM0VG6Y6MqS/0Y YyQ/4mLJNemJTIlIQIbjUCSRB1WkFLb08Ou2KGE9XKukiQzGiBlY9vYOmn6PnXcMLQrs 0o8tUYCWB5+4zL7ZHKSvmNCsmZTRYkidqZINm2Si/NEssBvHpPTji5Xz6i0ogwSRqddq A81TBW7qytVpGA/iyyU++R1VlcMLkNWc8hiQYiHeEMItWvr/4R0LR6rhmq2j0yPqOdKJ TS5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp10-20020a1709073e0a00b00732fcbcfedesi10443737ejc.623.2022.10.31.15.29.13; Mon, 31 Oct 2022 15:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbiJaWRE (ORCPT <rfc822;kartikey406@gmail.com> + 99 others); Mon, 31 Oct 2022 18:17:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiJaWRB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 31 Oct 2022 18:17:01 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20E7513F10; Mon, 31 Oct 2022 15:17:01 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from <daniel@makrotopia.org>) id 1opd5X-0000xS-Ac; Mon, 31 Oct 2022 23:16:59 +0100 Date: Mon, 31 Oct 2022 22:16:53 +0000 From: Daniel Golle <daniel@makrotopia.org> To: devicetree@vger.kernel.org, linux-pm@vger.kernel.or, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Matthias Brugger <matthias.bgg@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Subject: [PATCH 2/2] dt-bindings: thermal: mediatek: add compatible string for MT7986 SoC Message-ID: <1216e96b279d08230cb2aa61d536f44c1e9b800a.1667254476.git.daniel@makrotopia.org> References: <136157bd1f94c64504f87ee2db6b3ed0a8dcc3de.1667254476.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <136157bd1f94c64504f87ee2db6b3ed0a8dcc3de.1667254476.git.daniel@makrotopia.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748243976009531219?= X-GMAIL-MSGID: =?utf-8?q?1748243976009531219?= |
Series |
[1/2] thermal: mediatek: add support for MT7986 and MT7981
|
|
Commit Message
Daniel Golle
Oct. 31, 2022, 10:16 p.m. UTC
Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit
found in MT7981 and MT7986 SoCs.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, Oct 31, 2022 at 6:08 PM Daniel Golle <daniel@makrotopia.org> wrote: > > Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit > found in MT7981 and MT7986 SoCs. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 + > 1 file changed, 1 insertion(+) Resending as the reply headers got lost... Acked-by: Rob Herring <robh@kernel.org>
On 31/10/2022 18:16, Daniel Golle wrote: > Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit > found in MT7981 and MT7986 SoCs. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > index 5c7e7bdd029abf..efc16ab5b22b5d 100644 > --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > @@ -13,6 +13,7 @@ Required properties: > - "mediatek,mt2701-thermal" : For MT2701 family of SoCs > - "mediatek,mt2712-thermal" : For MT2712 family of SoCs > - "mediatek,mt7622-thermal" : For MT7622 SoC > + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC Then recommended is to have specific compatible followed by fallback (so 7986 followed by 7981) Best regards, Krzysztof
On Wed, Nov 02, 2022 at 04:43:35PM -0400, Krzysztof Kozlowski wrote: > On 31/10/2022 18:16, Daniel Golle wrote: > > Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit > > found in MT7981 and MT7986 SoCs. > > > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > > --- > > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > index 5c7e7bdd029abf..efc16ab5b22b5d 100644 > > --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > @@ -13,6 +13,7 @@ Required properties: > > - "mediatek,mt2701-thermal" : For MT2701 family of SoCs > > - "mediatek,mt2712-thermal" : For MT2712 family of SoCs > > - "mediatek,mt7622-thermal" : For MT7622 SoC > > + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC > > Then recommended is to have specific compatible followed by fallback (so > 7986 followed by 7981) I'm a bit confused about the order you are suggesting. It may seem counter-intuitive, but MT7986 was released before MT7981, the thermal units found in both SoCs seems to be exactly identical. Or are you suggesting to list MT7981 first to maintain alphabetical order? Because in terms of precedence, MT7986 has been there first, and hence I'd list 7986 first, followed by 7981, ie. the opposite of the order you were suggesting.
On 30/11/2022 13:09, Daniel Golle wrote: > On Wed, Nov 02, 2022 at 04:43:35PM -0400, Krzysztof Kozlowski wrote: >> On 31/10/2022 18:16, Daniel Golle wrote: >>> Add compatible string 'mediatek,mt7986-thermal' for V3 thermal unit >>> found in MT7981 and MT7986 SoCs. >>> >>> Signed-off-by: Daniel Golle <daniel@makrotopia.org> >>> --- >>> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt >>> index 5c7e7bdd029abf..efc16ab5b22b5d 100644 >>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt >>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt >>> @@ -13,6 +13,7 @@ Required properties: >>> - "mediatek,mt2701-thermal" : For MT2701 family of SoCs >>> - "mediatek,mt2712-thermal" : For MT2712 family of SoCs >>> - "mediatek,mt7622-thermal" : For MT7622 SoC >>> + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC >> >> Then recommended is to have specific compatible followed by fallback (so >> 7986 followed by 7981) > > I'm a bit confused about the order you are suggesting. It may seem > counter-intuitive, but MT7986 was released before MT7981, the thermal > units found in both SoCs seems to be exactly identical. > Or are you suggesting to list MT7981 first to maintain alphabetical > order? Because in terms of precedence, MT7986 has been there first, and > hence I'd list 7986 first, followed by 7981, ie. the opposite of the > order you were suggesting. > I have no clue which came first. Choose whatever is reasonable. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt index 5c7e7bdd029abf..efc16ab5b22b5d 100644 --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt @@ -13,6 +13,7 @@ Required properties: - "mediatek,mt2701-thermal" : For MT2701 family of SoCs - "mediatek,mt2712-thermal" : For MT2712 family of SoCs - "mediatek,mt7622-thermal" : For MT7622 SoC + - "mediatek,mt7986-thermal" : For MT7981 and MT7986 SoC - "mediatek,mt8183-thermal" : For MT8183 family of SoCs - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs - reg: Address range of the thermal controller