Message ID | 20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-v4-4-2592c29ea263@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5099957vqo; Fri, 12 May 2023 06:19:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5iCwAvAHQ3F8dJc7Rd2hPlVNHH9YxlU0u7m0R1yX2xkAi9lywaN/K6xw7veiq2isnLq+Bt X-Received: by 2002:a17:903:2342:b0:1a5:1438:9bcd with SMTP id c2-20020a170903234200b001a514389bcdmr32296593plh.35.1683897598705; Fri, 12 May 2023 06:19:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683897598; cv=none; d=google.com; s=arc-20160816; b=cX0O3b3hXfVG3tM8KuJQzREw+UrjZ5EideadmOsBsit22XxG9uB7o60xZMDejSCsOj wj6dDhp4XMWJsynD+FU8I9+mimAsjyJT3qK2omnTeSGrZb+/9y7dCyw9j1NBu0KTsZRs IZilUp8zYQbjj08z9cVShh9yGccjgv/e8vHwsLqsAIqBHd56Xm9zujBBYygUy8ifdb7E eFCwm37fXdRZarIkvLeVldYmJtkdm1u16w2H7YTbdUotqFoI0ANwT6zsvLW3K0OPEpMU BDlVoOs65vQluvQ/werPIMFhi7MLw1OiRJJqVPfL32YnLgVaBpJ9zow7/QOTF4a1LMaU qCBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=h5CBW3kP2kGkkwXUgvUKDH94eutksEhBTi5lS/gp2Ag=; b=UCDmt3WOgRQr089qyAiqDHIu2ered4WK77JaBlhdyyGHWEIkz/qo/qnZ11sWfjAf1w Xn8vIvHOt/DaSmFkE8qsZO0WaN40ohRVVXHudHRYe02XVcvQ48I/UCfrNaxtUb+ZbAg5 +BcGMinR3H+Fmt0hOx79tdSxjPyHUjEeApPLu+hrQyyZekbjqJ5QifG27znV9t2V6Zr3 q/frWs0lJJqlHS+hzrhycr3KiOM6mYBu/So5P+j3iSrkqM3NvPnBBYWobTWmNjS7Yv7c VEkKgIbMBY3LPcwEqi/axcfa97S2ux2NRJqX+YMlVoELyUOSTtVRvQaPhUcWoQNrH+Cy eD2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jI8+vLf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020a17090322ce00b001aada12d628si9460929plg.585.2023.05.12.06.19.45; Fri, 12 May 2023 06:19:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jI8+vLf6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241173AbjELNMO (ORCPT <rfc822;peekingduck44@gmail.com> + 99 others); Fri, 12 May 2023 09:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241119AbjELNMA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 12 May 2023 09:12:00 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C3111606 for <linux-kernel@vger.kernel.org>; Fri, 12 May 2023 06:11:58 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-305f0491e62so9545857f8f.3 for <linux-kernel@vger.kernel.org>; Fri, 12 May 2023 06:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683897117; x=1686489117; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h5CBW3kP2kGkkwXUgvUKDH94eutksEhBTi5lS/gp2Ag=; b=jI8+vLf6WkwRF5A+lUQc3hQYHJpGSDd0RbULbiPdoqTLQCpbUF5su9FAbPerXdwNhm 3IBj0Ie3gPaS402gPDR2Or+tPsLjmeI5NOCHjjADzZdX7lEvDDEkXjKYmu1IeHYdKYJm SpV8SmzPUVIzQJjDfuK8Bmk++vLDfQNt0cHvblI/492ea6zRid0MA5k322NeKeZ5NdR1 820dNd+XMHm8+WK4RoOvhRYao9v9b7DyMaEulz2pmL24P/0YkVmLNfTN1JXFmEcLGWGg SzS21ZmEjLbNfUbTmLC+PgJ8CmMuEJWhv1npeqFClr9xvkrtWmopb6mfyCmtZOv7t4Xn PL1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683897117; x=1686489117; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5CBW3kP2kGkkwXUgvUKDH94eutksEhBTi5lS/gp2Ag=; b=IhZeP+O+CxX7l+vX/UCV55xcevo85vn0kfytPN/71ov3eBFZ6z9Shk6Vb7HqsASlIp kPj6Gu5/S18Jlepq9naRjThcbbOheQ7/IqFzfwHkUpmcqmzrS9X3W8+0vuLhZp0Cv7Ea 7282vM8SP1zaWl5kKyPYU3LzP5RPFwKXeqBgNuS1CsoR6Q0U8sfSaA+5YGDWe6cqEMMh lyRV/RtzPhvMTrgbVUdTCm4WpE7K8eXQIyTrg6f2L924wD+4Dfn/0/A/BoCW8yZzyR4h 05wrVerrjYdza6lvg0euQiViX8rc0nhNxIL19bIZKm/8kgV4i4dYtf1hxOLC7pIL33sy SXhg== X-Gm-Message-State: AC+VfDzjTe6nNWPAq8BhKYj6SbXvBkJvgbs8WoHtORaOh6RKcnKDSHpG PPfxy9eqoPcPR0TON+mCTRj0jA== X-Received: by 2002:a5d:510c:0:b0:306:41d3:fcb9 with SMTP id s12-20020a5d510c000000b0030641d3fcb9mr17050014wrt.27.1683897117307; Fri, 12 May 2023 06:11:57 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id v10-20020a5d610a000000b0030647449730sm23461965wrt.74.2023.05.12.06.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 06:11:57 -0700 (PDT) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Fri, 12 May 2023 15:11:35 +0200 Subject: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-v4-4-2592c29ea263@linaro.org> References: <20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-v4-0-2592c29ea263@linaro.org> In-Reply-To: <20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-v4-0-2592c29ea263@linaro.org> To: Jerome Brunet <jbrunet@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Kevin Hilman <khilman@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Philipp Zabel <p.zabel@pengutronix.de>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Sam Ravnborg <sam@ravnborg.org> Cc: Nicolas Belin <nbelin@baylibre.com>, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, Neil Armstrong <neil.armstrong@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3529; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=3MDhT7q/WcievpQjDDNOoPwupOVRmxDglFnaq0Qxji0=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBkXjsTc+2KWxxsNC+gphTBNqaqjfizuK6hMljA2xoE Z/aoWqyJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCZF47EwAKCRB33NvayMhJ0ZUUD/ wNt+EVWvoMIIiD/p/Rv+tgsc/WgfOc/z75FQsHR+5VQ589t+rFNjeDyTKlJ5O5aJobCrdacSqnLpEq bzyLjlq3HKfA4YjnrOLeFmXa25+jsk/ST4Mfndym3UMtGBbUI1vParUsklWyZTxgFBFCfE5ttuPxcL EsehJagcpU/hORi76dRYwWnuYlk6ATXtedL41GVddLwOSz91l9jtne12ASBD96UeqvZn1Ef5IqMECO tbYbFy+Ce9jaP2w9NmGw+JoFfLwFvsiwcMCcoI9IhdtrIgtS+2lkN9yQdC4C/iWK19nag1IEtaIjiV Jlfe3o1ARZGG9IPOQkNNPL6U122YKZ4qQbmwDPjmo5nH0k/AIRIdZo6DkOHF/z1jTeC+Wu7C9LmLAY ZMXLtxilBdPpvHug3lk3XFd34OQlQNGtsmc5b8PhMy15O2J4U/UcChcnmie9AoraeI9P62QFu8ObFc Jvz7VL7dw84edBMAWac+wIJiXYnOHGwolkhXC5E3qzzkVR6fntQRiwoqYrtrCPDKGWjSq62k53t+vp HwQZ33cXpi9r2kTZn+XtUIpYYNpClXcKkbl/k28BJ95ATnA+JXcMSbWnvJZnuhyTc7RM7B2W0+3FMD zr9J6GwqEaWyZGSZEqOP1L2HTz797qI/OBWw7hVJDn6OTtPZNd1LIGa4f5FQ== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765694608383720293?= X-GMAIL-MSGID: =?utf-8?q?1765694608383720293?= |
Series |
drm/meson: add support for MIPI DSI Display
|
|
Commit Message
Neil Armstrong
May 12, 2023, 1:11 p.m. UTC
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic SoCs. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../display/amlogic,meson-g12a-dw-mipi-dsi.yaml | 117 +++++++++++++++++++++ 1 file changed, 117 insertions(+)
Comments
On Fri, May 12, 2023 at 03:11:35PM +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue > on the same Amlogic SoCs. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> This looks fine to me, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> but I would like Krzysztof to take a look too to be on the safe side! Cheers, Conor. > --- > .../display/amlogic,meson-g12a-dw-mipi-dsi.yaml | 117 +++++++++++++++++++++ > 1 file changed, 117 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml > new file mode 100644 > index 000000000000..8169c7e93ff5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2020 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/amlogic,meson-g12a-dw-mipi-dsi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +description: | > + The Amlogic Meson Synopsys Designware Integration is composed of > + - A Synopsys DesignWare MIPI DSI Host Controller IP > + - A TOP control block controlling the Clocks & Resets of the IP > + > +allOf: > + - $ref: dsi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - amlogic,meson-g12a-dw-mipi-dsi > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 3 > + > + clock-names: > + minItems: 3 > + items: > + - const: pclk > + - const: bit_clk > + - const: px_clk > + - const: meas_clk > + > + resets: > + minItems: 1 > + > + reset-names: > + items: > + - const: top > + > + phys: > + minItems: 1 > + > + phy-names: > + items: > + - const: dphy > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input node to receive pixel data. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: DSI output node to panel. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - reset-names > + - phys > + - phy-names > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + dsi@7000 { > + compatible = "amlogic,meson-g12a-dw-mipi-dsi"; > + reg = <0x6000 0x400>; > + resets = <&reset_top>; > + reset-names = "top"; > + clocks = <&clk_pclk>, <&bit_clk>, <&clk_px>; > + clock-names = "pclk", "bit_clk", "px_clk"; > + phys = <&mipi_dphy>; > + phy-names = "dphy"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* VPU VENC Input */ > + mipi_dsi_venc_port: port@0 { > + reg = <0>; > + > + mipi_dsi_in: endpoint { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + /* DSI Output */ > + mipi_dsi_panel_port: port@1 { > + reg = <1>; > + > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > + }; > + }; > + }; > > -- > 2.34.1 >
On 12/05/2023 15:11, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue > on the same Amlogic SoCs. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../display/amlogic,meson-g12a-dw-mipi-dsi.yaml | 117 +++++++++++++++++++++ > 1 file changed, 117 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml > new file mode 100644 > index 000000000000..8169c7e93ff5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml > @@ -0,0 +1,117 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2020 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/amlogic,meson-g12a-dw-mipi-dsi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +description: | > + The Amlogic Meson Synopsys Designware Integration is composed of > + - A Synopsys DesignWare MIPI DSI Host Controller IP > + - A TOP control block controlling the Clocks & Resets of the IP > + > +allOf: > + - $ref: dsi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - amlogic,meson-g12a-dw-mipi-dsi > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 3 Missing maxItems > + > + clock-names: > + minItems: 3 > + items: > + - const: pclk > + - const: bit_clk > + - const: px_clk > + - const: meas_clk Drop _clk suffixes. pclk can stay, it's a bit odd but recently Rob clarified that suffix with underscore should not be there. > + > + resets: > + minItems: 1 maxItems instead > + > + reset-names: > + items: > + - const: top > + > + phys: > + minItems: 1 Ditto > + > + phy-names: > + items: > + - const: dphy > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input node to receive pixel data. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: DSI output node to panel. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - reset-names > + - phys > + - phy-names > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + dsi@7000 { > + compatible = "amlogic,meson-g12a-dw-mipi-dsi"; > + reg = <0x6000 0x400>; Your reg does not match unit address. The dt_binding_check should actually complain about it. Best regards, Krzysztof
On 13/05/2023 20:32, Krzysztof Kozlowski wrote: > On 12/05/2023 15:11, Neil Armstrong wrote: >> The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), >> with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue >> on the same Amlogic SoCs. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 This message may be automatic, but context is always important when reviewing, this commit message is a re-spin on v3 that was reviewed by rob but I decided to remove the review tags since I added a new clock and did some other cleanups. While the process describes "how the patch itself *should* be formatted", it's a best effort and not a blocker. I'll fix the wrapping since you pointed out, but referring to the submitting-patches.rst file (from a very old v5.18-rc4 version) is kind of childish. > > Subject: drop second/last, redundant "bindings". The "dt-bindings" > prefix is already stating that these are bindings. > >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../display/amlogic,meson-g12a-dw-mipi-dsi.yaml | 117 +++++++++++++++++++++ >> 1 file changed, 117 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml >> new file mode 100644 >> index 000000000000..8169c7e93ff5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml >> @@ -0,0 +1,117 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2020 BayLibre, SAS >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/amlogic,meson-g12a-dw-mipi-dsi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller >> + >> +maintainers: >> + - Neil Armstrong <neil.armstrong@linaro.org> >> + >> +description: | >> + The Amlogic Meson Synopsys Designware Integration is composed of >> + - A Synopsys DesignWare MIPI DSI Host Controller IP >> + - A TOP control block controlling the Clocks & Resets of the IP >> + >> +allOf: >> + - $ref: dsi-controller.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-g12a-dw-mipi-dsi >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 3 > > Missing maxItems Ack > >> + >> + clock-names: >> + minItems: 3 >> + items: >> + - const: pclk >> + - const: bit_clk >> + - const: px_clk >> + - const: meas_clk > > Drop _clk suffixes. pclk can stay, it's a bit odd but recently Rob > clarified that suffix with underscore should not be there. Ack > >> + >> + resets: >> + minItems: 1 > > maxItems instead Ack > >> + >> + reset-names: >> + items: >> + - const: top >> + >> + phys: >> + minItems: 1 > > Ditto Ack > >> + >> + phy-names: >> + items: >> + - const: dphy >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Input node to receive pixel data. >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: DSI output node to panel. >> + >> + required: >> + - port@0 >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - phys >> + - phy-names >> + - ports >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + dsi@7000 { >> + compatible = "amlogic,meson-g12a-dw-mipi-dsi"; >> + reg = <0x6000 0x400>; > > Your reg does not match unit address. The dt_binding_check should > actually complain about it. Well, it doesn't, will fix Thanks, Neil > > Best regards, > Krzysztof >
On 15/05/2023 18:15, Neil Armstrong wrote: > On 13/05/2023 20:32, Krzysztof Kozlowski wrote: >> On 12/05/2023 15:11, Neil Armstrong wrote: >>> The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), >>> with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue >>> on the same Amlogic SoCs. >> >> Please wrap commit message according to Linux coding style / submission >> process (neither too early nor over the limit): >> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > This message may be automatic, but context is always important when reviewing, > this commit message is a re-spin on v3 that was reviewed by rob but I decided to remove the review > tags since I added a new clock and did some other cleanups. > > While the process describes "how the patch itself *should* be formatted", it's a best effort > and not a blocker. Other issues are blockers. > > I'll fix the wrapping since you pointed out, but referring to the submitting-patches.rst > file (from a very old v5.18-rc4 version) is kind of childish. It's just a link stored in automated responses, what's here childish? It's still valid in current cycle! Look: https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 What's the difference? Srsly, I can point you to submitting patches without reference to specific line if you wish... Or you can check by yourself. I give the same reviews to so many people that have templates and Elixir happens to be the only place allowing bookmarking specific line. Which is helpful for beginners because the entire doc is huge. I can make an exception for you and never paste direct links. Best regards, Krzysztof
On 15/05/2023 18:22, Krzysztof Kozlowski wrote: > On 15/05/2023 18:15, Neil Armstrong wrote: >> On 13/05/2023 20:32, Krzysztof Kozlowski wrote: >>> On 12/05/2023 15:11, Neil Armstrong wrote: >>>> The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), >>>> with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue >>>> on the same Amlogic SoCs. >>> >>> Please wrap commit message according to Linux coding style / submission >>> process (neither too early nor over the limit): >>> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 >> >> This message may be automatic, but context is always important when reviewing, >> this commit message is a re-spin on v3 that was reviewed by rob but I decided to remove the review >> tags since I added a new clock and did some other cleanups. >> >> While the process describes "how the patch itself *should* be formatted", it's a best effort >> and not a blocker. > > Other issues are blockers. I agree with that > >> >> I'll fix the wrapping since you pointed out, but referring to the submitting-patches.rst >> file (from a very old v5.18-rc4 version) is kind of childish. > > It's just a link stored in automated responses, what's here childish? > It's still valid in current cycle! Look: > > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > What's the difference? Srsly, I can point you to submitting patches > without reference to specific line if you wish... Or you can check by > yourself. > > I give the same reviews to so many people that have templates and Elixir > happens to be the only place allowing bookmarking specific line. Which > is helpful for beginners because the entire doc is huge. > > I can make an exception for you and never paste direct links. I value those kind of links for beginners and newcomers, really, it's a good thing to do and we should all do the same. But I always take in account who I'm reviewing, and adapt my comments, I think it's sane to not appear as rude because we all forget to check some stuff when send patches upstream, or at least I often forget... Anyway, don't make exceptions or change your process for me, I'll live with it. Neil > > Best regards, > Krzysztof >
On 15/05/2023 18:28, neil.armstrong@linaro.org wrote: >> It's just a link stored in automated responses, what's here childish? >> It's still valid in current cycle! Look: >> >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >> >> What's the difference? Srsly, I can point you to submitting patches >> without reference to specific line if you wish... Or you can check by >> yourself. >> >> I give the same reviews to so many people that have templates and Elixir >> happens to be the only place allowing bookmarking specific line. Which >> is helpful for beginners because the entire doc is huge. >> >> I can make an exception for you and never paste direct links. > > I value those kind of links for beginners and newcomers, really, it's a good > thing to do and we should all do the same. Hm, if I understand correctly, you felt being patronized by my link? I apologize for that. It was not my intention and there is really no need to feel like that. Look, I have many, many templates so I can speed up review. This one I gave to many: https://lore.kernel.org/all/?q=f%3Akrzysztof+%22Please+wrap+commit+message+according+to+Linux+coding+style%22 Writing same review every damn time is a boring, absolutely huge waste of time. People just make too many same mistakes. Better to hit key shortcut. Over the time most of my templates grew a bit, because when I wrote "Please wrap to 75" submitter did not know what to wrap or why. To save myself work I extend the template to something more. The entire text and link is for the beginner, not for you. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml new file mode 100644 index 000000000000..8169c7e93ff5 --- /dev/null +++ b/Documentation/devicetree/bindings/display/amlogic,meson-g12a-dw-mipi-dsi.yaml @@ -0,0 +1,117 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/amlogic,meson-g12a-dw-mipi-dsi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +description: | + The Amlogic Meson Synopsys Designware Integration is composed of + - A Synopsys DesignWare MIPI DSI Host Controller IP + - A TOP control block controlling the Clocks & Resets of the IP + +allOf: + - $ref: dsi-controller.yaml# + +properties: + compatible: + enum: + - amlogic,meson-g12a-dw-mipi-dsi + + reg: + maxItems: 1 + + clocks: + minItems: 3 + + clock-names: + minItems: 3 + items: + - const: pclk + - const: bit_clk + - const: px_clk + - const: meas_clk + + resets: + minItems: 1 + + reset-names: + items: + - const: top + + phys: + minItems: 1 + + phy-names: + items: + - const: dphy + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input node to receive pixel data. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: DSI output node to panel. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - phys + - phy-names + - ports + +unevaluatedProperties: false + +examples: + - | + dsi@7000 { + compatible = "amlogic,meson-g12a-dw-mipi-dsi"; + reg = <0x6000 0x400>; + resets = <&reset_top>; + reset-names = "top"; + clocks = <&clk_pclk>, <&bit_clk>, <&clk_px>; + clock-names = "pclk", "bit_clk", "px_clk"; + phys = <&mipi_dphy>; + phy-names = "dphy"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* VPU VENC Input */ + mipi_dsi_venc_port: port@0 { + reg = <0>; + + mipi_dsi_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + + /* DSI Output */ + mipi_dsi_panel_port: port@1 { + reg = <1>; + + mipi_out_panel: endpoint { + remote-endpoint = <&mipi_in_panel>; + }; + }; + }; + };