Message ID | 20230507144753.192959-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1612442vqo; Sun, 7 May 2023 07:55:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6EaLwhad3TkPDbRxWffKiQaEBE8DUJM78lyAtWeHDVlIMdPYrntpVigmr8iLcF5peXWhhe X-Received: by 2002:a17:903:1249:b0:1ab:220a:9068 with SMTP id u9-20020a170903124900b001ab220a9068mr10173414plh.42.1683471348258; Sun, 07 May 2023 07:55:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683471348; cv=none; d=google.com; s=arc-20160816; b=Ut7AyoIBLYeZvaPWogMMn4WeLwUT0tGENbNZPLW8bsas1CHLgeKqW1Qp3KaCJE3yk1 5TMzq3F4JAvrOMNOe4lvVgV/J8Jc+u3TAYoZ+LoRaWCqpXKK9+WJtVTM1iXwL4pHXNio N4b2qXAZyM0i+WK4w33SwZNtL23QAXKakN34QLpON6F4znB7rsGkm84ykvWHqRJf/zpt wOB5FiELzIJ/JNKX9e+YKmQv19IbrCZ0s+aWt1PadTatzSHGBWAFZ+nn4k41tgVnxItu +yJ5/4mUcQb10H0Q5HyxoacEbq572TovchpaY363UgjyY3AlanJ19iO8Mo3HmIu1Raea s0rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=PBw+x9bvNtvt7zmxEBMLA8rMP4RbJHux+PW551gPw/Y=; b=MqweaMtVOsc40M08+a3e7RHsyx1a+4TG2NUayGcUbEFUgIV2+yCMOstd2tIRYdZaTM 6lWdOKvuJKBuMt7LwVi468X95EJLFjisX0+NsXXsyH6wd7JOacz8J/XX16Fh4WyZ+hWw DFvV22lCRJxW1jpjXi+6Zao1QEvPUvyusNtuC5JJm4RiMMpFXDOIeoPBMRDz3fv42f1j STu/Hq6w4xcppGbd2SM/VfBJJLHCgzpGrsZMqNNIq1fVjEoSPfqWxIJCYTGTY1RInwPK ACPkyxJFfI+E8kv7E+6dqEjKUUx4WwHrSQcmigrFs0flrzP4Z28SdGA7F2YbkOYdqdbT LezQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AwInZtYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m6-20020a170902db8600b001aaec71093fsi5699487pld.563.2023.05.07.07.55.32; Sun, 07 May 2023 07:55:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AwInZtYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbjEGOsC (ORCPT <rfc822;baris.duru.linux@gmail.com> + 99 others); Sun, 7 May 2023 10:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjEGOr7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 7 May 2023 10:47:59 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041931208D for <linux-kernel@vger.kernel.org>; Sun, 7 May 2023 07:47:58 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-50be17a1eceso7036687a12.2 for <linux-kernel@vger.kernel.org>; Sun, 07 May 2023 07:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683470876; x=1686062876; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=PBw+x9bvNtvt7zmxEBMLA8rMP4RbJHux+PW551gPw/Y=; b=AwInZtYbyq8MwNv/nmioV0/vEWMEkbmPYAXUNEB0pSDGTtmJrkEJirty3CUOkW0L6Q i/LwNUWeJZ7LAq22+3vPajyEeXdRjOHUWMv7Gf0fFmkjM0ipTyK6NWG+ch9bAdoNLY0U IURXOWqoQkWthEWtaYaZatybZDSHLg+EsGTHPzgTSGMgNVgXhhxhMvCGUgXzKRRJZA1J jLteEs5cBokvh1Yxd5m1vcTKZlfksAArtrZGr4fUy+VsiqjB2wLVCpq1cugD4qiARq1f T9r/21qTg4pWhVPVF81JXGhU7ryq/IlGoL9N1DJ1dKv6O8cXNEfVKeC6f6vAmxB+NoDc FvxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683470876; x=1686062876; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PBw+x9bvNtvt7zmxEBMLA8rMP4RbJHux+PW551gPw/Y=; b=fZIMssiQXAhLmzXRS5mXuduwlvhizeitMQt/v6Oi++n/EZkRPd+ZBBt5It1z1a6MOl 9yZsZfRmO0M6VMvGvCYY46BzUvcTv3QOvgBu7A1r4EzODOCnLWfRvqGs8wuSbmmk3VSj 01i2CMVm2bw1Qqj4wgzgu2+3DuH8u889d2JSe7sYfyvQ09byAGKUqoAwtiyoQaxdV45k acusLxHjzXCOpmHSHRErckQKmOzJOI/6q9LILASGC1MC1txcDbBNUgrYp/eHltki2UXz rKV28aIjIiohIUfSdgM6X5itdXuFx1ZZl6BsmToA3iUftMcGaukMPMEx7swyDSldupMI IQCQ== X-Gm-Message-State: AC+VfDwT+Y3jw2Zvt1UdoCI+ZNSVbSBxjB41COcZ+RVNV3iO9BF0V+fa h9W+QMFjBOp+mEd3AFkGNKXVaw== X-Received: by 2002:a17:907:3e8a:b0:94e:c142:df98 with SMTP id hs10-20020a1709073e8a00b0094ec142df98mr7721629ejc.60.1683470876419; Sun, 07 May 2023 07:47:56 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:1757:b51a:9965:e81]) by smtp.gmail.com with ESMTPSA id j23-20020a170906051700b00960005e09a3sm3752899eja.61.2023.05.07.07.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 07:47:55 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Inki Dae <inki.dae@samsung.com>, Seung-Woo Kim <sw0312.kim@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/exynos: g2d: staticize stubs in header Date: Sun, 7 May 2023 16:47:53 +0200 Message-Id: <20230507144753.192959-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765247652505698281?= X-GMAIL-MSGID: =?utf-8?q?1765247652505698281?= |
Series |
drm/exynos: g2d: staticize stubs in header
|
|
Commit Message
Krzysztof Kozlowski
May 7, 2023, 2:47 p.m. UTC
Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
inline:
drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes]
drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes]
Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Sunday, May 7, 2023 8:18 PM > To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim > <sw0312.kim@samsung.com>; Kyungmin Park > <kyungmin.park@samsung.com>; David Airlie <airlied@gmail.com>; Daniel > Vetter <daniel@ffwll.ch>; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org>; Alim Akhtar <alim.akhtar@samsung.com>; > Marek Szyprowski <m.szyprowski@samsung.com>; dri- > devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] drm/exynos: g2d: staticize stubs in header > > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static > inline: > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous > prototype for ‘g2d_open’ [-Wmissing-prototypes] > drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous > prototype for ‘g2d_close’ [-Wmissing-prototypes] > > Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h > b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > index 74ea3c26dead..1a5ae781b56c 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct > drm_device *dev, void *data, > return -ENODEV; > } > > -int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > { > return 0; > } > > -void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > { } > #endif > -- > 2.34.1
Hi Krzysztof, 2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>님이 작성: > > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static > inline: Same patch[1] was posted before so I picked up the previous one. [1] [PATCH] drm/exynos: fix g2d_open/close helper function definitions (kernel.org) Thanks, Inki Dae > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes] > drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes] > > Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > index 74ea3c26dead..1a5ae781b56c 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data, > return -ENODEV; > } > > -int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > { > return 0; > } > > -void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > { } > #endif > -- > 2.34.1 >
2023년 5월 15일 (월) 오후 1:13, Inki Dae <daeinki@gmail.com>님이 작성: > > Hi Krzysztof, > > 2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org>님이 작성: > > > > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static > > inline: > > Same patch[1] was posted before so I picked up the previous one. > > [1] [PATCH] drm/exynos: fix g2d_open/close helper function definitions > (kernel.org) [1] https://lore.kernel.org/lkml/20230425165618.2ztg4mecuvpkdg3a@intel.intel/T/ Just corrected the link. > > Thanks, > Inki Dae > > > > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes] > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes] > > > > Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > > index 74ea3c26dead..1a5ae781b56c 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h > > @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data, > > return -ENODEV; > > } > > > > -int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > > +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file) > > { > > return 0; > > } > > > > -void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > > +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file) > > { } > > #endif > > -- > > 2.34.1 > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h index 74ea3c26dead..1a5ae781b56c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data, return -ENODEV; } -int g2d_open(struct drm_device *drm_dev, struct drm_file *file) +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file) { return 0; } -void g2d_close(struct drm_device *drm_dev, struct drm_file *file) +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file) { } #endif