Message ID | 20230514090432.78217-4-bagasdotme@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6199971vqo; Sun, 14 May 2023 02:16:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4nXoOYJd6Oxlo2d7Q8tpchv2cy+Nv9YuuH0vW8MNfcsSLWW0Q8rCg47CLdjN46oY8M7SH1 X-Received: by 2002:aa7:88ce:0:b0:645:6142:7f5a with SMTP id k14-20020aa788ce000000b0064561427f5amr30831886pff.3.1684055816788; Sun, 14 May 2023 02:16:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684055816; cv=none; d=google.com; s=arc-20160816; b=eULy4zQbndBK1NST1HJ+Sj0sYf5qPF3SyEgFsTPjZzsppKD7VDd/wBFg3MGTbUB4I9 RUs5AFvfy9w1Oz1DY7OHJbw/IHm6grwCJRLtMays2qU4lf2kZPRsiFTQG0bVhWoO6maa CA3m7BveQK/Mbr++j98EwBCyBmX6cPP7RJgqbCCOrmYckI+wwCAerDW1vgpiSxr5Hn1+ fAfQrc8oi4ofp8p+sT/dKklE1HiSqDNmGVZKwLdq9w9rqMJOItDj0sLGb3lz4C0OIAfO dzjyTLEqiLkX/L5kmLZeDg4i33aJR5tdmwCwYdEl45yVZ47UH0zbgUgMXnUlZBB4d27f pLgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qIanyhJS88Q7RfVNqljO8EtKKIvGna+18p2AMpDpX+U=; b=jiffRYw5JQCmDqWY+BdbT6Sjg4JHjDrB+ziE3cRjazGsc7Y9aDiHa1jJkFgBJzgqRN IBvfQGBWkvz2wxSSOyamjVrPL12FLG4sGVRy4r64SJuT79pxy9AleL34B/xSEGutBOl1 bcPXrIo7zv4rze4xWerqa3X+FlJot7avyX4MoTZEKuw45yoweLqAuQ89LNAb4rDeMXt1 fGFi1rFPZnS3dtxqZxEGT+/jwC9dWUgiSJzdNq7edqo9htoSAfm62BD3S8nEeAwMAINS RkEPF82h8mCMgUvbE6AtdZS4Sz/mi3TiIzFEr7qBBxVKQ5pVB16pXHrsoAWxyBEHZ5H1 AV+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CgLdpdVK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a621b0c000000b0064b03298c61si2705216pfb.84.2023.05.14.02.16.41; Sun, 14 May 2023 02:16:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CgLdpdVK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233987AbjENJEt (ORCPT <rfc822;peekingduck44@gmail.com> + 99 others); Sun, 14 May 2023 05:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbjENJEn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 14 May 2023 05:04:43 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED2E1BE2; Sun, 14 May 2023 02:04:42 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5307502146aso2631330a12.1; Sun, 14 May 2023 02:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684055082; x=1686647082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qIanyhJS88Q7RfVNqljO8EtKKIvGna+18p2AMpDpX+U=; b=CgLdpdVKhiQqsKr2AyMNHWm3uR3kk6DMFszCy7EQcABgt28gkiZ1AafbMGbW86JTx+ LnizcfPOhbNBU8/9RIfbvviAVLKL1ApA166UNnezr4YyshFLSs+QU908wo51TG06sFUn 6vwOI3CzVmcFf9Rtmw2XNfDisol0wwtMnYLSalk8sHyygzfj7RXU2E0S5A3rVNLe39cR P9B3/gSUsU9KGsf+To00d+xpUeEBLJy8bzbwQhFkSQSDjJkM8eLN3QknKrQRTgN3aOg1 LLg2u3AUAQJQG1iOcSi9qA9U4jCzF82jq5Jb8ACLvSevx4NBSVdYaSwjhoKG0QHfQPWI C1Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684055082; x=1686647082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qIanyhJS88Q7RfVNqljO8EtKKIvGna+18p2AMpDpX+U=; b=IVTh4R3jtUWvddI4EJDi5QtZnIc09RSZuZkZ139sOmRjryZ0s1Nz+zmcrgwc3xCm7C znZlA1/G2hfx+jgdxtuj9ypOanVE9gGZx7CLr8kWfFCyYTLQp9jadO3ybWQ66i1Nt5c7 vBpbCP0Qua1iOqbZiZv/wMlUKif90DGS2fkrbcEmnYHIc8mlg9R07ItqQbRtzKMcg56c k1k/qPu3rB6y14oTraN8dZxJCwbU86JGJIuLNUMBQ6IgR9z27ivmYdMAFeG/mqK5CzDG DOtH38nFlN9qLNp20Ak81q+KV+yKsWOWuybWexPREexfUrRcl/XJZCGlfNTptQTcJlsk U2PQ== X-Gm-Message-State: AC+VfDyv8fYYhXybBkvYIbiHI9ICSKouDz39rTcipVt7oGGOEFKSvZHP 2IZCGjQ4IHaSpX9kjDxIWjc= X-Received: by 2002:a17:903:22cb:b0:1ac:6e1f:d19c with SMTP id y11-20020a17090322cb00b001ac6e1fd19cmr30176048plg.41.1684055081976; Sun, 14 May 2023 02:04:41 -0700 (PDT) Received: from debian.me (subs02-180-214-232-68.three.co.id. [180.214.232.68]) by smtp.gmail.com with ESMTPSA id jj3-20020a170903048300b001a9666376a9sm11029564plb.226.2023.05.14.02.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 May 2023 02:04:41 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 6CA011061DE; Sun, 14 May 2023 16:04:36 +0700 (WIB) From: Bagas Sanjaya <bagasdotme@gmail.com> To: Linux Documentation <linux-doc@vger.kernel.org>, Linux RISC-V <linux-riscv@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Cc: Jonathan Corbet <corbet@lwn.net>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Bagas Sanjaya <bagasdotme@gmail.com>, Vincent Chen <vincent.chen@sifive.com>, Andy Chiu <andy.chiu@sifive.com>, Greentime Hu <greentime.hu@sifive.com> Subject: [PATCH 3/5] Documentation: riscv: vector: Use bullet lists for prctl list Date: Sun, 14 May 2023 16:04:30 +0700 Message-Id: <20230514090432.78217-4-bagasdotme@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230514090432.78217-1-bagasdotme@gmail.com> References: <20230514090432.78217-1-bagasdotme@gmail.com> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1431; i=bagasdotme@gmail.com; h=from:subject; bh=cZzclkM/zLfkcp8yZSx1IGcKkEsU6t+56HAynF/Kr40=; b=owGbwMvMwCX2bWenZ2ig32LG02pJDCkJS+R/RJzdLfV0aWb3xHVc1QXO9/n0mb18FBjuz246V HJDISSxo5SFQYyLQVZMkWVSIl/T6V1GIhfa1zrCzGFlAhnCwMUpABNZl8HIsCvPbkujH3+x3hJt oyKnX5v2sJq/UmgWD6lSrFV/6MfPysiw6g130FSu6xuc+hdWP3zTcr5Vwe9Jyox87rIcya02b6S 4AQ== X-Developer-Key: i=bagasdotme@gmail.com; a=openpgp; fpr=701B806FDCA5D3A58FFB8F7D7C276C64A5E44A1D Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765860512258242639?= X-GMAIL-MSGID: =?utf-8?q?1765860512258242639?= |
Series |
riscv: Fixes for vector extension documentation
|
|
Commit Message
Bagas Sanjaya
May 14, 2023, 9:04 a.m. UTC
The documentation lists two userspace prctl() calls. Use bullet
lists for the listing.
Fixes: 412c68cfeeb178 ("riscv: Add documentation for Vector")
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/riscv/vector.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hey Bagas, On Sun, May 14, 2023 at 04:04:30PM +0700, Bagas Sanjaya wrote: > The documentation lists two userspace prctl() calls. Use bullet > lists for the listing. > > Fixes: 412c68cfeeb178 ("riscv: Add documentation for Vector") Firstly, these fixes commit hashes would not be stable as this series has been applied to riscv/for-next [1]. But also, from this commit onwards, things seem like stylistic comments that would be undeserving of a Fixes: tag to begin with. Perhaps you'd be better off suggesting these changes in response to the original thread [2], so that it goes in "correctly" in the first place? Andy has to re-submit anyway as there are a few bugs that crept in in the most recent revision of his series. Thanks, Conor. 1 - https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=for-next 2 - https://lore.kernel.org/linux-riscv/20230509103033.11285-25-andy.chiu@sifive.com/ > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> > --- > Documentation/riscv/vector.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/riscv/vector.rst b/Documentation/riscv/vector.rst > index 178b3f3f452462..c7bd701c7963b6 100644 > --- a/Documentation/riscv/vector.rst > +++ b/Documentation/riscv/vector.rst > @@ -13,7 +13,7 @@ order to support the use of the RISC-V Vector Extension. > Two new prctl() calls are added to allow programs to manage the enablement > status for the use of Vector in userspace: > > -prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > +* prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > > Sets the Vector enablement status of the calling thread, where the control > argument consists of two 2-bit enablement statuses and a bit for inheritance > @@ -89,7 +89,7 @@ prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > * Every successful call overwrites a previous setting for the calling > thread. > > -prctl(PR_RISCV_V_SET_CONTROL) > +* prctl(PR_RISCV_V_SET_CONTROL) > > Gets the same Vector enablement status for the calling thread. Setting for > next execve() call and the inheritance bit are all OR-ed together. > -- > An old man doll... just what I always wanted! - Clara >
Hi Bagas, On Sun, May 14, 2023 at 5:49 PM Conor Dooley <conor@kernel.org> wrote: > > Hey Bagas, > > On Sun, May 14, 2023 at 04:04:30PM +0700, Bagas Sanjaya wrote: > > The documentation lists two userspace prctl() calls. Use bullet > > lists for the listing. > > > > Fixes: 412c68cfeeb178 ("riscv: Add documentation for Vector") > > Firstly, these fixes commit hashes would not be stable as this series > has been applied to riscv/for-next [1]. But also, from this commit > onwards, things seem like stylistic comments that would be undeserving > of a Fixes: tag to begin with. > Perhaps you'd be better off suggesting these changes in response to the > original thread [2], so that it goes in "correctly" in the first place? > Andy has to re-submit anyway as there are a few bugs that crept in in > the most recent revision of his series. > > Thanks, > Conor. > > 1 - https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=for-next > 2 - https://lore.kernel.org/linux-riscv/20230509103033.11285-25-andy.chiu@sifive.com/ > > > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> > > --- > > Documentation/riscv/vector.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/riscv/vector.rst b/Documentation/riscv/vector.rst > > index 178b3f3f452462..c7bd701c7963b6 100644 > > --- a/Documentation/riscv/vector.rst > > +++ b/Documentation/riscv/vector.rst > > @@ -13,7 +13,7 @@ order to support the use of the RISC-V Vector Extension. > > Two new prctl() calls are added to allow programs to manage the enablement > > status for the use of Vector in userspace: > > > > -prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > > +* prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > > > > Sets the Vector enablement status of the calling thread, where the control > > argument consists of two 2-bit enablement statuses and a bit for inheritance > > @@ -89,7 +89,7 @@ prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) > > * Every successful call overwrites a previous setting for the calling > > thread. > > > > -prctl(PR_RISCV_V_SET_CONTROL) > > +* prctl(PR_RISCV_V_SET_CONTROL) > > > > Gets the same Vector enablement status for the calling thread. Setting for > > next execve() call and the inheritance bit are all OR-ed together. > > -- > > An old man doll... just what I always wanted! - Clara > > Thanks for fixing the document. Do you mind if I merge them into my patch and add you as a co-developer? I think merging those fixes into the one original patch would be much cleaner than providing fix patches afterward. Thanks, Andy
diff --git a/Documentation/riscv/vector.rst b/Documentation/riscv/vector.rst index 178b3f3f452462..c7bd701c7963b6 100644 --- a/Documentation/riscv/vector.rst +++ b/Documentation/riscv/vector.rst @@ -13,7 +13,7 @@ order to support the use of the RISC-V Vector Extension. Two new prctl() calls are added to allow programs to manage the enablement status for the use of Vector in userspace: -prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) +* prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) Sets the Vector enablement status of the calling thread, where the control argument consists of two 2-bit enablement statuses and a bit for inheritance @@ -89,7 +89,7 @@ prctl(PR_RISCV_V_SET_CONTROL, unsigned long arg) * Every successful call overwrites a previous setting for the calling thread. -prctl(PR_RISCV_V_SET_CONTROL) +* prctl(PR_RISCV_V_SET_CONTROL) Gets the same Vector enablement status for the calling thread. Setting for next execve() call and the inheritance bit are all OR-ed together.