diff mbox series

[v2] nvme: host: hwmon: constify pointers to hwmon_channel_info

Message ID 20230511174650.279452-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [v2] nvme: host: hwmon: constify pointers to hwmon_channel_info |

Commit Message

Krzysztof Kozlowski May 11, 2023, 5:46 p.m. UTC 
  Statically allocated array of pointed to hwmon_channel_info can be made
const for safety.

Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Correct whitespace (Christoph)
2. Add tag
---
 drivers/nvme/host/hwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck May 11, 2023, 8:44 p.m. UTC | #1 
On Thu, May 11, 2023 at 07:46:50PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
> 
> Acked-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> 
> ---
> 
> Changes since v1:
> 1. Correct whitespace (Christoph)
> 2. Add tag
> ---
>  drivers/nvme/host/hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/hwmon.c b/drivers/nvme/host/hwmon.c
> index 9e6e56c20ec9..6aa153f3178a 100644
> --- a/drivers/nvme/host/hwmon.c
> +++ b/drivers/nvme/host/hwmon.c
> @@ -185,7 +185,7 @@ static umode_t nvme_hwmon_is_visible(const void *_data,
>  	return 0;
>  }
>  
> -static const struct hwmon_channel_info *nvme_hwmon_info[] = {
> +static const struct hwmon_channel_info *const nvme_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
>  	HWMON_CHANNEL_INFO(temp,
>  			   HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_MIN |
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/nvme/host/hwmon.c b/drivers/nvme/host/hwmon.c
index 9e6e56c20ec9..6aa153f3178a 100644
--- a/drivers/nvme/host/hwmon.c
+++ b/drivers/nvme/host/hwmon.c
@@ -185,7 +185,7 @@  static umode_t nvme_hwmon_is_visible(const void *_data,
 	return 0;
 }
 
-static const struct hwmon_channel_info *nvme_hwmon_info[] = {
+static const struct hwmon_channel_info *const nvme_hwmon_info[] = {
 	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
 	HWMON_CHANNEL_INFO(temp,
 			   HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_MIN |