| Message ID | 20221028231309.565451-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1090345wru;
Fri, 28 Oct 2022 16:17:39 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM5wSZqUyE2VsA7qKGQSeE7ZAe/Z03siQPx4RBC9gELk4SKQKdTdGHGYz4vNADpLiMZXrVbJ
X-Received: by 2002:a17:906:ef8c:b0:78d:96b9:a0ad with SMTP id
ze12-20020a170906ef8c00b0078d96b9a0admr1520353ejb.529.1666999058999;
Fri, 28 Oct 2022 16:17:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666999058; cv=none;
d=google.com; s=arc-20160816;
b=znNd3N+74MFLCVX/9FX3J32xRaPhXrmd6D6qUzM/Pj+lEIwxrQiQwXQnMSLuh/OjMY
Pmp7AS4PjRtndnFUnRy7eWjxnwWM7rRxwIwluis8Xwsze9ZkInOL9GL49ho+v5NalFn+
oVRfXL6qFufEJhD7WY7h7esN/4mwSeZaxdbtNAIq+1uXDBg5xxcTBIQnani0TizoIGqw
jH+QbzPmyNhEBl9ymjfhyYL+9C7uL685igJcIl5+P5E9Es7Q5r7ZuF13SJ9F8baTitcw
ed5t/VE6EQ1/JifvORr03cd1C7hwYggCOd3bEc60VLErFHqjfawAryz9JAqIl/zFonst
cAGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=ukQQfOYSPm/+bCMthg8nZwj163N2VFbmekvUQi+HF/A=;
b=qnpHRXKNvRScnWkprcmVep0mLIZDytbUCl2syS2hhedhkPvB+afyHOYCIKp1O6Fau/
6oceNWdTs6Jj/eksouETwSd4a82FS2tIWh9jnJYCoBRu/aonjZa4eQaayxcjPA5SHO3c
DBpDBMMdMHmXufRcv4TvRG/b+jG0au9DM3jie7NnOBXx1lk129+Ms4YvWpAwkFebleEm
GAcjeduSCrT0wplbdagIjdVLwIImAFivpSwt0vGFxtTKuJM1Pycw2KK/NqcZSIoMIFAf
8gDbyHK/BfOEQ0A5G7r27Qz8+n8yoQ1vH+unl7qbwBI56X7q9bPEvenm3VwBxnpbfZRe
Dz4A==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=tJ0qVOk5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x9-20020a170906148900b0078dd7383ed8si5033903ejc.414.2022.10.28.16.17.14;
Fri, 28 Oct 2022 16:17:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=tJ0qVOk5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229743AbiJ1XNV (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others);
Fri, 28 Oct 2022 19:13:21 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52166 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229681AbiJ1XNP (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 28 Oct 2022 19:13:15 -0400
Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com
[IPv6:2607:f8b0:4864:20::f34])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5551DC0A4
for <linux-kernel@vger.kernel.org>;
Fri, 28 Oct 2022 16:13:13 -0700 (PDT)
Received: by mail-qv1-xf34.google.com with SMTP id n18so5034733qvt.11
for <linux-kernel@vger.kernel.org>;
Fri, 28 Oct 2022 16:13:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=ukQQfOYSPm/+bCMthg8nZwj163N2VFbmekvUQi+HF/A=;
b=tJ0qVOk5vF+xzBZsnUZQ+ugGW7Gw0IC12me1ZSTUBwfLTQ7s4iYoyLTvu/rN1YI1k5
nGBjdT0KpOXWsMAWJ4jvwqsMoK9nNegrLmmKIBICFtrEmvb3mgLffbp0haIjJef1H9yK
nL8uuRMXsuiPDY/1wmTrzPLZXAlBz/C6p+rr5Bd/0VWEDRtJA7NLwKwZvUW4QkbPECMa
s2y3T/Qw4ACeua7jIA8ub17tRcQy2yFHo7LI/a39RWGt0C4MnP8nUrekPIxwOu5Mfdu/
jQxBScD73yQNej/nyPWRkWzv18c/fM67KFZrep9JyZsRTfk5RAo6V8buYLaRSgVSafJW
NH5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=ukQQfOYSPm/+bCMthg8nZwj163N2VFbmekvUQi+HF/A=;
b=S0URc+ID9PRU55ekbdWOp8shbK9N6EOLMkRKc1PKFnN0BX1KL+n81YRy/TotKHktkp
nwtJ7mxv3fAxdmtDTWV0CKEJE3zt+n1cj3EIGs78hpEep769LPzwFbqw98B8NfN+tBC+
J5zUfq9dc6tVEKN4lAgUuwX9BAkkRFPwE098WZP33PbQVASUqBmXzydVAVDFL+6rz2Q7
61rl4KeGofUnYWIIy8dTujxRS7/nmQf0zi5HgPpzUzxyyi04LWgRlTheALApehuA1W8y
fOSBqfQzXytfAgBVMTKr4/CPMTg0Pf9DSPIRtJbG4/tgP0emYyDClMIQICYl9N6Ab0Wo
thuw==
X-Gm-Message-State: ACrzQf2RZDFNy4hFmKNCPSxX1BTji6VZXMYJKLC2Tb3ai528LoJh6xMb
nZIkSXn722VDXcPnVSmXNTEXCg==
X-Received: by 2002:ad4:5bc5:0:b0:4bb:7e1a:9de6 with SMTP id
t5-20020ad45bc5000000b004bb7e1a9de6mr1618274qvt.68.1666998792570;
Fri, 28 Oct 2022 16:13:12 -0700 (PDT)
Received: from krzk-bin.. ([64.57.193.93])
by smtp.gmail.com with ESMTPSA id
ay7-20020a05620a178700b006cfc1d827cbsm8256qkb.9.2022.10.28.16.13.10
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 28 Oct 2022 16:13:11 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Osipenko <digetx@gmail.com>,
Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
Date: Fri, 28 Oct 2022 19:13:09 -0400
Message-Id: <20221028231309.565451-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747975205545932343?=
X-GMAIL-MSGID: =?utf-8?q?1747975205545932343?=
|
| Series |
dt-bindings: mfd: Expect specific type for monitored-battery
|
|
Commit Message
Krzysztof Kozlowski
Oct. 28, 2022, 11:13 p.m. UTC
Core schema does not define type of monitored-battery, so the schemas
are expected to reference proper type.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
Comments
On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > Core schema does not define type of monitored-battery, so the schemas > are expected to reference proper type. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) Applied, thanks.
On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > Core schema does not define type of monitored-battery, so the schemas > > are expected to reference proper type. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > 2 files changed, 4 insertions(+), 1 deletion(-) > > Applied, thanks. NAK. Please drop or revert. Rob
On Mon, 31 Oct 2022, Rob Herring wrote: > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > Core schema does not define type of monitored-battery, so the schemas > > > are expected to reference proper type. > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > Applied, thanks. > > NAK. Please drop or revert. Dropping is not a problem. Would you mind providing some context?
On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote: > > On Mon, 31 Oct 2022, Rob Herring wrote: > > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > > > Core schema does not define type of monitored-battery, so the schemas > > > > are expected to reference proper type. > > > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > NAK. Please drop or revert. > > Dropping is not a problem. > > Would you mind providing some context? I did elsewhere in the series, but simply we don't want to define a type for a property multiple times. It should be defined once somewhere common. Rob
On Tue, 01 Nov 2022, Rob Herring wrote: > On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote: > > > > On Mon, 31 Oct 2022, Rob Herring wrote: > > > > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > > > > > Core schema does not define type of monitored-battery, so the schemas > > > > > are expected to reference proper type. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > --- > > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > > > Applied, thanks. > > > > > > NAK. Please drop or revert. > > > > Dropping is not a problem. > > > > Would you mind providing some context? > > I did elsewhere in the series, but simply we don't want to define a > type for a property multiple times. It should be defined once > somewhere common. ACK, thanks. Dropped.
diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml index 06ed9ec8f4bb..b4c6f9529ce1 100644 --- a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml @@ -22,7 +22,9 @@ properties: reg: maxItems: 1 - monitored-battery: true + monitored-battery: + $ref: /schemas/types.yaml#/definitions/phandle + power-supplies: true system-power-controller: true diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml index 935e17099213..d136a05c7758 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml @@ -126,6 +126,7 @@ properties: type: object properties: monitored-battery: + $ref: /schemas/types.yaml#/definitions/phandle description: | A phandle to a monitored battery node that contains a valid value for: