diff mbox series

rs6000/test: Fix typo in pr86731-fwrapv-longlong.c [PR106682]

Message ID 53930ee1-da0f-0c33-cd6d-1d936584ffdd@linux.ibm.com
State New, archived
Headers
Series rs6000/test: Fix typo in pr86731-fwrapv-longlong.c [PR106682] |

Commit Message

Kewen.Lin Aug. 31, 2022, 9:33 a.m. UTC 
  Hi,

Commit r12-2266 updated the scanned assembly content from

  "{\mlvx\M|\mlxv\M|\mlxvd2x\M}"

to

  "{\mp?lxv\M|\mlxv\M|\mlxvd2x\M}"

for the test case pr86731-fwrapv-longlong.c unexpectedly.

It's meant to update "lxv" to "p?lxv" and should leave the
"lvx" unchanged.  So this is to fix the typo accordingly.

Tested on powerpc64-linux-gnu P7 and P8,
and powerpc64le-linux-gnu P9 and P10.

I'll push this soon if no objections.

BR,
Kewen
-----
	PR testsuite/106682

gcc/testsuite/ChangeLog:

	* gcc.target/powerpc/pr86731-fwrapv-longlong.c: Fix typo.
---
 gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.25.1

Comments

Peter Bergner Aug. 31, 2022, 2:53 p.m. UTC | #1 
On 8/31/22 4:33 AM, Kewen.Lin via Gcc-patches wrote:
> Commit r12-2266 updated the scanned assembly content from
> 
>   "{\mlvx\M|\mlxv\M|\mlxvd2x\M}"
> 
> to
> 
>   "{\mp?lxv\M|\mlxv\M|\mlxvd2x\M}"
> 
> for the test case pr86731-fwrapv-longlong.c unexpectedly.
> 
> It's meant to update "lxv" to "p?lxv" and should leave the
> "lvx" unchanged.  So this is to fix the typo accordingly.

I agree.  Thanks for catching this!

Peter
Segher Boessenkool Aug. 31, 2022, 3:12 p.m. UTC | #2 
On Wed, Aug 31, 2022 at 05:33:21PM +0800, Kewen.Lin wrote:
> It's meant to update "lxv" to "p?lxv" and should leave the
> "lvx" unchanged.  So this is to fix the typo accordingly.
> 
> I'll push this soon if no objections.

Please go ahead.  Out of interest, did you see failures from this, was
it just by visual inspection,  something else?

Thanks,


Segher
Kewen.Lin Sept. 1, 2022, 8:27 a.m. UTC | #3 
Hi Segher & Peter,

Thanks for your reviews!

on 2022/8/31 23:12, Segher Boessenkool wrote:
> On Wed, Aug 31, 2022 at 05:33:21PM +0800, Kewen.Lin wrote:
>> It's meant to update "lxv" to "p?lxv" and should leave the
>> "lvx" unchanged.  So this is to fix the typo accordingly.
>>
>> I'll push this soon if no objections.
> 
> Please go ahead.  Out of interest, did you see failures from this, was
> it just by visual inspection,  something else?
> 

I did reproduce the failure for this test case on ppc64 P8 machine. :)
For the other test cases updated by commit r12-2266, I did a quick visual
inspection on them instead of actually testing them, there are some other
typos but they have been fixed by r12-2889-g8464894c86b03e.

To avoid some to escape, I just tested the other cases on ppc64 P8 and
ppc64le P9 and P10, no failures were found.

So committed as r13-2332-g023c5b36e47697.  Thanks!

BR,
Kewen
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
index dcb30e1d886..018e1cf9749 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
@@ -31,5 +31,5 @@  vector signed long long splats4(void)

 /* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 0 } } */
 /* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 0 } } */
-/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlxv\M|\mlxvd2x\M|\mxxspltidp\M} 2 } } */
+/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlvx\M|\mlxvd2x\M|\mxxspltidp\M} 2 } } */