Message ID | 20221101105242.2019036-1-matthias.schiffer@ew.tq-group.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2883431wru; Tue, 1 Nov 2022 04:00:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4wMGjGGM8BBO828WyTKTOp+s0ADqpxGyny5a0KhJrBwQsEdofQuTcFsJED4qqR1LESXEct X-Received: by 2002:a05:6402:294a:b0:461:b661:d903 with SMTP id ed10-20020a056402294a00b00461b661d903mr18287397edb.407.1667300453102; Tue, 01 Nov 2022 04:00:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667300453; cv=none; d=google.com; s=arc-20160816; b=YPHVEqKcq0LazsSCR9+ESRE1C/80GnVPZHgQTomlKzp80eHyeMRnlXJt34l+XOPJ9/ ltcXrkiw7Rh2ZcvOOeAWIayeRwCRSNq6iZXtaXuSNQMTMTh93BzzixwFkfsYMCiit5FS +fyLdNqzVmWIOIhUWfcFsbaiA3OBaWljUmPWKBsPB2vOSqGn7LscsftrUzKkxiJsSGcW C43JhESZnQNdcJTDbQ+ceew0EYhFVZOsmerxOc43p6WGrJ5uauafl5omKkQ1PthR+MgE FisLyTCOOmA7+J/SY0ULvtghpPQddS+7S6NqxHe/mKCyAYQLUPvanpb/swIttPqS062A M33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=iR5nbEeb8llq1Y8iZDzFZH97eYqMxkF8ru+fo1WsjQk=; b=D+/73BH5HrzGu6SBfszamOqmUZFoFGoW9o2EqmfDrpnqrWmUfhe0hO8yr1Soa/2rjL GXzjS55cHzvEnMK2H+9LqDOkh9VzhvVWe8Q5RFr9lI8kpK955Mtt2vZjcCzLGpvEUnKS NlnGeLF5Jcfh9K8garPJcDjMtSJs+51WBHzYjvsNiIjrmnE2pn5kSEFNoBjqCXTqEvEx pWqTmdmUTDlOT5DrOD+jtFLhxOmgKWjaU6xPX7J6GMZ0Yr48nhJ7bc3EA1Xk6HcP1eAb 3Tc4mYdzlEsMWWdr5HJiVIGLRzIQdUnlyyRZhUbiACVLzphhVMeXhUqynR5tew+eyuHB m33g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=kY6mgNDZ; dkim=pass header.i=@tq-group.com header.s=key1 header.b=DsAO7v5a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa8-20020a170906fd8800b007acdb4016e0si13948793ejb.224.2022.11.01.04.00.28; Tue, 01 Nov 2022 04:00:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tq-group.com header.s=key1 header.b=kY6mgNDZ; dkim=pass header.i=@tq-group.com header.s=key1 header.b=DsAO7v5a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tq-group.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbiKAKxZ (ORCPT <rfc822;kartikey406@gmail.com> + 99 others); Tue, 1 Nov 2022 06:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiKAKxW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 1 Nov 2022 06:53:22 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8348833B; Tue, 1 Nov 2022 03:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667300000; x=1698836000; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iR5nbEeb8llq1Y8iZDzFZH97eYqMxkF8ru+fo1WsjQk=; b=kY6mgNDZ4o7GysJNxiBJWCSdhJeLMSCsXgzjuu2UlKJ8aZ0N1/qrXORF weqbaQym9ts9Y916NSYx0nrCRKKjpvY8QjQtwVkiuQerQl2C09mlb61Hb Ud3i8obBmYXADHKW8KGF3Lw8dvgkFEv4Q6XACBGmKpwN3YKBK/nH2tZua 3DyqIHor3iCTbhfl8Nh1ymkqAjQPyz4ZMXxK5e4NPkA2aYZHf7H+nCRsW FpFDLqTx0OgdarmtkmjOuuDgrrNDZpfaXjaL81sVQpavSKpO/fldzWRwO nuV8n2ssjn/rYk6Qhp0s8GS8/Qa4WHanhDBxtWMDGgwoznGtbLHC8O9c1 A==; X-IronPort-AV: E=Sophos;i="5.95,230,1661810400"; d="scan'208";a="27084645" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 01 Nov 2022 11:53:18 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 01 Nov 2022 11:53:18 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 01 Nov 2022 11:53:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667299998; x=1698835998; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iR5nbEeb8llq1Y8iZDzFZH97eYqMxkF8ru+fo1WsjQk=; b=DsAO7v5asU45fn25A/NOWFVRclqqAMh4qvgqKmiQCaYnV6OULs8ciJwD cGOIIEjJUuMbLAK2gzmzJGTtVQlc4OrBPXaGDmHqYLJZJ74z9YdjHAsjA JLe9ePi41EKKs/Ah3MZjSyrMWx7DV6WuEoRJ2G1Y91+LkoOjQYTeK8wEC gQf6T/9Fa4PVLiGMPc1/2XDSjVmIPhzCRa6wwWBXkv31rgXnu0PZY15q2 TnH1NF56LOOLaHQwhEYqbssSC60SaS4deg51Dy7/66UruiaLgz9Wd2BIJ 6ffaJ5/g1nttCZsZzpbBWPBwoba82E5E4dr9ZmDVXpYxpocntePeK3wwe Q==; X-IronPort-AV: E=Sophos;i="5.95,230,1661810400"; d="scan'208";a="27084644" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 01 Nov 2022 11:53:18 +0100 Received: from localhost.localdomain (SCHIFFERM-M2.tq-net.de [10.121.49.14]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 17CD0280056; Tue, 1 Nov 2022 11:53:18 +0100 (CET) From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> To: Adrian Hunter <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Subject: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code Date: Tue, 1 Nov 2022 11:52:42 +0100 Message-Id: <20221101105242.2019036-1-matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748291240116551037?= X-GMAIL-MSGID: =?utf-8?q?1748291240116551037?= |
Series |
mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code
|
|
Commit Message
Matthias Schiffer
Nov. 1, 2022, 10:52 a.m. UTC
Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/mmc/host/sdhci_am654.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 1/11/22 12:52, Matthias Schiffer wrote: > Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci_am654.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 8f1023480e12..4e17efa8ab97 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev) > > ret = mmc_of_parse(host->mmc); > if (ret) { > - dev_err(dev, "parsing dt failed (%d)\n", ret); > + dev_err_probe(dev, ret, "parsing dt failed\n"); > goto pm_runtime_put; > } >
On Tue, 1 Nov 2022 at 11:53, Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > > Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci_am654.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 8f1023480e12..4e17efa8ab97 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev) > > ret = mmc_of_parse(host->mmc); > if (ret) { > - dev_err(dev, "parsing dt failed (%d)\n", ret); > + dev_err_probe(dev, ret, "parsing dt failed\n"); > goto pm_runtime_put; > } > > -- > 2.25.1 >
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 8f1023480e12..4e17efa8ab97 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev) ret = mmc_of_parse(host->mmc); if (ret) { - dev_err(dev, "parsing dt failed (%d)\n", ret); + dev_err_probe(dev, ret, "parsing dt failed\n"); goto pm_runtime_put; }