| Message ID | 20230510151542.312588-2-aidanmacdonald.0x0@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3722798vqo;
Wed, 10 May 2023 08:45:23 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ5H4k8qEqDhij8xAHSxkrtznRORgyjO5Z62asbj8/TlGDV8gDHDdit8IlU4vTT4yZFm9ike
X-Received: by 2002:a17:903:2307:b0:1ac:a61c:7a14 with SMTP id
d7-20020a170903230700b001aca61c7a14mr5779847plh.62.1683733523364;
Wed, 10 May 2023 08:45:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1683733523; cv=none;
d=google.com; s=arc-20160816;
b=hBCqC5qC+ZfUTfWv1J2dXdHM18BkLGnaQ+2A6bRQqPISYrUW+yxDRBE2hjGM2U4zCM
L1M6JC7+415zPvKlyCN/xb52hMxryBMlpEPiwqFlsouSJRlcDWnY9haEsBLiwMKbkPrK
RattQY/9odC9oTua2EZQOaD94d/jf8IBL5pB1sqvezVwVGA4nsgnTAp8DcA67u5wNsj9
XgInze1AZuF4CZe5atduGXzFu8SyUI8amyalIgsqIT0JvGEaKfILHPqsvNkASrQGtZ4D
I8hTnbOE/agEToAlzkmAk61huCJkM4OhInEYsvAtKYNCen8yjSSgm2Te/4rgNqybJCtU
eUOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=QJwZXQFjVpMj2S27IS+ax8WA5RmmDUnh26i6v4v3GNA=;
b=bu9DDEqXi9NxJNSJ5pDsto8YKHDGjRkLFmf8Grh5y0WjatGer4fCd0X7MQn9qhKqrJ
IajRnCcVGGZC3gtJs3qmB/aVKqw3xuHr3eUiEHbV5uJ2Hfl/87lB436e2vn9OhBEnuPB
jkzSeYIH8R3irs5+6vs6FjWvn4G3bpBKv0jg5sdZ/p6lQcMnLLDEApTlTMq4r6znd9vt
pb2ESrjmuEnczfqyRKMJ4QmIdT3F3T/4vb6+iSLXXJwb6G+y6avPNeRNUjUgGOx3NTyp
CBYuYwx0U2JM+OwMcmXegzuVMQ/QlbtedzJfeZZLfkjhvZj52/YQlVFGBK2mOfwGtflz
78Dg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20221208 header.b=DOs5iepZ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
h11-20020a170902748b00b001aaec7031b5si4044768pll.182.2023.05.10.08.45.07;
Wed, 10 May 2023 08:45:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20221208 header.b=DOs5iepZ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S237637AbjEJPQB (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com>
+ 99 others); Wed, 10 May 2023 11:16:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43574 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S237275AbjEJPP7 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 10 May 2023 11:15:59 -0400
Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com
[IPv6:2a00:1450:4864:20::32d])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59E019A6;
Wed, 10 May 2023 08:15:49 -0700 (PDT)
Received: by mail-wm1-x32d.google.com with SMTP id
5b1f17b1804b1-3f42d937d61so16314935e9.3;
Wed, 10 May 2023 08:15:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1683731748; x=1686323748;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=QJwZXQFjVpMj2S27IS+ax8WA5RmmDUnh26i6v4v3GNA=;
b=DOs5iepZj6CS5TDUGq5CFHgkXWFpiNAeUOHOxPkeznNHoOzC2NajlszLqZTY54BOHS
Ast+IVEzDC+52+KF+lBtUHe5o7Io2TwGA0vCs0kR/3GbSa+BmKacL90xin92w0FGwZ5+
nIfPs3n6Ga7raD7WA6TZGWRYw0RkwjMnpxGZLLb7T68NBIlUd0hiEd6cot3mxi2t90zJ
Butoegi2cgoSbKNMxvVoT0TAgQ3vetT0f4yE/X4G/QLvnwj2lj+QXdRQuLnd5t2DpcPU
G1WtTALvYKmy3dWc0VN1K78TP3B9IwEoP99C66EwDjxVVzjPqhuGoIxUJjxQkk8iLERh
xLiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1683731748; x=1686323748;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=QJwZXQFjVpMj2S27IS+ax8WA5RmmDUnh26i6v4v3GNA=;
b=QPxux/5AGQ5gWFEo6sNf81ukgV1CH7dm9DR/V748P4jB1d3gGUO/1Oe/Y94r+Bg8Oe
vBmYlIrw6R4uGAk8lr7tP1jZpomYa1hcGnWI7wivr8kmOVYHO7EpPkZsjpf8vLU0mxOM
jZJnaYbbrOZuNaxoIiV/ke9SyijkFOQC9U4rXkjWXrwAY8n7wRXYRvR89Gr4qFxX5MDs
oPZQ0RKQvWp/zIDLO4ZVhM/szEGC30tOmO0qpC+lzlbrRIU4PUacnTHp22ZzTQLBWdhY
Y6u0g5vOn62XQ+S87sx34r3cMZ1g/IMNrWIOOQSSzfryu8qlXp0G8r9cJXA01qYhVEoK
SVnQ==
X-Gm-Message-State: AC+VfDw7cfDUMEp3KWJk2n71/lA4IG/m9nPBqfG2aWSUd4sAJKzHYq54
RD8A63zKvJ6z7omJVQv8AUE=
X-Received: by 2002:a7b:cb58:0:b0:3ee:b3bf:5f7c with SMTP id
v24-20020a7bcb58000000b003eeb3bf5f7cmr12765651wmj.23.1683731748058;
Wed, 10 May 2023 08:15:48 -0700 (PDT)
Received: from localhost ([167.98.27.226])
by smtp.gmail.com with ESMTPSA id
l2-20020a1c7902000000b003f195d540d9sm22822499wme.14.2023.05.10.08.15.47
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 10 May 2023 08:15:47 -0700 (PDT)
From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
wens@csie.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] dt-bindings: mfd: add bindings for AXP192 MFD device
Date: Wed, 10 May 2023 16:15:42 +0100
Message-Id: <20230510151542.312588-2-aidanmacdonald.0x0@gmail.com>
In-Reply-To: <20230510151542.312588-1-aidanmacdonald.0x0@gmail.com>
References: <20230510151542.312588-1-aidanmacdonald.0x0@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1765522562671478077?=
X-GMAIL-MSGID: =?utf-8?q?1765522562671478077?=
|
| Series |
[v1,1/2] mfd: axp20x: Add support for AXP192
|
|
Commit Message
Aidan MacDonald
May 10, 2023, 3:15 p.m. UTC
The AXP192 is another X-Powers PMIC similar to the existing ones.
Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On Wed, May 10, 2023 at 04:15:42PM +0100, Aidan MacDonald wrote: > The AXP192 is another X-Powers PMIC similar to the existing ones. In the driver patch the commit message says: | The AXP192 PMIC is similar to the AXP202/AXP209, but with different | regulators, additional GPIOs, and a different IRQ register layout. That'd be nice to have in the commit message here too, to explain why you're adding to the enum rather than listing a fallback. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> > --- > Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index f7f0f2c0421a..9ad55746133b 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -90,6 +90,7 @@ properties: > oneOf: > - enum: > - x-powers,axp152 > + - x-powers,axp192 > - x-powers,axp202 > - x-powers,axp209 > - x-powers,axp221 > -- > 2.39.2 >
Conor Dooley <conor@kernel.org> writes: > [[PGP Signed Part:Undecided]] > On Wed, May 10, 2023 at 04:15:42PM +0100, Aidan MacDonald wrote: >> The AXP192 is another X-Powers PMIC similar to the existing ones. > > In the driver patch the commit message says: > | The AXP192 PMIC is similar to the AXP202/AXP209, but with different > | regulators, additional GPIOs, and a different IRQ register layout. > > That'd be nice to have in the commit message here too, to explain why > you're adding to the enum rather than listing a fallback. > Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. > Will do, I'll send a v2 shortly. Regards, Aidan >> >> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> >> --- >> Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> index f7f0f2c0421a..9ad55746133b 100644 >> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> @@ -90,6 +90,7 @@ properties: >> oneOf: >> - enum: >> - x-powers,axp152 >> + - x-powers,axp192 >> - x-powers,axp202 >> - x-powers,axp209 >> - x-powers,axp221 >> -- >> 2.39.2 >> > > [[End of PGP Signed Part]]
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml index f7f0f2c0421a..9ad55746133b 100644 --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml @@ -90,6 +90,7 @@ properties: oneOf: - enum: - x-powers,axp152 + - x-powers,axp192 - x-powers,axp202 - x-powers,axp209 - x-powers,axp221